From patchwork Sat Jan 26 16:32:57 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
X-Patchwork-Id: 409
Return-Path: <laurent.pinchart@ideasonboard.com>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
	[213.167.242.64])
	by lancelot.ideasonboard.com (Postfix) with ESMTPS id E499160B2D
	for <libcamera-devel@lists.libcamera.org>;
	Sat, 26 Jan 2019 17:33:09 +0100 (CET)
Received: from pendragon.ideasonboard.com (85-76-41-125-nat.elisa-mobile.fi
	[85.76.41.125])
	by perceval.ideasonboard.com (Postfix) with ESMTPSA id D0D3823A
	for <libcamera-devel@lists.libcamera.org>;
	Sat, 26 Jan 2019 17:33:06 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
	s=mail; t=1548520389;
	bh=fGItqsHmpvreEQpZHix76CE5jCPyi5AvDPd4zEuZ+TI=;
	h=From:To:Subject:Date:From;
	b=KXfD4Q8Af/7BZc+6KkyFwqCoKQnZEzUxbCacz/HvhmDn7N/nIkwNv1EobUoUtArxJ
	+9hCwo1bLzz6jkTXDTR0rV97WozLB2CMjBYBhujskzJEE+1cOAhV6VlAp9mfoOtyJ9
	dlxMVOud0LrawIRxQU8AVB9XiwaFEzK7vaCoGDQs=
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: libcamera-devel@lists.libcamera.org
Date: Sat, 26 Jan 2019 18:32:57 +0200
Message-Id: <20190126163257.10417-1-laurent.pinchart@ideasonboard.com>
X-Mailer: git-send-email 2.19.2
MIME-Version: 1.0
Subject: [libcamera-devel] [PATCH] libcamera: signal: Don't use
	reinterpret_cast<>() to perform downcasts
X-BeenThere: libcamera-devel@lists.libcamera.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <libcamera-devel.lists.libcamera.org>
List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>,
	<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>
List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/>
List-Post: <mailto:libcamera-devel@lists.libcamera.org>
List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help>
List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>,
	<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jan 2019 16:33:10 -0000

Use static_cast<>() instead of reinterpret_cast<>() to perform
downcasts, as reinterpret_cast<>() isn't meant (and guaranteed to be
safe) for that purpose.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 include/libcamera/signal.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h
index 0b437a486c08..c375b0a878af 100644
--- a/include/libcamera/signal.h
+++ b/include/libcamera/signal.h
@@ -37,7 +37,7 @@ public:
 	SlotMember(T *obj, void(T::*func)(Args...))
 		: SlotBase<Args...>(obj), func_(func) { }
 
-	void invoke(Args... args) { (reinterpret_cast<T *>(this->obj_)->*func_)(args...); }
+	void invoke(Args... args) { (static_cast<T *>(this->obj_)->*func_)(args...); }
 
 private:
 	friend class Signal<Args...>;
@@ -111,7 +111,7 @@ public:
 			 * match, so we can safely cast to SlotMember<T, Args>.
 			 */
 			if (slot->obj_ == object &&
-			    reinterpret_cast<SlotMember<T, Args...> *>(slot)->func_ == func) {
+			    static_cast<SlotMember<T, Args...> *>(slot)->func_ == func) {
 				iter = slots_.erase(iter);
 				delete slot;
 			} else {
@@ -125,7 +125,7 @@ public:
 		for (auto iter = slots_.begin(); iter != slots_.end(); ) {
 			SlotBase<Args...> *slot = *iter;
 			if (slot->obj_ == nullptr &&
-			    reinterpret_cast<SlotStatic<Args...> *>(slot)->func_ == func) {
+			    static_cast<SlotStatic<Args...> *>(slot)->func_ == func) {
 				iter = slots_.erase(iter);
 				delete slot;
 			} else {