From patchwork Tue Oct 20 09:14:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10125 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 12CFBBDB1F for ; Tue, 20 Oct 2020 09:15:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 99F8061394; Tue, 20 Oct 2020 11:15:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="E8kvtlPb"; dkim-atps=neutral Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F16BC6052F for ; Tue, 20 Oct 2020 11:15:13 +0200 (CEST) Received: by mail-pg1-x52c.google.com with SMTP id x13so707221pgp.7 for ; Tue, 20 Oct 2020 02:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5PEcV1eiUI8e2za3YJ9sykYFk0EVhJhTiZjs/x7iafQ=; b=E8kvtlPbhv5+KY8N4klDLpk8jiqbRqW1Cpeje8+WLIl+GNcc/hO/B87h0MypKQ8lR7 aUsZHPVqBD6ZZrZTdjNfmgORj51sZnKCDBcJwPQB3icEm5rV+1Ejc4940e3Z3FmE47+r 9jP7wYgUp5sEbOfA8y7XfTGojBOEP7AEKzX3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5PEcV1eiUI8e2za3YJ9sykYFk0EVhJhTiZjs/x7iafQ=; b=U4XgtWygavVSubSqacF6nAF5XM098chvpm3mZ/1o4D1TmhEu6Wbv5fXndWwGUf2eGv Tlzq5gbnE9XxW32RGRenTvHmw46MUtOCb6UJQX9KS3DTSyWoCZLVb2wmriOVCnrov/Ex uSjSRk9i77TjzteDOOqfACv5XOzY/r+mx+uEQhsfP/OXDQqS8WGWe8yYf/6y5FPIH8qT zuo/LFukcL737rgQtRaMFGy4PVTAiDf/7QlmOYX157XnoanU3URyvVi/yoeknIOGSouo FFy200Bp2EkC90S7K4D3c2qFfK29Efct1xqzkE90TemPA+mfTNKsLiW4vDXczniYFz7a kEoQ== X-Gm-Message-State: AOAM531iMkYjQAHV1huTMTl9HPsOf3cGin7veQ6jWelEH6f3zgWzT5Gr 49W3JqvWSfWXxgvBB8pR4nlaSq7eG/tkfQ== X-Google-Smtp-Source: ABdhPJwrXVd50fyyAuOBZi29UsZTh6GjTsJV5a7Hh9Pax04fq4CuNGq7EsF+d3oFR+1Ht0fM/Clx8w== X-Received: by 2002:a63:3004:: with SMTP id w4mr1817814pgw.249.1603185312202; Tue, 20 Oct 2020 02:15:12 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:11 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:14:58 +0900 Message-Id: <20201020091505.138898-1-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/8] test: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" TEST_REGISTER macro is main function. The end semicolon with the macro is unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham --- test/camera/buffer_import.cpp | 2 +- test/camera/capture.cpp | 2 +- test/camera/configuration_default.cpp | 2 +- test/camera/configuration_set.cpp | 2 +- test/camera/statemachine.cpp | 2 +- test/mapped-buffer.cpp | 2 +- test/media_device/media_device_acquire.cpp | 2 +- test/media_device/media_device_link_test.cpp | 2 +- test/media_device/media_device_print_test.cpp | 2 +- test/v4l2_subdevice/list_formats.cpp | 2 +- test/v4l2_subdevice/test_formats.cpp | 2 +- test/v4l2_videodevice/buffer_cache.cpp | 2 +- test/v4l2_videodevice/buffer_sharing.cpp | 2 +- test/v4l2_videodevice/capture_async.cpp | 2 +- test/v4l2_videodevice/controls.cpp | 2 +- test/v4l2_videodevice/double_open.cpp | 2 +- test/v4l2_videodevice/formats.cpp | 2 +- test/v4l2_videodevice/request_buffers.cpp | 2 +- test/v4l2_videodevice/stream_on_off.cpp | 2 +- test/v4l2_videodevice/v4l2_m2mdevice.cpp | 4 ++-- 20 files changed, 21 insertions(+), 21 deletions(-) diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp index 72ce7b7..4b626df 100644 --- a/test/camera/buffer_import.cpp +++ b/test/camera/buffer_import.cpp @@ -168,4 +168,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferImportTest); +TEST_REGISTER(BufferImportTest) diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp index c077080..f13ca53 100644 --- a/test/camera/capture.cpp +++ b/test/camera/capture.cpp @@ -168,4 +168,4 @@ protected: } /* namespace */ -TEST_REGISTER(Capture); +TEST_REGISTER(Capture) diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp index cdd6cb9..c2b2019 100644 --- a/test/camera/configuration_default.cpp +++ b/test/camera/configuration_default.cpp @@ -56,4 +56,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationDefault); +TEST_REGISTER(ConfigurationDefault) diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp index 30f19ba..a1dc446 100644 --- a/test/camera/configuration_set.cpp +++ b/test/camera/configuration_set.cpp @@ -102,4 +102,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationSet); +TEST_REGISTER(ConfigurationSet) diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp index e63ab29..f0c3d77 100644 --- a/test/camera/statemachine.cpp +++ b/test/camera/statemachine.cpp @@ -211,4 +211,4 @@ protected: } /* namespace */ -TEST_REGISTER(Statemachine); +TEST_REGISTER(Statemachine) diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp index 0279233..5de8201 100644 --- a/test/mapped-buffer.cpp +++ b/test/mapped-buffer.cpp @@ -113,4 +113,4 @@ private: } /* namespace */ -TEST_REGISTER(MappedBufferTest); +TEST_REGISTER(MappedBufferTest) diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp index d1e3d74..371e30e 100644 --- a/test/media_device/media_device_acquire.cpp +++ b/test/media_device/media_device_acquire.cpp @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceAcquire); +TEST_REGISTER(MediaDeviceAcquire) diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp index fe7542b..5c74905 100644 --- a/test/media_device/media_device_link_test.cpp +++ b/test/media_device/media_device_link_test.cpp @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceLinkTest); +TEST_REGISTER(MediaDeviceLinkTest) diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp index 1f5e3f3..436d4e8 100644 --- a/test/media_device/media_device_print_test.cpp +++ b/test/media_device/media_device_print_test.cpp @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run() return ret; } -TEST_REGISTER(MediaDevicePrintTest); +TEST_REGISTER(MediaDevicePrintTest) diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp index a6044c0..74ec81a 100644 --- a/test/v4l2_subdevice/list_formats.cpp +++ b/test/v4l2_subdevice/list_formats.cpp @@ -79,4 +79,4 @@ int ListFormatsTest::run() return TestPass; } -TEST_REGISTER(ListFormatsTest); +TEST_REGISTER(ListFormatsTest) diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp index 679f50b..47f979e 100644 --- a/test/v4l2_subdevice/test_formats.cpp +++ b/test/v4l2_subdevice/test_formats.cpp @@ -75,4 +75,4 @@ int FormatHandlingTest::run() return TestPass; } -TEST_REGISTER(FormatHandlingTest); +TEST_REGISTER(FormatHandlingTest) diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp index b22de88..b3f2bec 100644 --- a/test/v4l2_videodevice/buffer_cache.cpp +++ b/test/v4l2_videodevice/buffer_cache.cpp @@ -213,4 +213,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferCacheTest); +TEST_REGISTER(BufferCacheTest) diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp index ba2cc40..5e7e2d9 100644 --- a/test/v4l2_videodevice/buffer_sharing.cpp +++ b/test/v4l2_videodevice/buffer_sharing.cpp @@ -200,4 +200,4 @@ private: unsigned int framesOutput_; }; -TEST_REGISTER(BufferSharingTest); +TEST_REGISTER(BufferSharingTest) diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp index 13cbcc8..2b38102 100644 --- a/test/v4l2_videodevice/capture_async.cpp +++ b/test/v4l2_videodevice/capture_async.cpp @@ -88,4 +88,4 @@ private: unsigned int frames; }; -TEST_REGISTER(CaptureAsyncTest); +TEST_REGISTER(CaptureAsyncTest) diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp index 9f09d03..8d42508 100644 --- a/test/v4l2_videodevice/controls.cpp +++ b/test/v4l2_videodevice/controls.cpp @@ -127,4 +127,4 @@ protected: } }; -TEST_REGISTER(V4L2ControlTest); +TEST_REGISTER(V4L2ControlTest) diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp index 5768d40..7d11f6f 100644 --- a/test/v4l2_videodevice/double_open.cpp +++ b/test/v4l2_videodevice/double_open.cpp @@ -38,4 +38,4 @@ protected: } /* namespace */ -TEST_REGISTER(DoubleOpen); +TEST_REGISTER(DoubleOpen) diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp index 043732d..b5020d2 100644 --- a/test/v4l2_videodevice/formats.cpp +++ b/test/v4l2_videodevice/formats.cpp @@ -74,4 +74,4 @@ protected: } }; -TEST_REGISTER(Format); +TEST_REGISTER(Format) diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp index 2f8dfe1..fb57714 100644 --- a/test/v4l2_videodevice/request_buffers.cpp +++ b/test/v4l2_videodevice/request_buffers.cpp @@ -26,4 +26,4 @@ protected: } }; -TEST_REGISTER(RequestBuffersTest); +TEST_REGISTER(RequestBuffersTest) diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp index ce48310..4ed99e9 100644 --- a/test/v4l2_videodevice/stream_on_off.cpp +++ b/test/v4l2_videodevice/stream_on_off.cpp @@ -33,4 +33,4 @@ protected: } }; -TEST_REGISTER(StreamOnStreamOffTest); +TEST_REGISTER(StreamOnStreamOffTest) diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp index 44a39d4..616261e 100644 --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp @@ -187,7 +187,7 @@ protected: void cleanup() { delete vim2m_; - }; + } private: std::unique_ptr enumerator_; @@ -201,4 +201,4 @@ private: unsigned int captureFrames_; }; -TEST_REGISTER(V4L2M2MDeviceTest); +TEST_REGISTER(V4L2M2MDeviceTest) From patchwork Tue Oct 20 09:14:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10126 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 37E83BDB1F for ; Tue, 20 Oct 2020 09:15:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 029CE610C4; Tue, 20 Oct 2020 11:15:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="kYqLJbhw"; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D2A36052F for ; Tue, 20 Oct 2020 11:15:16 +0200 (CEST) Received: by mail-pf1-x442.google.com with SMTP id 10so833307pfp.5 for ; Tue, 20 Oct 2020 02:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y8Is3A32fjh+CVX7gMxhWiFjjMSYUt4UBTXqCbxzLw8=; b=kYqLJbhwTsLK3CM6S1IFk7LA+rqrX1DVqV/TbdFb5zi4rZ3Phj9ANwyAjKY7p3Jess PFTzXRhc4BasmEAMwZCss/tqS4EguPHterQ7SusUgqaZFojrmxR5uU5ZASttykCzhdth 3UMzK0ITtr4Yq1oR/H7xU0250RbsTYfXfqnTc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y8Is3A32fjh+CVX7gMxhWiFjjMSYUt4UBTXqCbxzLw8=; b=IRV+zmozh7MoGfYSibxWHWE/3fyWD1DIO+1xY+cxVT6FSW/7N5Il+X6y8AVDTVx1ix Sl862f3Oswz3yVrnKKCrlmjWPq9F766e/tOO1CIuWPLsCH24nJt3qxBZ2TPKPop+s/s/ SIwDf5tbm3Ei40UFrM7gF4QuubfF/buOd+FYhAfs9wKTja6b1c3BnNjxD0B9MoDGqqX5 wzCesV6nmCEiSKeZAjG+TqJqn+gm/FfYyHSY9jM2T9djssK1kIbOyvPLozeIFbM4LCcw QtophLpzQm28yBwuiEGNIzYlfSwqDOuL79FjI37LwXa78f7L3fI71+8P7HlsnWNt6OkB c2mA== X-Gm-Message-State: AOAM5328iSd1K3Q/LFlm+Lhcpy5RGLhDCCqtQONkJuTXB1m2wVRsFO5f wPMHzLpBbm2DK48mYXfW1xpqeaQaFKfbJw== X-Google-Smtp-Source: ABdhPJxyQg0tPqqJWd0VaUIKedRQit4LZNz6xvjZh6YVNZkNde3zN++NV6YM7uVDb55fEw2ZaF8sRA== X-Received: by 2002:a63:5f53:: with SMTP id t80mr1907328pgb.62.1603185314035; Tue, 20 Oct 2020 02:15:14 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:13 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:14:59 +0900 Message-Id: <20201020091505.138898-2-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020091505.138898-1-hiroh@chromium.org> References: <20201020091505.138898-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 2/8] v4l2: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" LOG_DECLARE_CATEGORY macro contains the semicolon. The end semicolon with the macro is unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/v4l2/v4l2_camera.cpp | 2 +- src/v4l2/v4l2_camera_proxy.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp index 35d3bed..97825c7 100644 --- a/src/v4l2/v4l2_camera.cpp +++ b/src/v4l2/v4l2_camera.cpp @@ -14,7 +14,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(V4L2Compat); +LOG_DECLARE_CATEGORY(V4L2Compat) V4L2Camera::V4L2Camera(std::shared_ptr camera) : camera_(camera), isRunning_(false), bufferAllocator_(nullptr), diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 8ff990f..7803d37 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -32,7 +32,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(V4L2Compat); +LOG_DECLARE_CATEGORY(V4L2Compat) V4L2CameraProxy::V4L2CameraProxy(unsigned int index, std::shared_ptr camera) From patchwork Tue Oct 20 09:15:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10127 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8F78BBDB1F for ; Tue, 20 Oct 2020 09:15:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6059D613C2; Tue, 20 Oct 2020 11:15:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="H6c1swlr"; dkim-atps=neutral Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 66E8361373 for ; Tue, 20 Oct 2020 11:15:17 +0200 (CEST) Received: by mail-pf1-x443.google.com with SMTP id j18so846651pfa.0 for ; Tue, 20 Oct 2020 02:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eGTB6f569amkDZmVIRTDUmNO7biVX4a196hfyx/h1gI=; b=H6c1swlrVfs3wPFi8xa/5oSLDNBOX40chzC8TO4A1LD3sssm2sWpJjVWXt4gW9PDqA 00oSiCfV+JaViIPil0RTPT1i6t6ZzfRtvc0ocTFQRhS6dLMFxJqfYNpuio24zojoEOkr qqvDLruWjDZkQqOHiAqtGEt1niEtP43UN78Ic= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eGTB6f569amkDZmVIRTDUmNO7biVX4a196hfyx/h1gI=; b=N4Wgil9v3eoFDRp5c4WGua0NkA8P3S6x68wmb+qhd9rf11gD4pQ7UIak01s+Tqjjbj j0aOjv3yifOjJTrZwGTbGICWtHePFDzCtnHEHdm7nsAM6GH3yLHviQmAsLryx9Fy+HqS Gb61bPxwjyycRQOkltXpxpt57ZzoioNcKatrsDFxCpW8LFstOCpvhRDVTgW/J20618PC rMxeUsourEJfLsx4TK4dljMKdNxVks4ydldHWtU8fXg/5MEk33adqs3Ag6MUOGQg8ZMK eKX1wWLAFseMD4YONUuCtMNBKez295NkRGwowDhBBJOwfOvswF7TD/iL7LoZ8dlOh8gR sNkg== X-Gm-Message-State: AOAM530XW9OUB+2S+uTo/v5H8SmnsNV1qBtVNN7dXtaE7rcbCCdOcGh/ x1mjlKW1NH9YFrxhUAMirJaIZmlLJ/gSsg== X-Google-Smtp-Source: ABdhPJyRh/6qbgIb4kN1ifwAFtQFfu2+PsfcCsJQkypAZmiWkyz3nxbtZHqq/3Wa5Fa2vu8f/Njlkg== X-Received: by 2002:aa7:9823:0:b029:158:ee6b:e939 with SMTP id q3-20020aa798230000b0290158ee6be939mr1795776pfl.37.1603185315819; Tue, 20 Oct 2020 02:15:15 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:15 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:15:00 +0900 Message-Id: <20201020091505.138898-3-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020091505.138898-1-hiroh@chromium.org> References: <20201020091505.138898-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 3/8] gstreamer: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Macros used in gstreamer (e.g. G_DEFINE_TYPE) are functions. The end semicolons with the macros are unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/gstreamer/gstlibcamera.cpp | 2 +- src/gstreamer/gstlibcameraallocator.cpp | 2 +- src/gstreamer/gstlibcamerapad.cpp | 2 +- src/gstreamer/gstlibcamerapool.cpp | 2 +- src/gstreamer/gstlibcameraprovider.cpp | 6 +++--- src/gstreamer/gstlibcamerasrc.cpp | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gstreamer/gstlibcamera.cpp b/src/gstreamer/gstlibcamera.cpp index 81c7bb1..52388b5 100644 --- a/src/gstreamer/gstlibcamera.cpp +++ b/src/gstreamer/gstlibcamera.cpp @@ -24,4 +24,4 @@ plugin_init(GstPlugin *plugin) GST_PLUGIN_DEFINE(GST_VERSION_MAJOR, GST_VERSION_MINOR, libcamera, "libcamera capture plugin", - plugin_init, VERSION, "LGPL", PACKAGE, "https://libcamera.org"); + plugin_init, VERSION, "LGPL", PACKAGE, "https://libcamera.org") diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp index 78ded40..13c6b49 100644 --- a/src/gstreamer/gstlibcameraallocator.cpp +++ b/src/gstreamer/gstlibcameraallocator.cpp @@ -101,7 +101,7 @@ struct _GstLibcameraAllocator { }; G_DEFINE_TYPE(GstLibcameraAllocator, gst_libcamera_allocator, - GST_TYPE_DMABUF_ALLOCATOR); + GST_TYPE_DMABUF_ALLOCATOR) static gboolean gst_libcamera_allocator_release(GstMiniObject *mini_object) diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp index 9f3e2be..c00e81c 100644 --- a/src/gstreamer/gstlibcamerapad.cpp +++ b/src/gstreamer/gstlibcamerapad.cpp @@ -27,7 +27,7 @@ enum { PROP_STREAM_ROLE }; -G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD); +G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD) static void gst_libcamera_pad_set_property(GObject *object, guint prop_id, diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp index b756ee3..62db184 100644 --- a/src/gstreamer/gstlibcamerapool.cpp +++ b/src/gstreamer/gstlibcamerapool.cpp @@ -29,7 +29,7 @@ struct _GstLibcameraPool { Stream *stream; }; -G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL); +G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL) static GstFlowReturn gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer, diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp index cd850d8..ee44dc7 100644 --- a/src/gstreamer/gstlibcameraprovider.cpp +++ b/src/gstreamer/gstlibcameraprovider.cpp @@ -35,14 +35,14 @@ enum { #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type() G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device, - GST_LIBCAMERA, DEVICE, GstDevice); + GST_LIBCAMERA, DEVICE, GstDevice) struct _GstLibcameraDevice { GstDevice parent; gchar *name; }; -G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE); +G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE) static GstElement * gst_libcamera_device_create_element(GstDevice *device, const gchar *name) @@ -164,7 +164,7 @@ struct _GstLibcameraProvider { G_DEFINE_TYPE_WITH_CODE(GstLibcameraProvider, gst_libcamera_provider, GST_TYPE_DEVICE_PROVIDER, GST_DEBUG_CATEGORY_INIT(provider_debug, "libcamera-provider", 0, - "libcamera Device Provider")); + "libcamera Device Provider")) static GList * gst_libcamera_provider_probe(GstDeviceProvider *provider) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 5001083..a099508 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -140,7 +140,7 @@ enum { G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT, GST_DEBUG_CATEGORY_INIT(source_debug, "libcamerasrc", 0, - "libcamera Source")); + "libcamera Source")) #define TEMPLATE_CAPS GST_STATIC_CAPS("video/x-raw; image/jpeg") From patchwork Tue Oct 20 09:15:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10128 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 21206BDB1F for ; Tue, 20 Oct 2020 09:15:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DE782613CC; Tue, 20 Oct 2020 11:15:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="bmd8hI/6"; dkim-atps=neutral Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FD8C61394 for ; Tue, 20 Oct 2020 11:15:19 +0200 (CEST) Received: by mail-pf1-x42e.google.com with SMTP id y14so812417pfp.13 for ; Tue, 20 Oct 2020 02:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8pxfREl9eDmi/cM3ydqF58dxOJd5JJAZPW5HsxmdJ2o=; b=bmd8hI/63cq4uqEAdN8fFA15reCtXnvBzRUMZlCBZ6I6m6Yt8XYjbv+r9m0qV8TlhU 6g4+3BL2e822jLY5pg7hSKvmSzF+rq7vp6LAJ+vrv4uhKp25vg0wiUG61qilMlBUeBJ7 0ChU4672L+IeKlQzhbx/UoqIv1O+XlCkIhMqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8pxfREl9eDmi/cM3ydqF58dxOJd5JJAZPW5HsxmdJ2o=; b=hpuh9MKZ6zAc6gM8oyZJJHWvlUK9m47rL/p3cRNH2EjGQIWqNrsqn7bD9jRadXj/Oe 96QRNCqMG+9o9qvLZ3OV/9JlULBJ6dG96kBN7pFmtUtXjXBCy8J6fhzaOaimJKlDxuP8 3LRNbQmtcRvsq3viTnSryUP4RkgYQD/nYCIWD1V2hQb2/TDNNipFVk5LXHnpHbAyUySZ yPlkE8CDHMKK2x3y9PnsW/tQaWPXGhUa8OvQokAx2trxK/eLq0SZUjyEb1RDLqEg0COM n1msA5i+wqlg79+aebi10SXgglU3PZzsFJkW7ZS7d7nyo2YXpSRWF+VKa6+wamOtpsDE 8yeQ== X-Gm-Message-State: AOAM5330ylAHLZd/zguluL0ntjdLq8mScaPe8nTRXi+h5TSfHk4oCZ1M uVAtt0AU+pryMDKmpmEXu1EWsiXP9xdGHw== X-Google-Smtp-Source: ABdhPJzjx11h+Comoisu/WzYt5RtH0gYrWs3Hf+vpIxBIr1TjyshEnZkJJ/IMDOGVXx7Ns/c4vE4ww== X-Received: by 2002:aa7:91c8:0:b029:155:c7c1:3fae with SMTP id z8-20020aa791c80000b0290155c7c13faemr1873107pfa.74.1603185317691; Tue, 20 Oct 2020 02:15:17 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:17 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:15:01 +0900 Message-Id: <20201020091505.138898-4-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020091505.138898-1-hiroh@chromium.org> References: <20201020091505.138898-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 4/8] android: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The end semicolons with LOG_DECLARE_CATEGORY and LOG_DEFINE_CATEGORY are unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/android/camera_device.cpp | 2 +- src/android/camera_hal_manager.cpp | 2 +- src/android/camera_metadata.cpp | 2 +- src/android/camera_stream.cpp | 2 +- src/android/camera_worker.cpp | 2 +- src/android/jpeg/encoder.h | 2 +- src/android/jpeg/encoder_libjpeg.cpp | 2 +- src/android/jpeg/post_processor_jpeg.cpp | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index d706cf4..e9404c2 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -129,7 +129,7 @@ const std::map camera3FormatsMap = { } /* namespace */ -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer, int flags) diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp index 2a33f9b..189eda2 100644 --- a/src/android/camera_hal_manager.cpp +++ b/src/android/camera_hal_manager.cpp @@ -16,7 +16,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) /* * \class CameraHalManager diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp index f0da9ea..edea48f 100644 --- a/src/android/camera_metadata.cpp +++ b/src/android/camera_metadata.cpp @@ -11,7 +11,7 @@ using namespace libcamera; -LOG_DEFINE_CATEGORY(CameraMetadata); +LOG_DEFINE_CATEGORY(CameraMetadata) CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity) { diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp index 1b8afa8..eae451e 100644 --- a/src/android/camera_stream.cpp +++ b/src/android/camera_stream.cpp @@ -15,7 +15,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) /* * \class CameraStream diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp index ff09b75..df43646 100644 --- a/src/android/camera_worker.cpp +++ b/src/android/camera_worker.cpp @@ -15,7 +15,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) /* * \class CaptureRequest diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h index 4483153..4e85996 100644 --- a/src/android/jpeg/encoder.h +++ b/src/android/jpeg/encoder.h @@ -14,7 +14,7 @@ class Encoder { public: - virtual ~Encoder() {}; + virtual ~Encoder() {} virtual int configure(const libcamera::StreamConfiguration &cfg) = 0; virtual int encode(const libcamera::FrameBuffer *source, diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp index 8995ba5..f11e004 100644 --- a/src/android/jpeg/encoder_libjpeg.cpp +++ b/src/android/jpeg/encoder_libjpeg.cpp @@ -25,7 +25,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(JPEG); +LOG_DECLARE_CATEGORY(JPEG) namespace { diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp index 753c28e..9d452b7 100644 --- a/src/android/jpeg/post_processor_jpeg.cpp +++ b/src/android/jpeg/post_processor_jpeg.cpp @@ -18,7 +18,7 @@ using namespace libcamera; -LOG_DEFINE_CATEGORY(JPEG); +LOG_DEFINE_CATEGORY(JPEG) PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device) : cameraDevice_(device) From patchwork Tue Oct 20 09:15:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10129 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6F965BDB1F for ; Tue, 20 Oct 2020 09:15:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3C42461394; Tue, 20 Oct 2020 11:15:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mE2VYarc"; dkim-atps=neutral Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E0384613CD for ; Tue, 20 Oct 2020 11:15:20 +0200 (CEST) Received: by mail-pl1-x642.google.com with SMTP id d23so700960pll.7 for ; Tue, 20 Oct 2020 02:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J6HSQHVSouRHnz9ebEBR+Wsmje+/euMmVgCkqhtoMa4=; b=mE2VYarcZ6cGh8SaKbSu7oicLCmaj6q/ylUWdj6sL0BvqHLLsDg1eTuxWSS3XD9iBI Na34qoePm4QBkQXKk6r/eUlS2NvVIhMHnaG/AkN4qoM3fi8vqKDG1B0HsygWClzXEvAJ 8QvjseujyeoBbdkYc/WpUYVTJOAWohkkCFS4I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J6HSQHVSouRHnz9ebEBR+Wsmje+/euMmVgCkqhtoMa4=; b=k4YWGZKkTuRsLbsr4VnsvJUp1UVp75Nsluy4i52aaDnNHefQk/ho5tutX4ONo4pXTL 2V/2aDyKeAwif1fAuU2NbKswDXDdhxL8HL6jNLI+j36kn7h92QaUK5RBsNGpBJFZ3bvE HJw0LNESLIKv4yvtF5rwj6u34sm7/+Eb2W+PREog0KCErQiadQ4uh9pTETSGTl2Ccfzf XNL5HzZ1X5lfFbgqIEI6Tj6AnWy0lIbDLvnhU96eajow22JPiGslwj5BRx4dgcYIXD4t ZNQqPhBLJZiXN5ZfswKati5y7CKzfH0dnLJLvz8OGXdnmDbOCtbxeqznZo9LlZkUCKo6 zTvg== X-Gm-Message-State: AOAM5301jZIC9xXEveRmKhsvVLRF3yVL0Ybxvy+SSOobGEitKhh69nFk cG3ps4akEcDxiekJmIeyHp1AeevTMhl3xg== X-Google-Smtp-Source: ABdhPJzZrutZAj05Fe1e9TvVe90c10eyQXCJj2JnfUVQXdQsJ8EO+bzhXz3yBxR2ablLA/G/HY2+tg== X-Received: by 2002:a17:90a:e698:: with SMTP id s24mr1983609pjy.72.1603185319299; Tue, 20 Oct 2020 02:15:19 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:18 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:15:02 +0900 Message-Id: <20201020091505.138898-5-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020091505.138898-1-hiroh@chromium.org> References: <20201020091505.138898-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 5/8] include: libcamera: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This removes the unnecessary semicolon in span.h. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- include/libcamera/span.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/span.h b/include/libcamera/span.h index a53a80b..c0e4399 100644 --- a/include/libcamera/span.h +++ b/include/libcamera/span.h @@ -407,6 +407,6 @@ private: size_type size_; }; -}; /* namespace libcamera */ +} /* namespace libcamera */ #endif /* __LIBCAMERA_SPAN_H__ */ From patchwork Tue Oct 20 09:15:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10130 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E233BBDB1F for ; Tue, 20 Oct 2020 09:15:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9F1FD613BB; Tue, 20 Oct 2020 11:15:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="JSWZKxud"; dkim-atps=neutral Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A68E61373 for ; Tue, 20 Oct 2020 11:15:22 +0200 (CEST) Received: by mail-pl1-x62b.google.com with SMTP id h2so693506pll.11 for ; Tue, 20 Oct 2020 02:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=liyo/oDJijHOpl8icA2YflXE7zcQ+T55ARgEJEs61aw=; b=JSWZKxudeW1YSr+hmVwNnBe4He2z2M+Xg3MtRVBERg6zj85vjMEerjVwM+yWG0VYxS l0Z4iFXbC2MDr7zSpmX7yarUaOw8oozjrfKSZj7VgjW2UkCC6D0XCzfQdbdXSccqJzs6 Z1IZCX4ZcJmkCyQKuZekFXabVJzd8xZ508hQc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=liyo/oDJijHOpl8icA2YflXE7zcQ+T55ARgEJEs61aw=; b=PPsAEcka5wu/6tC9DYuTvp4VbBn+KuFwykCFrYfEN6JJwKhqKRwTHv7PciOt9cTJ4o aKr5URv84OeT/JcT6eDWeLzPFExt+8bVSCrYQ/h//l+8gUHwka9hydlaxm6nT0/1opn8 xFeiP5S1Q86baHdN58t2k4HUrBwVBfpZXFuLyOIcuHDNNPCZAXAku+mH8XlKHesNK760 l2AdFkrZ1XI4OYlw1qq/j8zuzY1vaMywku9AxZh+8isqfa4FiW+EXHbry986A64ps6pk ALP9X2HozNWHa7ib992fJ+2fCA1Ti49LuCNKEKqzv46x1U26KwB4VWRw8D7tH2sTOsyw VEiQ== X-Gm-Message-State: AOAM532AOoT2KzhsdbtlVvaohNsxpmr0v9IIv5aWLrmFI9WbfHuE7P8j GJNR11OQYuc3JcMlowaRhiVJWq29AjSWYw== X-Google-Smtp-Source: ABdhPJy2/iIGlAPoyALzFUE9+DOvOH1qAl+zampY39kSJrPxMOsMcwWGY4BX1C+h/XT+9obMlNoRUg== X-Received: by 2002:a17:90b:3114:: with SMTP id gc20mr1934092pjb.73.1603185320932; Tue, 20 Oct 2020 02:15:20 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:20 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:15:03 +0900 Message-Id: <20201020091505.138898-6-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020091505.138898-1-hiroh@chromium.org> References: <20201020091505.138898-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The end semicolons with LOG_DEFINE_CATEGORY, LOG_DECLARE_CATEGORY and REGISTER_PIPELINE_HANDLER are unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- Documentation/guides/pipeline-handler.rst | 4 ++-- src/libcamera/byte_stream_buffer.cpp | 2 +- src/libcamera/camera_sensor.cpp | 2 +- src/libcamera/file.cpp | 2 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++-- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +- src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- src/libcamera/pipeline/simple/converter.cpp | 2 +- src/libcamera/pipeline/simple/simple.cpp | 2 +- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 +- src/libcamera/pipeline/vimc/vimc.cpp | 2 +- src/libcamera/sysfs.cpp | 2 +- 13 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index 71ef205..d0370f1 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -258,7 +258,7 @@ methods for the overridden class members. return false; } - REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid); + REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid) } /* namespace libcamera */ @@ -1470,4 +1470,4 @@ application which will render the frames in a window for visual inspection: .. TODO: Running qcam with the vivid pipeline handler appears to have a bug and no visual frames are seen. However disabling zero-copy on qcam renders - them successfully. \ No newline at end of file + them successfully. diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp index df7029b..7db5501 100644 --- a/src/libcamera/byte_stream_buffer.cpp +++ b/src/libcamera/byte_stream_buffer.cpp @@ -14,7 +14,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(Serialization); +LOG_DEFINE_CATEGORY(Serialization) /** * \file byte_stream_buffer.h diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index 78c7cee..935de52 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -28,7 +28,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(CameraSensor); +LOG_DEFINE_CATEGORY(CameraSensor) /** * \struct CameraSensorInfo diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp index 04b0cb6..3a3f5bb 100644 --- a/src/libcamera/file.cpp +++ b/src/libcamera/file.cpp @@ -23,7 +23,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(File); +LOG_DEFINE_CATEGORY(File) /** * \class File diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index f5a20d3..af47739 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -66,7 +66,7 @@ public: Status validate() override; - const StreamConfiguration &cio2Format() const { return cio2Configuration_; }; + const StreamConfiguration &cio2Format() const { return cio2Configuration_; } const ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; } private: @@ -866,6 +866,6 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer) imgu_->input_->queueBuffer(buffer); } -REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3); +REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3) } /* namespace libcamera */ diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 26dbd25..331ada7 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1675,6 +1675,6 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t return nullptr; } -REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi); +REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi) } /* namespace libcamera */ diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp index 0572acc..62605c0 100644 --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp @@ -17,7 +17,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(RPI_S_W); +LOG_DEFINE_CATEGORY(RPI_S_W) namespace RPi { diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index aec590f..2352ab3 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -1184,6 +1184,6 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer) data->ipa_->processEvent(op); } -REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1); +REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1) } /* namespace libcamera */ diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp index 75fb297..b4ee021 100644 --- a/src/libcamera/pipeline/simple/converter.cpp +++ b/src/libcamera/pipeline/simple/converter.cpp @@ -21,7 +21,7 @@ namespace libcamera { -LOG_DECLARE_CATEGORY(SimplePipeline); +LOG_DECLARE_CATEGORY(SimplePipeline) SimpleConverter::SimpleConverter(MediaDevice *media) : m2m_(nullptr) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 7adb17e..8c00c0f 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -942,6 +942,6 @@ void SimplePipelineHandler::converterDone(FrameBuffer *input, data->video_->queueBuffer(input); } -REGISTER_PIPELINE_HANDLER(SimplePipelineHandler); +REGISTER_PIPELINE_HANDLER(SimplePipelineHandler) } /* namespace libcamera */ diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index 8ec0dac..a903a82 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -654,6 +654,6 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer) pipe_->completeRequest(camera_, request); } -REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC); +REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC) } /* namespace libcamera */ diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index fc8085f..7416c37 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -533,6 +533,6 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer) pipe_->completeRequest(camera_, request); } -REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc); +REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc) } /* namespace libcamera */ diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp index 6c8e955..3ebe66f 100644 --- a/src/libcamera/sysfs.cpp +++ b/src/libcamera/sysfs.cpp @@ -22,7 +22,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(SysFs); +LOG_DEFINE_CATEGORY(SysFs) namespace sysfs { From patchwork Tue Oct 20 09:15:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10131 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 45A14BDB1F for ; Tue, 20 Oct 2020 09:15:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0F592613CD; Tue, 20 Oct 2020 11:15:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="dpgEH6X0"; dkim-atps=neutral Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CCD561373 for ; Tue, 20 Oct 2020 11:15:24 +0200 (CEST) Received: by mail-pl1-x641.google.com with SMTP id 1so715147ple.2 for ; Tue, 20 Oct 2020 02:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uBcRhxoAf8ifK1qfBk+e0R7AIYM/ro7vengDNFujuX0=; b=dpgEH6X0GZ+1+SBUaWIl4oaPnoyOnyN9lopvUAfe/xW4rSziZTQe9D3L2Pq7AzrT+0 vBtfa25KO/zCI6bqe5RkNotSq59OVWCMyHRVJ9nkU5SCnIJb7/8e4gRlVq084ezF1b31 FPf63Uyba38Io/N2B0lZCYSAt3ER5wPD5tQ1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uBcRhxoAf8ifK1qfBk+e0R7AIYM/ro7vengDNFujuX0=; b=pwaHwq6wbiA9PS/AvNju3CjSMJq/ugf41E9IxrQXYvJdPF67K5bTg5ARBEQIU+QJ7v 4tjKv9l3JxJQndZEgMOmacXZ6nfLXKboOZmcBQVTJ4strthRvB/fYr/P73v2OCD/varU ilIzBeEDGaV9bxDFJ4TR3z0qwRG4zi+Z6/jpCw1TLWWXpPemQSXso7oDK3/LZ9I1mAhL xGPRfvQDo/OcY51mWUTbF1f2bWV7X6Nc70ZMPbp1Q38ntQq46FIlVzibq4sL2JmmlxK2 Db237HZ8q2H8ZsVI7hwYbeatuoqMaMNVNkRYlGvnsI0IcgGdhlRlUiiv20ihRTbccjBT 5cow== X-Gm-Message-State: AOAM533Ab/4sjF/fWgJfkoHLHUycZrZ3/ZtlXjRx9kP7TVIpskMXt4nz rp/TvkTlCH7M93nIFNTheEAb1UDES3iW4g== X-Google-Smtp-Source: ABdhPJz90UsE9Xj/2b86BDKuAEsBqz2Q9WLjtubsRoJo8koArPMDdB5FpHyRSS9yDiA9rNzSdWetsA== X-Received: by 2002:a17:90b:50a:: with SMTP id r10mr1947773pjz.231.1603185322695; Tue, 20 Oct 2020 02:15:22 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:22 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:15:04 +0900 Message-Id: <20201020091505.138898-7-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020091505.138898-1-hiroh@chromium.org> References: <20201020091505.138898-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 7/8] ipa: Omit extra semicolon X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" There is the unnecessary semicolon after ipaCreate() in raspberrypi.cpp. This removes it. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 48a72dd..1c255aa 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -1150,6 +1150,6 @@ struct ipa_context *ipaCreate() return new IPAInterfaceWrapper(std::make_unique()); } -}; /* extern "C" */ +} /* extern "C" */ } /* namespace libcamera */ From patchwork Tue Oct 20 09:15:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10132 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B07BABDB1F for ; Tue, 20 Oct 2020 09:15:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7CFD6613C8; Tue, 20 Oct 2020 11:15:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="PQSpLIuo"; dkim-atps=neutral Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 15BAA613CE for ; Tue, 20 Oct 2020 11:15:26 +0200 (CEST) Received: by mail-pl1-x644.google.com with SMTP id bf6so709486plb.4 for ; Tue, 20 Oct 2020 02:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BSz8WxMPNOTmo8uKKCU1g3GmePjncGr6xk9tnf94F5g=; b=PQSpLIuoXofo+7euHJZJyVdjPoKQFIY8OJ6vhCdUDK+fIp0q22MmnZSwxHpVTa8CRj 3IwHRZWe4STrn62xFQHnWvFyLODp8GwUGpjFMaEPQCArKa+39ZU7NdiSJe5R57p09wyq 04ZJA1mH9mPotdCDEQl7Iz5XwN93gNdqLjrWg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BSz8WxMPNOTmo8uKKCU1g3GmePjncGr6xk9tnf94F5g=; b=T2JC0StA82+Z4KwSGvt7E5W9hspq4tacDgTyeebyABQcnwfTUuIQVY59LWzR0CBRxJ NjQPAzBdkI8w56hkUhwIKoHjRbMBfLUm9fJfH09SaMv74/6ePxuDa/BaPG9REOkLCJzt ZdeuUhmLSJYMnb0oqdigubn5pS54o0dTE8xuSigWLDRmLee173zw26qQ802JxFXXmng0 yN3buNSNukMqrillfeiF27jrmPm9uN9fsaIssZC5eBjGzF9xXrDzerJB5fQE1outD9yx n5BBnx7Ej8SxSEl+9vy/FFIgRsN6vTqoatXODI/+Ai7yiuvXtqs9ViNzeiqzwDhzjsGm 2L3g== X-Gm-Message-State: AOAM532ZeaJcS0ollfGQo0+tmAgheos74k3PEgDFdhAiCp+LTvjO5nk+ iKpFwJGj4wJ1iOO0Pzf62ckIuwRi1xYvmQ== X-Google-Smtp-Source: ABdhPJzCPrg9N4STy7xHrqxAfGlwp83akmpeHVX0Epe+AeKky6XFCGkhEh7q2wg7B4x/H4w4EFsY1Q== X-Received: by 2002:a17:90a:d908:: with SMTP id c8mr1856469pjv.45.1603185324514; Tue, 20 Oct 2020 02:15:24 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id p8sm1482014pgs.34.2020.10.20.02.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 02:15:23 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 18:15:05 +0900 Message-Id: <20201020091505.138898-8-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020091505.138898-1-hiroh@chromium.org> References: <20201020091505.138898-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 8/8] meson: Enable -Wextra-semi for clang X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The option, -Wextra-semi, helps developers to find unnecessary semicolons. This option is available with clang. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- meson.build | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meson.build b/meson.build index de15cc1..b0c17d3 100644 --- a/meson.build +++ b/meson.build @@ -64,6 +64,10 @@ if cc.get_id() == 'clang' '-stdlib=libc++', ] endif + + cpp_arguments += [ + '-Wextra-semi', + ] endif if cc.get_id() == 'gcc'