From patchwork Tue Oct 20 05:28:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10113 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7BA18BDB13 for ; Tue, 20 Oct 2020 05:29:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 49576613BB; Tue, 20 Oct 2020 07:29:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="gxxNzWR8"; dkim-atps=neutral Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AE62060351 for ; Tue, 20 Oct 2020 07:29:16 +0200 (CEST) Received: by mail-pj1-x102c.google.com with SMTP id a1so377173pjd.1 for ; Mon, 19 Oct 2020 22:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V1iPvU62x7joRZHxcSELTFL+1tHF05cp2u/aNWvRiGg=; b=gxxNzWR8DEdsOXz/WNqi+Wf0hJj4qPqZoKdxL70/QVWFuISyeEuASGi+CD/O9YjmPf P6MHtq1Va3EEillv2dnw80pu2PDZ52j+bIgM9eDzu2GDZKoDTngKYTg5caKAMWTp8y6D m7NJe4/QhqxwcZh8Au9mQBTk1+YrDljKuvQe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V1iPvU62x7joRZHxcSELTFL+1tHF05cp2u/aNWvRiGg=; b=lB/5VjIE/a+5gYB7fAo/pvuMjx0PI7lxQe2/E6hTfpWXCcwtfOeuF28xDOBtbrrQTS SlZrcD74USuif3bZtjWCimbz49AJF/eq1fz3F9c3hJrxuGXPpFR8RkjZjRbJkMbkB8/y D4cZUnvmAIvYfGeQN9XUaTKtQ12ZeIYhfBW2Nor/TnedRea6oPDy0Al1TUJ1QhCzw5ae OfTh/ZS/OkJjLFAcPNeU71EcpQVZ7U0I+brgIvFRl2Jx9Na/oTw8GRVMWTyg0f074Imw lOtFGBva4iz0QWaCGcT3NjsGT3KOPlHFFVEvtjZIdjG/UxiRRz/oRA+2t2FV+fGRk1wh ltlw== X-Gm-Message-State: AOAM532S7Tf0ym6xUYnhATtpZtXaQQamsJSklXF4X7Y7PZPy9JpMdO7c vKgLgTeogxCYIq4n1PzqXz/L9SsTRn1BBg== X-Google-Smtp-Source: ABdhPJzeO1L+PUM16frgaNI8Q5jmWHEjtIVDpHxubt5EUGf8rjA7kDgMXDL1FT/VTYaibjrCeJ137Q== X-Received: by 2002:a17:902:524:b029:d2:6379:a975 with SMTP id 33-20020a1709020524b02900d26379a975mr1336807plf.61.1603171754635; Mon, 19 Oct 2020 22:29:14 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:14 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:28:58 +0900 Message-Id: <20201020052905.89267-2-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/8] test: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" TEST_REGISTER macro is main function. The end semicolon with the macro is unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- test/camera/buffer_import.cpp | 2 +- test/camera/capture.cpp | 2 +- test/camera/configuration_default.cpp | 2 +- test/camera/configuration_set.cpp | 2 +- test/camera/statemachine.cpp | 2 +- test/mapped-buffer.cpp | 2 +- test/media_device/media_device_acquire.cpp | 2 +- test/media_device/media_device_link_test.cpp | 2 +- test/media_device/media_device_print_test.cpp | 2 +- test/v4l2_subdevice/list_formats.cpp | 2 +- test/v4l2_subdevice/test_formats.cpp | 2 +- test/v4l2_videodevice/buffer_cache.cpp | 2 +- test/v4l2_videodevice/buffer_sharing.cpp | 2 +- test/v4l2_videodevice/capture_async.cpp | 2 +- test/v4l2_videodevice/controls.cpp | 2 +- test/v4l2_videodevice/double_open.cpp | 2 +- test/v4l2_videodevice/formats.cpp | 2 +- test/v4l2_videodevice/request_buffers.cpp | 2 +- test/v4l2_videodevice/stream_on_off.cpp | 2 +- test/v4l2_videodevice/v4l2_m2mdevice.cpp | 4 ++-- 20 files changed, 21 insertions(+), 21 deletions(-) diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp index 72ce7b7..4b626df 100644 --- a/test/camera/buffer_import.cpp +++ b/test/camera/buffer_import.cpp @@ -168,4 +168,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferImportTest); +TEST_REGISTER(BufferImportTest) diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp index c077080..f13ca53 100644 --- a/test/camera/capture.cpp +++ b/test/camera/capture.cpp @@ -168,4 +168,4 @@ protected: } /* namespace */ -TEST_REGISTER(Capture); +TEST_REGISTER(Capture) diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp index cdd6cb9..c2b2019 100644 --- a/test/camera/configuration_default.cpp +++ b/test/camera/configuration_default.cpp @@ -56,4 +56,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationDefault); +TEST_REGISTER(ConfigurationDefault) diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp index 30f19ba..a1dc446 100644 --- a/test/camera/configuration_set.cpp +++ b/test/camera/configuration_set.cpp @@ -102,4 +102,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationSet); +TEST_REGISTER(ConfigurationSet) diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp index e63ab29..f0c3d77 100644 --- a/test/camera/statemachine.cpp +++ b/test/camera/statemachine.cpp @@ -211,4 +211,4 @@ protected: } /* namespace */ -TEST_REGISTER(Statemachine); +TEST_REGISTER(Statemachine) diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp index 0279233..5de8201 100644 --- a/test/mapped-buffer.cpp +++ b/test/mapped-buffer.cpp @@ -113,4 +113,4 @@ private: } /* namespace */ -TEST_REGISTER(MappedBufferTest); +TEST_REGISTER(MappedBufferTest) diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp index d1e3d74..371e30e 100644 --- a/test/media_device/media_device_acquire.cpp +++ b/test/media_device/media_device_acquire.cpp @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceAcquire); +TEST_REGISTER(MediaDeviceAcquire) diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp index fe7542b..5c74905 100644 --- a/test/media_device/media_device_link_test.cpp +++ b/test/media_device/media_device_link_test.cpp @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceLinkTest); +TEST_REGISTER(MediaDeviceLinkTest) diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp index 1f5e3f3..436d4e8 100644 --- a/test/media_device/media_device_print_test.cpp +++ b/test/media_device/media_device_print_test.cpp @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run() return ret; } -TEST_REGISTER(MediaDevicePrintTest); +TEST_REGISTER(MediaDevicePrintTest) diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp index a6044c0..74ec81a 100644 --- a/test/v4l2_subdevice/list_formats.cpp +++ b/test/v4l2_subdevice/list_formats.cpp @@ -79,4 +79,4 @@ int ListFormatsTest::run() return TestPass; } -TEST_REGISTER(ListFormatsTest); +TEST_REGISTER(ListFormatsTest) diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp index 679f50b..47f979e 100644 --- a/test/v4l2_subdevice/test_formats.cpp +++ b/test/v4l2_subdevice/test_formats.cpp @@ -75,4 +75,4 @@ int FormatHandlingTest::run() return TestPass; } -TEST_REGISTER(FormatHandlingTest); +TEST_REGISTER(FormatHandlingTest) diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp index b22de88..b3f2bec 100644 --- a/test/v4l2_videodevice/buffer_cache.cpp +++ b/test/v4l2_videodevice/buffer_cache.cpp @@ -213,4 +213,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferCacheTest); +TEST_REGISTER(BufferCacheTest) diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp index ba2cc40..5e7e2d9 100644 --- a/test/v4l2_videodevice/buffer_sharing.cpp +++ b/test/v4l2_videodevice/buffer_sharing.cpp @@ -200,4 +200,4 @@ private: unsigned int framesOutput_; }; -TEST_REGISTER(BufferSharingTest); +TEST_REGISTER(BufferSharingTest) diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp index 13cbcc8..2b38102 100644 --- a/test/v4l2_videodevice/capture_async.cpp +++ b/test/v4l2_videodevice/capture_async.cpp @@ -88,4 +88,4 @@ private: unsigned int frames; }; -TEST_REGISTER(CaptureAsyncTest); +TEST_REGISTER(CaptureAsyncTest) diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp index 9f09d03..8d42508 100644 --- a/test/v4l2_videodevice/controls.cpp +++ b/test/v4l2_videodevice/controls.cpp @@ -127,4 +127,4 @@ protected: } }; -TEST_REGISTER(V4L2ControlTest); +TEST_REGISTER(V4L2ControlTest) diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp index 5768d40..7d11f6f 100644 --- a/test/v4l2_videodevice/double_open.cpp +++ b/test/v4l2_videodevice/double_open.cpp @@ -38,4 +38,4 @@ protected: } /* namespace */ -TEST_REGISTER(DoubleOpen); +TEST_REGISTER(DoubleOpen) diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp index 043732d..b5020d2 100644 --- a/test/v4l2_videodevice/formats.cpp +++ b/test/v4l2_videodevice/formats.cpp @@ -74,4 +74,4 @@ protected: } }; -TEST_REGISTER(Format); +TEST_REGISTER(Format) diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp index 2f8dfe1..fb57714 100644 --- a/test/v4l2_videodevice/request_buffers.cpp +++ b/test/v4l2_videodevice/request_buffers.cpp @@ -26,4 +26,4 @@ protected: } }; -TEST_REGISTER(RequestBuffersTest); +TEST_REGISTER(RequestBuffersTest) diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp index ce48310..4ed99e9 100644 --- a/test/v4l2_videodevice/stream_on_off.cpp +++ b/test/v4l2_videodevice/stream_on_off.cpp @@ -33,4 +33,4 @@ protected: } }; -TEST_REGISTER(StreamOnStreamOffTest); +TEST_REGISTER(StreamOnStreamOffTest) diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp index 44a39d4..616261e 100644 --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp @@ -187,7 +187,7 @@ protected: void cleanup() { delete vim2m_; - }; + } private: std::unique_ptr enumerator_; @@ -201,4 +201,4 @@ private: unsigned int captureFrames_; }; -TEST_REGISTER(V4L2M2MDeviceTest); +TEST_REGISTER(V4L2M2MDeviceTest) From patchwork Tue Oct 20 05:28:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10114 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E7C23BDB13 for ; Tue, 20 Oct 2020 05:29:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B4E856052F; Tue, 20 Oct 2020 07:29:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jtL33FWF"; dkim-atps=neutral Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 90E88613C2 for ; Tue, 20 Oct 2020 07:29:18 +0200 (CEST) Received: by mail-pf1-x444.google.com with SMTP id w21so514324pfc.7 for ; Mon, 19 Oct 2020 22:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PzH7cQDn+Pcs0mkUbcwhOx4a/+aAn0/6pkWfRiIf6Ro=; b=jtL33FWFYSKNKQEpwgoQ3zAhCBu8lxmifvf7GDzjPcWt7SQNoh+RDStRVpAPPp3KeH aYW4Jf8RVYBXGs/xh6ZJl2R+pc6smv+isPfWGZq5MRwyzYGR+bBlICEbc5MrMWDlT5MB Alt4mbySsIbwOJkBRZGpA4L+xwDZxWYaTQ+LE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PzH7cQDn+Pcs0mkUbcwhOx4a/+aAn0/6pkWfRiIf6Ro=; b=i43al3T1WZe+/t+7SYDtMTTvlHuxGhQUEo43Pxuf9SMKsN/mdodVOK2W3DotpbBZYo HVFPsTXlfqOCI1FTid3Ua69Kagvp1V5F4vv7wAz5w6u5Za1e1la6ZWsCBkCe3+QfPdiz RKzqNKhXOdqlac26kifsoJnmLsbCewF19GQUC8JfZe5hmoN98Jyi4zHlZCUnBi00zIwz Rikeom7YiduZ18vuHC8CMmcJEckKmGjQ0/vGTJlD7NlVL/h89EuFOTOfP6ag0nAeyNvZ oNzTFDuuDy6pWgGUbMZ5kNKOK3vULVshG5Pjc4HFS1BJ9lXoTlwb+Pvq+VijJNLGiysQ CQ8w== X-Gm-Message-State: AOAM531Zu1E+eeUVQqRB41MUbp7TFnfWJq44ySv6M5iuDLwx/jsGav2l /ga0pOBp2ovEHAtF9dkKg2u9cYUY+5hH3Q== X-Google-Smtp-Source: ABdhPJxISGWn3ccFBJ0wFTt36pXEujK0yiLph+DqIX/IO1hXlmP34lDaIG3OBnVLFaaVi3GVJqIHRg== X-Received: by 2002:a63:7d44:: with SMTP id m4mr1288436pgn.223.1603171757025; Mon, 19 Oct 2020 22:29:17 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:16 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:28:59 +0900 Message-Id: <20201020052905.89267-3-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/8] v4l2: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" LOG_DECLARE_CATEGORY macro contains the semicolon. The end semicolon with the macro is unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/v4l2/v4l2_camera.cpp | 2 +- src/v4l2/v4l2_camera_proxy.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp index 35d3bed..97825c7 100644 --- a/src/v4l2/v4l2_camera.cpp +++ b/src/v4l2/v4l2_camera.cpp @@ -14,7 +14,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(V4L2Compat); +LOG_DECLARE_CATEGORY(V4L2Compat) V4L2Camera::V4L2Camera(std::shared_ptr camera) : camera_(camera), isRunning_(false), bufferAllocator_(nullptr), diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 8ff990f..7803d37 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -32,7 +32,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(V4L2Compat); +LOG_DECLARE_CATEGORY(V4L2Compat) V4L2CameraProxy::V4L2CameraProxy(unsigned int index, std::shared_ptr camera) From patchwork Tue Oct 20 05:29:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10115 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4F4FDBDB13 for ; Tue, 20 Oct 2020 05:29:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 15A30613C2; Tue, 20 Oct 2020 07:29:22 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="keOmQSX6"; dkim-atps=neutral Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 067B6610C4 for ; Tue, 20 Oct 2020 07:29:21 +0200 (CEST) Received: by mail-pj1-x1043.google.com with SMTP id gm14so333232pjb.2 for ; Mon, 19 Oct 2020 22:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F0hBzpfFTq9B1iOi2sSv4UEXrd/PquHYtGw2Pwrw3M4=; b=keOmQSX6tBUZw7wuxtbgegChtHuKTbOUUsHZffnVkNgE63uj8ppVLBu6cx/2z53HII 3uFavEwB017HrjueHj1dgQCowBxglz1jlCkmGhQR48cJ5aR3DWkdXiwETMzJFFH07hdP I7PH+xV6qqCaXVV7MClyYjbToSCuAOOnRRAGE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F0hBzpfFTq9B1iOi2sSv4UEXrd/PquHYtGw2Pwrw3M4=; b=cLkNWkBeDbR1XaHBA5jyR3+9JHk7vDREEgrTN3iNZmSVy/0SFNFuLM0UhOj5u+5tgj oLvohnmKLlxvqAV9lG0y0gNDpJvl/cHYrpfWPkD0i6emIv5i4pKUan0MyW1/VpQlCKbK O2TeL+jwXaA747s/B0FK3JxcX1BhvLlTgTiIccy3ZZsH+YkwvehHgG3ry/pCa+ixDOvc f5Z0qhwiXQ3t0XeVH7O7hjwSLJ9z2bXCL0eXPalu9GNOZl2JGH7YbJRAgAz/Y5T23uz4 73ppXs8yGL5LgBPHaWWlxjzbjo6KvV2w143AH8R+Kk2+8+rd0ozDKMds2KFJ5/D1Mqwv gLKQ== X-Gm-Message-State: AOAM533ECRTcFhJ5Hcx3Iy3HWWiNjMZ/O+UyI6DRRC5Ckl+8SQdFz0WB zzxlXXY5G+hwNaxdnqQoGCCQ9B5OXn/U+A== X-Google-Smtp-Source: ABdhPJzEDoX3u0zW0bgzujJeE16Kv4pNwBvJpRAo/NnkpX3RDP+ikHob5oszfxub/bJ1184KPDaS9w== X-Received: by 2002:a17:902:6508:b029:d3:b362:72b5 with SMTP id b8-20020a1709026508b02900d3b36272b5mr1250452plk.55.1603171759455; Mon, 19 Oct 2020 22:29:19 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:18 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:29:00 +0900 Message-Id: <20201020052905.89267-4-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/8] gstreamer: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Macros used in gstreamer (e.g. G_DEFINE_TYPE) is a function. The end semicolons with the macros are unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/gstreamer/gstlibcamera.cpp | 2 +- src/gstreamer/gstlibcameraallocator.cpp | 2 +- src/gstreamer/gstlibcamerapad.cpp | 2 +- src/gstreamer/gstlibcamerapool.cpp | 2 +- src/gstreamer/gstlibcameraprovider.cpp | 6 +++--- src/gstreamer/gstlibcamerasrc.cpp | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gstreamer/gstlibcamera.cpp b/src/gstreamer/gstlibcamera.cpp index 81c7bb1..52388b5 100644 --- a/src/gstreamer/gstlibcamera.cpp +++ b/src/gstreamer/gstlibcamera.cpp @@ -24,4 +24,4 @@ plugin_init(GstPlugin *plugin) GST_PLUGIN_DEFINE(GST_VERSION_MAJOR, GST_VERSION_MINOR, libcamera, "libcamera capture plugin", - plugin_init, VERSION, "LGPL", PACKAGE, "https://libcamera.org"); + plugin_init, VERSION, "LGPL", PACKAGE, "https://libcamera.org") diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp index 78ded40..13c6b49 100644 --- a/src/gstreamer/gstlibcameraallocator.cpp +++ b/src/gstreamer/gstlibcameraallocator.cpp @@ -101,7 +101,7 @@ struct _GstLibcameraAllocator { }; G_DEFINE_TYPE(GstLibcameraAllocator, gst_libcamera_allocator, - GST_TYPE_DMABUF_ALLOCATOR); + GST_TYPE_DMABUF_ALLOCATOR) static gboolean gst_libcamera_allocator_release(GstMiniObject *mini_object) diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp index 9f3e2be..c00e81c 100644 --- a/src/gstreamer/gstlibcamerapad.cpp +++ b/src/gstreamer/gstlibcamerapad.cpp @@ -27,7 +27,7 @@ enum { PROP_STREAM_ROLE }; -G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD); +G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD) static void gst_libcamera_pad_set_property(GObject *object, guint prop_id, diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp index b756ee3..62db184 100644 --- a/src/gstreamer/gstlibcamerapool.cpp +++ b/src/gstreamer/gstlibcamerapool.cpp @@ -29,7 +29,7 @@ struct _GstLibcameraPool { Stream *stream; }; -G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL); +G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL) static GstFlowReturn gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer, diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp index cd850d8..ee44dc7 100644 --- a/src/gstreamer/gstlibcameraprovider.cpp +++ b/src/gstreamer/gstlibcameraprovider.cpp @@ -35,14 +35,14 @@ enum { #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type() G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device, - GST_LIBCAMERA, DEVICE, GstDevice); + GST_LIBCAMERA, DEVICE, GstDevice) struct _GstLibcameraDevice { GstDevice parent; gchar *name; }; -G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE); +G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE) static GstElement * gst_libcamera_device_create_element(GstDevice *device, const gchar *name) @@ -164,7 +164,7 @@ struct _GstLibcameraProvider { G_DEFINE_TYPE_WITH_CODE(GstLibcameraProvider, gst_libcamera_provider, GST_TYPE_DEVICE_PROVIDER, GST_DEBUG_CATEGORY_INIT(provider_debug, "libcamera-provider", 0, - "libcamera Device Provider")); + "libcamera Device Provider")) static GList * gst_libcamera_provider_probe(GstDeviceProvider *provider) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 5001083..a099508 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -140,7 +140,7 @@ enum { G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT, GST_DEBUG_CATEGORY_INIT(source_debug, "libcamerasrc", 0, - "libcamera Source")); + "libcamera Source")) #define TEMPLATE_CAPS GST_STATIC_CAPS("video/x-raw; image/jpeg") From patchwork Tue Oct 20 05:29:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10116 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AD14ABDB13 for ; Tue, 20 Oct 2020 05:29:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 77E306052F; Tue, 20 Oct 2020 07:29:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="aoo/RTFP"; dkim-atps=neutral Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 36EEE60351 for ; Tue, 20 Oct 2020 07:29:23 +0200 (CEST) Received: by mail-pl1-x62c.google.com with SMTP id h2so396482pll.11 for ; Mon, 19 Oct 2020 22:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DahGBmqF9ZibJSYRWi32xAezOhzN/k4+lLgqqvwqQwc=; b=aoo/RTFPyrRekVFxwxZruNDnEf6MMox0u3w3bG/jl1X/i+5yknXbko61AzdTtI5sXI JAEf/HSR3F4ZmtqXV7JYzbDdBCoeU6AmW4thYWg0D8sQo69dpjX/OudfiHx3m674IIdC fluDcZ/U2uXCIj+ZlJ9TBBa3bA8DAB1K/Wzi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DahGBmqF9ZibJSYRWi32xAezOhzN/k4+lLgqqvwqQwc=; b=E7hWlCynZsQgeYYX0ebhVt1TEbrIZpqy69nTsFHZfa3svtjTeZs/SC5t9Y5oyryU/J vPdt1EWvcNJj4WDOPReeQN4EJIYS0ivcbXzWdkWH/o8DYXwC0u2+Ye3iwOjHgJalxpf9 pdcIyoLndMTEBljgrprv585t1Dy7zwzB0iitzadH8+RQ3vhXHj3CfegKZVHYoK2mFVwf sUtUU6NlQxjiHaQ9pZXue5aCNw8LoEb52V6I5jwl+gfHixEQYdPoCKcJygf2Tua1KOxo w/2PlciVOSq2hhUgTXb/MzQjtp7tEPljVHVL0lum7ViLbOh/7zvZ111KMFaPe6Oidad+ AblA== X-Gm-Message-State: AOAM533x7Lanz2SLEbrjmDn0ym3sG3vr+aCXdIFBQvdJKf1ryztwYXJ8 pATLVUPySoCDdO55mrgBlhbw6o0D4ux9YQ== X-Google-Smtp-Source: ABdhPJwQSdYSFIJ8xDknYxjx6uNRca+mSmksCdmvOcikyWZzkaWVlcOvFBVA6+wM2FK3rjIVre8QSg== X-Received: by 2002:a17:90a:d345:: with SMTP id i5mr1294119pjx.150.1603171761646; Mon, 19 Oct 2020 22:29:21 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:21 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:29:01 +0900 Message-Id: <20201020052905.89267-5-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/8] android: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The end semicolons with LOG_DECLARE_CATEGORY and LOG_DEFINE_CATEGORY are unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/android/camera_device.cpp | 2 +- src/android/camera_hal_manager.cpp | 2 +- src/android/camera_metadata.cpp | 2 +- src/android/camera_stream.cpp | 2 +- src/android/camera_worker.cpp | 2 +- src/android/jpeg/encoder.h | 2 +- src/android/jpeg/encoder_libjpeg.cpp | 2 +- src/android/jpeg/post_processor_jpeg.cpp | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index d706cf4..e9404c2 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -129,7 +129,7 @@ const std::map camera3FormatsMap = { } /* namespace */ -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer, int flags) diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp index 2a33f9b..189eda2 100644 --- a/src/android/camera_hal_manager.cpp +++ b/src/android/camera_hal_manager.cpp @@ -16,7 +16,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) /* * \class CameraHalManager diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp index f0da9ea..edea48f 100644 --- a/src/android/camera_metadata.cpp +++ b/src/android/camera_metadata.cpp @@ -11,7 +11,7 @@ using namespace libcamera; -LOG_DEFINE_CATEGORY(CameraMetadata); +LOG_DEFINE_CATEGORY(CameraMetadata) CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity) { diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp index 1b8afa8..eae451e 100644 --- a/src/android/camera_stream.cpp +++ b/src/android/camera_stream.cpp @@ -15,7 +15,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) /* * \class CameraStream diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp index ff09b75..df43646 100644 --- a/src/android/camera_worker.cpp +++ b/src/android/camera_worker.cpp @@ -15,7 +15,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(HAL); +LOG_DECLARE_CATEGORY(HAL) /* * \class CaptureRequest diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h index 4483153..4e85996 100644 --- a/src/android/jpeg/encoder.h +++ b/src/android/jpeg/encoder.h @@ -14,7 +14,7 @@ class Encoder { public: - virtual ~Encoder() {}; + virtual ~Encoder() {} virtual int configure(const libcamera::StreamConfiguration &cfg) = 0; virtual int encode(const libcamera::FrameBuffer *source, diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp index 8995ba5..f11e004 100644 --- a/src/android/jpeg/encoder_libjpeg.cpp +++ b/src/android/jpeg/encoder_libjpeg.cpp @@ -25,7 +25,7 @@ using namespace libcamera; -LOG_DECLARE_CATEGORY(JPEG); +LOG_DECLARE_CATEGORY(JPEG) namespace { diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp index 753c28e..9d452b7 100644 --- a/src/android/jpeg/post_processor_jpeg.cpp +++ b/src/android/jpeg/post_processor_jpeg.cpp @@ -18,7 +18,7 @@ using namespace libcamera; -LOG_DEFINE_CATEGORY(JPEG); +LOG_DEFINE_CATEGORY(JPEG) PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device) : cameraDevice_(device) From patchwork Tue Oct 20 05:29:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10117 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0E95ABDB13 for ; Tue, 20 Oct 2020 05:29:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CEB15613B7; Tue, 20 Oct 2020 07:29:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Ous87qis"; dkim-atps=neutral Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A32E60351 for ; Tue, 20 Oct 2020 07:29:25 +0200 (CEST) Received: by mail-pl1-x643.google.com with SMTP id 1so418009ple.2 for ; Mon, 19 Oct 2020 22:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rLJu1kSuY0/Xzy4HAc5K+DxVi4rKB5koCUImmo2buyc=; b=Ous87qis0O5ztRA0lyVc+6wm8v7hU8nr/GJBsbd+Sn8dmsZUNNqF5iGdLBaC37CVLD Jace/UF/vQY0v6tqibc41l12ppcO0UkZrUqeKM/Ii+pHabXdwVX0OozioCGjI0DJtG72 HJlj9yJihhqkdPseegeW/64naGQsjQg2uC33s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rLJu1kSuY0/Xzy4HAc5K+DxVi4rKB5koCUImmo2buyc=; b=oqMXalmG+7s3YDBBIuZUQRzTxLOhOZAM80V87+NWhsnQkV4CP1gRzInVSDMJr7ldkg MxCrxAT3Bw1i+m9ML4VeEAxpPHk7aFh/wLO6ZnTIc3ycAGO/ahA3ENHTdjL+05uG1jzz j7+Y0tsDNyTKmcU+dk3wwcdyj6Fygi1CT6VbDOwC2N+0Tn5aZqtEn5bN7cWDUIvU0Ntf T09g123lq6HJtoZ5MDbH1/AHhiA+wQaC5Os/R0I25nsv+xVVc01D9B4RZo8P+70V+pDI bslc8rR335x1hTRxgfwNasjwIbFrO+3xKBYFLCDeXWzbpr6T06t3K6zjFcWBbCpYlQcN dcVg== X-Gm-Message-State: AOAM530Jl8YruOMA22B2OjScptxIH1GOWTOfR2GMLobBYzJlowTwXbnO dbpLYkLBluShuaT439i/y7WZSbHayVjSJA== X-Google-Smtp-Source: ABdhPJyBXgxMqE5xGuE3Du90q0aordVtUtGcChPrVoaKkt2DybJK+HqcOoUgmItLihIYW7YhozxNww== X-Received: by 2002:a17:90a:9f90:: with SMTP id o16mr1363720pjp.180.1603171763742; Mon, 19 Oct 2020 22:29:23 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:23 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:29:02 +0900 Message-Id: <20201020052905.89267-6-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/8] include: libcamera: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" REGISTER_PIPELINE_HANDLER macro is used with the end semicolon everywhere. This removes the end semicolon within the macro. Signed-off-by: Hirokazu Honda --- include/libcamera/internal/pipeline_handler.h | 2 +- include/libcamera/span.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h index a4e1b52..818a36a 100644 --- a/include/libcamera/internal/pipeline_handler.h +++ b/include/libcamera/internal/pipeline_handler.h @@ -145,7 +145,7 @@ private: \ return new handler(manager); \ } \ }; \ -static handler##Factory global_##handler##Factory; +static handler##Factory global_##handler##Factory } /* namespace libcamera */ diff --git a/include/libcamera/span.h b/include/libcamera/span.h index a53a80b..c0e4399 100644 --- a/include/libcamera/span.h +++ b/include/libcamera/span.h @@ -407,6 +407,6 @@ private: size_type size_; }; -}; /* namespace libcamera */ +} /* namespace libcamera */ #endif /* __LIBCAMERA_SPAN_H__ */ From patchwork Tue Oct 20 05:29:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10118 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A2CCABDB13 for ; Tue, 20 Oct 2020 05:29:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 70269613B9; Tue, 20 Oct 2020 07:29:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="i1lC52PO"; dkim-atps=neutral Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 46BB461394 for ; Tue, 20 Oct 2020 07:29:27 +0200 (CEST) Received: by mail-pj1-x1043.google.com with SMTP id p3so394022pjd.0 for ; Mon, 19 Oct 2020 22:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yeDIIGEs4PSIIpwJxOaDX3oTcvE0+8ygpI8DM2IZWLY=; b=i1lC52PO27RNp+GEDQP/f7wsBIXw+FU1IKmyfy4yIIvc1ZLzHZbOkVuKpcUeiQXe2C NU/8xSKl2r6UikbTq7o24v9YyrLOtOsFWoTn+D4ik8YsjflzDaB/IZy62Cf1V8KZcTOj 3jf0u8JH9cjByc2BTX4mzC/wKA5WM9qYxwO3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yeDIIGEs4PSIIpwJxOaDX3oTcvE0+8ygpI8DM2IZWLY=; b=Cx6uiQiMKPrNKZLco0ecOtBFUQ58oD4MyfhvvVZSYJOBxZwLXaxrl3ew/NYpsvj178 Z1xtqjQQkddrV8omV9j61jYCVIUVfxt0M9K6L580764zJMuCxkYbxLRO+e/+9AVLQ8wP 6gpJQozGk4LiEFcSORHJiuEzstIMC60FJzzjqjjcH5rgjn1XRkjW7fF16sx06jAl6OWc IqITbV3Zd1n1KWms07QZtey0/NrPZnOtC+vPVALCnuq2kibv81vtc4ax+57B+codPwHr ObDfUDD8XkbAIyqp972Zklm71rixvc37bQVjlarWOifmxEyZHIcnQPP1eUkZKDbeemwW iuSQ== X-Gm-Message-State: AOAM532XqQpjOvQ7s+dcGKXsVaNt1GyXC2Sciq5C/Icr/cKQfuJTiQ04 jus2m8WOvexXq/OykdJJJQnTuPo5Xhy+kw== X-Google-Smtp-Source: ABdhPJx4ksBoG2tVzyzh6eJuhmzz1vxwn/Ko7LJNoGKoq1YKimvuY0lxKxeIMJEN1xk/kPFKOr4gQA== X-Received: by 2002:a17:90a:db43:: with SMTP id u3mr1321732pjx.225.1603171765747; Mon, 19 Oct 2020 22:29:25 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:25 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:29:03 +0900 Message-Id: <20201020052905.89267-7-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 6/8] libcamera: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The end semicolons with LOG_DEFINE_CATEGORY and LOG_DECLARE_CATEGORY are unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/libcamera/byte_stream_buffer.cpp | 2 +- src/libcamera/camera_sensor.cpp | 2 +- src/libcamera/file.cpp | 2 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +- src/libcamera/pipeline/simple/converter.cpp | 2 +- src/libcamera/sysfs.cpp | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp index df7029b..7db5501 100644 --- a/src/libcamera/byte_stream_buffer.cpp +++ b/src/libcamera/byte_stream_buffer.cpp @@ -14,7 +14,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(Serialization); +LOG_DEFINE_CATEGORY(Serialization) /** * \file byte_stream_buffer.h diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index 78c7cee..935de52 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -28,7 +28,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(CameraSensor); +LOG_DEFINE_CATEGORY(CameraSensor) /** * \struct CameraSensorInfo diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp index 04b0cb6..3a3f5bb 100644 --- a/src/libcamera/file.cpp +++ b/src/libcamera/file.cpp @@ -23,7 +23,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(File); +LOG_DEFINE_CATEGORY(File) /** * \class File diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index f5a20d3..92c65d0 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -66,7 +66,7 @@ public: Status validate() override; - const StreamConfiguration &cio2Format() const { return cio2Configuration_; }; + const StreamConfiguration &cio2Format() const { return cio2Configuration_; } const ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; } private: diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp index 0572acc..62605c0 100644 --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp @@ -17,7 +17,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(RPI_S_W); +LOG_DEFINE_CATEGORY(RPI_S_W) namespace RPi { diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp index 75fb297..b4ee021 100644 --- a/src/libcamera/pipeline/simple/converter.cpp +++ b/src/libcamera/pipeline/simple/converter.cpp @@ -21,7 +21,7 @@ namespace libcamera { -LOG_DECLARE_CATEGORY(SimplePipeline); +LOG_DECLARE_CATEGORY(SimplePipeline) SimpleConverter::SimpleConverter(MediaDevice *media) : m2m_(nullptr) diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp index 6c8e955..3ebe66f 100644 --- a/src/libcamera/sysfs.cpp +++ b/src/libcamera/sysfs.cpp @@ -22,7 +22,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(SysFs); +LOG_DEFINE_CATEGORY(SysFs) namespace sysfs { From patchwork Tue Oct 20 05:29:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10119 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 15496BDB13 for ; Tue, 20 Oct 2020 05:29:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D79FB6052F; Tue, 20 Oct 2020 07:29:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="PC7loJl1"; dkim-atps=neutral Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 56D1560351 for ; Tue, 20 Oct 2020 07:29:29 +0200 (CEST) Received: by mail-pf1-x435.google.com with SMTP id b26so525226pff.3 for ; Mon, 19 Oct 2020 22:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=75v/w3nIIafB6/RIoqI8PdvSiXWjzPIkd+/zy6e1BAE=; b=PC7loJl1DR6NbzzIBT/zRSld5gSEDMpAMVPK4tWfMq8IeUvNs29ukyTarpRE/mPsLB utpQ8BB3HOsVdQ3U+MK0dJAGMSHlq1Vkh+ckxWIyJQcYLxrl5sNV2iXp7/B2ooig1Ues Ety60xBW1IeuehmiDKpJS/kz/63bKmMrT7CrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=75v/w3nIIafB6/RIoqI8PdvSiXWjzPIkd+/zy6e1BAE=; b=CInnfXi2loiw3aEumacEcdE+WAgruknqMVBnLhc0paACHpt7jJZZ4lQJFi0vi3PJ09 rQiAwk6jznmfr/NECp5RbWxtWBfrOPoUlZuSDqQTpF2gIc5UGu0ZqPJMoa7bP1dRFUBx fEcheGiBSjyEbMQyrR3kZ9MY/JAyCJJvV+1XZbybBnnBsdsqQRp5aHPtyaFI6VxcaTZ2 wQ6OkXjdZlAGNLS9mpReAwhBr7ankSD+fUosdeFdl1Y1XaT7gtIcDo5m/m13y3koXA5f z+2dZzrVlosKpF818RlaANZwzmUoqEh5X1CQPXTzyilap+rBOqCZDqlaJ1icpouoiN1/ nQHg== X-Gm-Message-State: AOAM533LN0+V1bplhHSL+R03VWZIZ8QPrCTWmueQiIE7sHIrVQRaEvn8 PvIqP1YqoSlmXm+4vtQTWfU9lHoDiKpbLg== X-Google-Smtp-Source: ABdhPJxPspABezOj7MGT+YQFVKmOPTlC5kKYA+zmAO2dQuyTbRcQL9k6yr0wWNO9mZcFNU02OAretw== X-Received: by 2002:a63:1d15:: with SMTP id d21mr1269733pgd.433.1603171767780; Mon, 19 Oct 2020 22:29:27 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:27 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:29:04 +0900 Message-Id: <20201020052905.89267-8-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 7/8] ipa: Omit extra semicolon X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 48a72dd..1c255aa 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -1150,6 +1150,6 @@ struct ipa_context *ipaCreate() return new IPAInterfaceWrapper(std::make_unique()); } -}; /* extern "C" */ +} /* extern "C" */ } /* namespace libcamera */ From patchwork Tue Oct 20 05:29:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10120 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 64509BDB13 for ; Tue, 20 Oct 2020 05:29:32 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 30990613B4; Tue, 20 Oct 2020 07:29:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="j94hIST/"; dkim-atps=neutral Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B56E60351 for ; Tue, 20 Oct 2020 07:29:31 +0200 (CEST) Received: by mail-pj1-x1042.google.com with SMTP id a1so377493pjd.1 for ; Mon, 19 Oct 2020 22:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IBwbA87mFEa53OeEVLkoTjafGlDtryzgS7Jd9GFD6TE=; b=j94hIST/kwQiq9P27UX24shsY1HhknvK5pjEYDLrakWjZlbzkRNgKM26ullEQWOm7e dgCH68wIxR0fo4lBXydJFeluid6WHe6vGu+jHCZ9fDSLlALMQCgRu2UfqbWnexxYlbTH dycqor+XeBbJBU/uTj7TKOMIEHn54JOR4dYHk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IBwbA87mFEa53OeEVLkoTjafGlDtryzgS7Jd9GFD6TE=; b=oVCYU4OjGeJqUn0cvbb3edvHheoFgcguG0Fe/diYcPonJwCk+/YWa00ForbQwZ8euJ UF467bpFVrvesV+J8k4uv/zCWqXO/5n3iMwdEpBTgOKiWO97UcMbvP+CXFEwr2A1x7YQ 5d/pyQtuWf4xFIPpuEjJb4m47tjfXfqJhMl1ess8qfCM4UVWuxYJi0fRmxK9hEUbgNAv e2WfYTX41isl3bsanMmTMZkmwQhpBtPKTlYzbzsNKR4/9H3wkyc3gWPYH/T48b8fvsy+ IsCKnZqrBSkQUpbV2ycDOBQPsAfAv4HLTRjtc92avRv5g3h30ZSzBYLhAokMsziaUsYD acpw== X-Gm-Message-State: AOAM530lSmUHS5lfSNhdvTU2fqX+gummKXOcQb6mHvDJ6XoJR5lAwlP5 qBbfMR57yENV+uzzn1HTDh/O/ClPRV9Ojw== X-Google-Smtp-Source: ABdhPJyyScrcU4R7XUBF+NVkT1GZn6TbzmXWFqzA4jpGJj++jQkurezI74lxZk6FwERuC/Nd56Xy2Q== X-Received: by 2002:a17:90a:7d12:: with SMTP id g18mr1339737pjl.89.1603171769799; Mon, 19 Oct 2020 22:29:29 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:29 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:29:05 +0900 Message-Id: <20201020052905.89267-9-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 8/8] meson: Enable -Wextra-semi for clang X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The option, -Wxtra-semi, helps developers to find unnecessary semicolons. This option is available with clang. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- meson.build | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/meson.build b/meson.build index de15cc1..480c861 100644 --- a/meson.build +++ b/meson.build @@ -64,6 +64,12 @@ if cc.get_id() == 'clang' '-stdlib=libc++', ] endif + + if cc.has_argument('-Wextra-semi') + cpp_arguments += [ + '-Wextra-semi', + ] + endif endif if cc.get_id() == 'gcc'