From patchwork Tue Oct 20 00:03:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10101 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 96B69BDB1F for ; Tue, 20 Oct 2020 00:04:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 66574613AD; Tue, 20 Oct 2020 02:04:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p078zlbu"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A064760CE6 for ; Tue, 20 Oct 2020 02:04:05 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A3FF93 for ; Tue, 20 Oct 2020 02:04:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603152245; bh=MtxCaA/JlhhIbeNYyCIwH+RRPtsWH9hT72zglCmaZMk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=p078zlbue3n1WUl2thPvDDuH/XSQeDQNDNESOO5qMwU2ka2YoFbI1gcWel6xLpuPG 9BPGLMvLtJ6HjKrA44Jg7tNl6xe7J7/Ue3qFR7x8EOeed0/ypmWh6EQPECBeXbZXsA +GlhMi3N8DDtUZnFctz5yMuqRFZjy4hkilHsUYMI= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 03:03:06 +0300 Message-Id: <20201020000310.3008-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> References: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/5] ipa: Rename ipa_vimc.h to vimc.h X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To be consistent with the other pipeline handlers that don't prefix their IPA protocol header with ipa_, rename ipa_vimc.h to vimc.h. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Kieran Bingham --- include/libcamera/ipa/{ipa_vimc.h => vimc.h} | 2 +- src/ipa/vimc/vimc.cpp | 2 +- test/ipa/ipa_interface_test.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename include/libcamera/ipa/{ipa_vimc.h => vimc.h} (88%) diff --git a/include/libcamera/ipa/ipa_vimc.h b/include/libcamera/ipa/vimc.h similarity index 88% rename from include/libcamera/ipa/ipa_vimc.h rename to include/libcamera/ipa/vimc.h index 8e82dd94bf47..22d97992f80f 100644 --- a/include/libcamera/ipa/ipa_vimc.h +++ b/include/libcamera/ipa/vimc.h @@ -2,7 +2,7 @@ /* * Copyright (C) 2019, Google Inc. * - * ipa_vimc.h - Vimc Image Processing Algorithm module + * vimc.h - Vimc Image Processing Algorithm module */ #ifndef __LIBCAMERA_IPA_VIMC_H__ diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index 372a15f555cb..cf8411359e40 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -5,7 +5,7 @@ * ipa_vimc.cpp - Vimc Image Processing Algorithm module */ -#include +#include #include #include diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp index 1bc93a631a63..67488409e7ff 100644 --- a/test/ipa/ipa_interface_test.cpp +++ b/test/ipa/ipa_interface_test.cpp @@ -14,7 +14,7 @@ #include #include -#include +#include #include #include "libcamera/internal/device_enumerator.h" From patchwork Tue Oct 20 00:03:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10102 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3D510BDB20 for ; Tue, 20 Oct 2020 00:04:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 17E5D613B9; Tue, 20 Oct 2020 02:04:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CbWIzqq5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E67A060CE6 for ; Tue, 20 Oct 2020 02:04:05 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B4E552 for ; Tue, 20 Oct 2020 02:04:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603152245; bh=jbKwQifX6VEF/mQftap82PE6c+gUo2g4JVfeSx8vhWk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=CbWIzqq5KJZ1N8++9ZxvEyzBnLm2q6AiLcFzXciIrLKSL8ynCAjPszMOQbobBABiM Ym8Znk/e4/0b0FhY1EMvpj2wSby6dPP8fcVPAooBBc/z7fc+UcVVIGGNBLJUM0k8ao js+HVErLXQQunVgFeuDBve+zzyFqxFbDfisBd/v8= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 03:03:07 +0300 Message-Id: <20201020000310.3008-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> References: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/5] ipa: Skip doxygen parsing for pipeline-specific IPA headers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The pipeline-specific IPA headers are not part of the libcamera API, they should thus be skipped when generating documentation. doxygen doesn't complain currently due to the fact that types defined in those headers are part of undocumented namespaces. In preparation for documenting the libcamera namespace, make sure the headers don't get parsed by doxygen. Only vimc.h needs a header guard, as rkisp1.h uses the global namespace and raspberrypi.h uses the undocumented libcamera::RPi namespace, neither of which cause issues. Still, for consistency, add header guards to all headers. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Acked-by: Kieran Bingham --- include/libcamera/ipa/raspberrypi.h | 4 ++++ include/libcamera/ipa/rkisp1.h | 4 ++++ include/libcamera/ipa/vimc.h | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h index b3041591ff7c..b23baf2f1330 100644 --- a/include/libcamera/ipa/raspberrypi.h +++ b/include/libcamera/ipa/raspberrypi.h @@ -10,6 +10,8 @@ #include #include +#ifndef __DOXYGEN__ + namespace libcamera { namespace RPi { @@ -66,4 +68,6 @@ static const ControlInfoMap Controls = { } /* namespace libcamera */ +#endif /* __DOXYGEN__ */ + #endif /* __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__ */ diff --git a/include/libcamera/ipa/rkisp1.h b/include/libcamera/ipa/rkisp1.h index 4fe0482b8de5..bb824f292032 100644 --- a/include/libcamera/ipa/rkisp1.h +++ b/include/libcamera/ipa/rkisp1.h @@ -7,6 +7,8 @@ #ifndef __LIBCAMERA_IPA_INTERFACE_RKISP1_H__ #define __LIBCAMERA_IPA_INTERFACE_RKISP1_H__ +#ifndef __DOXYGEN__ + enum RkISP1Operations { RKISP1_IPA_ACTION_V4L2_SET = 1, RKISP1_IPA_ACTION_PARAM_FILLED = 2, @@ -15,4 +17,6 @@ enum RkISP1Operations { RKISP1_IPA_EVENT_QUEUE_REQUEST = 5, }; +#endif /* __DOXYGEN__ */ + #endif /* __LIBCAMERA_IPA_INTERFACE_RKISP1_H__ */ diff --git a/include/libcamera/ipa/vimc.h b/include/libcamera/ipa/vimc.h index 22d97992f80f..27a4a61df889 100644 --- a/include/libcamera/ipa/vimc.h +++ b/include/libcamera/ipa/vimc.h @@ -8,6 +8,8 @@ #ifndef __LIBCAMERA_IPA_VIMC_H__ #define __LIBCAMERA_IPA_VIMC_H__ +#ifndef __DOXYGEN__ + namespace libcamera { #define VIMC_IPA_FIFO_PATH "/tmp/libcamera_ipa_vimc_fifo" @@ -21,4 +23,6 @@ enum IPAOperationCode { } /* namespace libcamera */ +#endif /* __DOXYGEN__ */ + #endif /* __LIBCAMERA_IPA_VIMC_H__ */ From patchwork Tue Oct 20 00:03:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10103 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AE00BBDB1F for ; Tue, 20 Oct 2020 00:04:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 89C96613CA; Tue, 20 Oct 2020 02:04:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YmlK6plK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FFFB613BB for ; Tue, 20 Oct 2020 02:04:06 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DFB9693 for ; Tue, 20 Oct 2020 02:04:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603152246; bh=8BoDIcM4DjyFZqdU4i+gFFnrw+luwGPktI/qKe4uiKw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=YmlK6plKpv1FpZmeJNvrLzRgaYw3fKD1uleBf0WspKkVFqZa20F1Sz0D6uNpqo/u0 Kp52T7LEos2tfrt7vHaIcNOo6q5fri5L8LR7dwJtgxggLzj/Dmp4h4C5x1zCllJGnT tHZYBulBHKZR+8KC1mM/KzJIltEA6yOC4F6eKbmA= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 03:03:08 +0300 Message-Id: <20201020000310.3008-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> References: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \file block above namespace X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make the whole code base consistent by placing the doxygen \file block above the libcamera namespace opening. There's a single offender, and two locations in which a white line is missing. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- src/libcamera/byte_stream_buffer.cpp | 8 ++++---- src/libcamera/v4l2_pixelformat.cpp | 1 + src/libcamera/v4l2_videodevice.cpp | 1 + 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp index df7029b02a7f..eb9003927266 100644 --- a/src/libcamera/byte_stream_buffer.cpp +++ b/src/libcamera/byte_stream_buffer.cpp @@ -12,15 +12,15 @@ #include "libcamera/internal/log.h" -namespace libcamera { - -LOG_DEFINE_CATEGORY(Serialization); - /** * \file byte_stream_buffer.h * \brief Managed memory container for serialized data */ +namespace libcamera { + +LOG_DEFINE_CATEGORY(Serialization); + /** * \class ByteStreamBuffer * \brief Wrap a memory buffer and provide sequential data read and write diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp index 6b05909f56ae..03ab085c1231 100644 --- a/src/libcamera/v4l2_pixelformat.cpp +++ b/src/libcamera/v4l2_pixelformat.cpp @@ -22,6 +22,7 @@ * \file v4l2_pixelformat.h * \brief V4L2 Pixel Format */ + namespace libcamera { LOG_DECLARE_CATEGORY(V4L2) diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index 508522ef42bb..16162e1edba3 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -32,6 +32,7 @@ * \file v4l2_videodevice.h * \brief V4L2 Video Device */ + namespace libcamera { LOG_DECLARE_CATEGORY(V4L2) From patchwork Tue Oct 20 00:03:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10104 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 10FB8BDB1F for ; Tue, 20 Oct 2020 00:04:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D42B7610C4; Tue, 20 Oct 2020 02:04:11 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LKyiNEC5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BB44613BF for ; Tue, 20 Oct 2020 02:04:06 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BC0B52 for ; Tue, 20 Oct 2020 02:04:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603152246; bh=yCuiI6xeSNtaEoH7Adc0EyPxKhZS2xZjK+GYOovlXN0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=LKyiNEC5+hWzcDyssVVLc5oFF8y6gPqU/QoAlDfeUuyIdNO8mqfQlsgjxKCUX6eQE FFzWqq2vtLqtygphvTtVmAx9bsQpMW1MgoBbRKv1ewjduMr3r9kkVhi6Tl+y8sVjn3 XNuwgqfjgFUjS+VYm/YxuKZPxZdfACuxBEpe9+GE= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 03:03:09 +0300 Message-Id: <20201020000310.3008-5-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> References: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after LOG_{DECLARE, DEFINE}_CATEGORY X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No semicolon is needed after the macro. Drop it in the few locations that have one. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- src/libcamera/byte_stream_buffer.cpp | 2 +- src/libcamera/camera_sensor.cpp | 2 +- src/libcamera/file.cpp | 2 +- src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +- src/libcamera/pipeline/simple/converter.cpp | 2 +- src/libcamera/sysfs.cpp | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp index eb9003927266..7fc6f6944471 100644 --- a/src/libcamera/byte_stream_buffer.cpp +++ b/src/libcamera/byte_stream_buffer.cpp @@ -19,7 +19,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(Serialization); +LOG_DEFINE_CATEGORY(Serialization) /** * \class ByteStreamBuffer diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index 78c7ceec7c44..935de528c496 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -28,7 +28,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(CameraSensor); +LOG_DEFINE_CATEGORY(CameraSensor) /** * \struct CameraSensorInfo diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp index 04b0cb61a1bf..3a3f5bb63ffc 100644 --- a/src/libcamera/file.cpp +++ b/src/libcamera/file.cpp @@ -23,7 +23,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(File); +LOG_DEFINE_CATEGORY(File) /** * \class File diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp index 0572acc93d63..62605c0fceee 100644 --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp @@ -17,7 +17,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(RPI_S_W); +LOG_DEFINE_CATEGORY(RPI_S_W) namespace RPi { diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp index 75fb297ebd58..b4ee021f6210 100644 --- a/src/libcamera/pipeline/simple/converter.cpp +++ b/src/libcamera/pipeline/simple/converter.cpp @@ -21,7 +21,7 @@ namespace libcamera { -LOG_DECLARE_CATEGORY(SimplePipeline); +LOG_DECLARE_CATEGORY(SimplePipeline) SimpleConverter::SimpleConverter(MediaDevice *media) : m2m_(nullptr) diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp index 6c8e9554188d..3ebe66f8d69b 100644 --- a/src/libcamera/sysfs.cpp +++ b/src/libcamera/sysfs.cpp @@ -22,7 +22,7 @@ namespace libcamera { -LOG_DEFINE_CATEGORY(SysFs); +LOG_DEFINE_CATEGORY(SysFs) namespace sysfs { From patchwork Tue Oct 20 00:03:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10105 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 764EDBDB20 for ; Tue, 20 Oct 2020 00:04:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 40F10613C7; Tue, 20 Oct 2020 02:04:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lKAomt5f"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ED7661373 for ; Tue, 20 Oct 2020 02:04:07 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AD8A93 for ; Tue, 20 Oct 2020 02:04:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603152246; bh=FTzyW4EaAvKsmKJ2HO7vLBvMq0yeOnloqOmNhNq/ETI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=lKAomt5fycyMFc9OePEDbEHAk3GgovBbQz73KvFl+9mbIEXeHlXJ0+sQP4aNP9hsS 2d7mMr8QqRxgMUOqVktaSdQEcWDRAkQT7/E8OxwCIlWR45jcAfN0P/vkDFcsqZZ85D EA5FVhIBpLkRJZ6lG3NcHby/ePjA7Z8jCfRMotp8= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 03:03:10 +0300 Message-Id: <20201020000310.3008-6-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> References: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera namespace X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The libcamera namespace has been left undefined from the start. While the documentation doesn't bring much added value, leaving it out confuses the most recent doxygen master branch: include/libcamera/transform.h:16: warning: Internal inconsistency: member Identity does not belong to any container! include/libcamera/transform.h:17: warning: Internal inconsistency: member Rot0 does not belong to any container! include/libcamera/transform.h:18: warning: Internal inconsistency: member HFlip does not belong to any container! include/libcamera/transform.h:19: warning: Internal inconsistency: member VFlip does not belong to any container! include/libcamera/transform.h:20: warning: Internal inconsistency: member HVFlip does not belong to any container! include/libcamera/transform.h:21: warning: Internal inconsistency: member Rot180 does not belong to any container! include/libcamera/transform.h:22: warning: Internal inconsistency: member Transpose does not belong to any container! include/libcamera/transform.h:23: warning: Internal inconsistency: member Rot270 does not belong to any container! include/libcamera/transform.h:24: warning: Internal inconsistency: member Rot90 does not belong to any container! include/libcamera/transform.h:26: warning: Internal inconsistency: member Rot180Transpose does not belong to any container! Document it. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- src/libcamera/camera_manager.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 756f5b2b4a03..81785f919d8b 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -27,6 +27,9 @@ * \brief The camera manager */ +/** + * \brief Top-level libcamera namespace + */ namespace libcamera { LOG_DEFINE_CATEGORY(Camera)