From patchwork Sun Sep 20 13:43:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 9672 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 638D2BF01C for ; Sun, 20 Sep 2020 13:44:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id ED48062FBF; Sun, 20 Sep 2020 15:44:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="j4/wjBjD"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E85B662E65 for ; Sun, 20 Sep 2020 15:44:33 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D1344FB for ; Sun, 20 Sep 2020 15:44:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600609473; bh=dyfJ/edHvVL6uxlyxyoCejgBBYRBNJDLLxp26dZHq4I=; h=From:To:Subject:Date:From; b=j4/wjBjDBCtSw8IMqQyWMbgN+pk+JJeci3/wwYtEuESyBmz0mCcleMEZ1njwH24YA nv55++n9ZPJdj29tfEQ0roeQiPlJCmzfvrMym774kV5VCRxXCgboH+cpbY61uvKkq9 PrHNNA294gRz/RSLoOLyiniFh0/K6nvN0U/OGKNA= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sun, 20 Sep 2020 16:43:56 +0300 Message-Id: <20200920134356.24605-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: Don't unnecessarily include event_notifier.h X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ipc_unixsocket.h and process.h internal headers don't need to include event_notifier.h, the former because a forward declaration suffices, and the latter because it doesn't use event notifiers. Remove the unnecessary include, and include signal.h instead which is required and was included indirectly through event_notifier.h. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham --- include/libcamera/internal/ipc_unixsocket.h | 4 +++- include/libcamera/internal/process.h | 2 +- src/libcamera/ipc_unixsocket.cpp | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/libcamera/internal/ipc_unixsocket.h b/include/libcamera/internal/ipc_unixsocket.h index 9dcaaa26956d..e871b65036bd 100644 --- a/include/libcamera/internal/ipc_unixsocket.h +++ b/include/libcamera/internal/ipc_unixsocket.h @@ -12,10 +12,12 @@ #include #include -#include +#include namespace libcamera { +class EventNotifier; + class IPCUnixSocket { public: diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h index 36595106f3b9..2688557cb8e2 100644 --- a/include/libcamera/internal/process.h +++ b/include/libcamera/internal/process.h @@ -10,7 +10,7 @@ #include #include -#include +#include namespace libcamera { diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp index 701b2c518217..5c8cce16200e 100644 --- a/src/libcamera/ipc_unixsocket.cpp +++ b/src/libcamera/ipc_unixsocket.cpp @@ -12,6 +12,8 @@ #include #include +#include + #include "libcamera/internal/log.h" /**