From patchwork Tue Aug 4 12:28:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 9182 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6CB31BD87A for ; Tue, 4 Aug 2020 12:28:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C2CB16054B; Tue, 4 Aug 2020 14:28:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="oxJGFaDA"; dkim-atps=neutral Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DB85C6048E for ; Tue, 4 Aug 2020 14:28:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:mime-version:to:cc:content-transfer-encoding: content-type; s=s1; bh=B1OfbPaQqfLIH6IYQqGl5BhGqmREUJTqU4uG59EYp28=; b=oxJGFaDAyXzSWCj3C65ptyFeRq2VG+3CTXht9NtGDVH0wTsslEWMO2i1dRFGiAZ7kqBB hoel94aK06lSdsKSJvg4DhD6lDjtS7EMqjgcsBSKpPFISTgTwCq5geYiN1ODZoErvoSt5E xcHpZnV2W/88jywznRjdZZMQSRRuTFOKM= Received: by filterdrecv-p3iad2-canary-6b67849fb4-tmzt8 with SMTP id filterdrecv-p3iad2-canary-6b67849fb4-tmzt8-19-5F295451-3A 2020-08-04 12:28:01.652502455 +0000 UTC m=+501624.283563418 Received: from mail.uajain.com (unknown) by ismtpd0006p1hnd1.sendgrid.net (SG) with ESMTP id Fe8DgdyXSxyTBcd5vFLkbw for ; Tue, 04 Aug 2020 12:28:01.183 +0000 (UTC) From: Umang Jain Date: Tue, 04 Aug 2020 12:28:01 +0000 (UTC) Message-Id: <20200804122755.30743-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcQmPzxg2d8HRoKJI5HeDXchhGDjLfhUuVkmkf8jM22WoLu8Qkq0URLwJDCkJtWzV/9yqGRE6pbc8ol9FFT6hEn17Ms3xgcERq96K1SfEYU3Ak0D+kqLrue9AgigW6J5McGAcxmlXC+yIyEhvb6LTDHkskAocjf0i4P6DmFiKdssiLwwrA6d6oqiiQifY1vh+NFlkay/tPzt98MrpGDbIK8D7AFPQtMcaSiZgejK9Y89I= To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH 1/2] android: camera_hal_manager: Remove unused getStaticMetadata() method X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The CameraHalManager::getStaticMethod() method isn't used, remove it. Signed-off-by: Umang Jain Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Acked-by: Jacopo Mondi --- src/android/camera_hal_manager.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h index 94d8f00..0619037 100644 --- a/src/android/camera_hal_manager.h +++ b/src/android/camera_hal_manager.h @@ -31,8 +31,6 @@ public: int getCameraInfo(unsigned int id, struct camera_info *info); private: - camera_metadata_t *getStaticMetadata(unsigned int id); - libcamera::CameraManager *cameraManager_; std::vector> cameras_; From patchwork Tue Aug 4 12:28:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 9181 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E9BE6BD87A for ; Tue, 4 Aug 2020 12:28:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7529A60548; Tue, 4 Aug 2020 14:28:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="Y9PF+e3+"; dkim-atps=neutral Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DEACC60495 for ; Tue, 4 Aug 2020 14:28:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type; s=s1; bh=lyRks2+YQtwVY+HCbDY+rqYpYVWucVvfFRcCxXjSejY=; b=Y9PF+e3+dzh6c6PluLydwuuwMhAiyT6XscU6/lKZbVRsfCqa/2GlqjeUpCogQZ6+rY1D qvJ1FVkG8KFTZ8q3RSnqni9iftagMMRaeGeHJwy8Mv9v7grzx7ycwbq/jNogTh8SdHK0ei O+9LHKu0CDESecCMXdffYtn36f/MgjjS8= Received: by filterdrecv-p3iad2-d8cc6d457-mbgrc with SMTP id filterdrecv-p3iad2-d8cc6d457-mbgrc-20-5F295451-50 2020-08-04 12:28:01.914906898 +0000 UTC m=+497981.997397122 Received: from mail.uajain.com (unknown) by ismtpd0005p1hnd1.sendgrid.net (SG) with ESMTP id Jwcvt9yURx20f7VGX14PcA for ; Tue, 04 Aug 2020 12:28:01.557 +0000 (UTC) From: Umang Jain Date: Tue, 04 Aug 2020 12:28:01 +0000 (UTC) Message-Id: <20200804122755.30743-2-email@uajain.com> In-Reply-To: <20200804122755.30743-1-email@uajain.com> References: <20200804122755.30743-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcGsFXrTC3nkaVUz7y/MXE3eK6aDq18oWH0RceqNatiAcOEol2uCa9XFucMtQSWKgaDjz7++psLAp5uK4lFEBDQUGcDOxIgDvIsmIGTsVbHj/122ow7vEdZTVBI8rYrsnrZ7DQZzuISeFW1Y3DBc+NdHxgQbWqOrYWoFawM6wt69auB9nCIFVjRHjB6zZnh7RvJVf8XFfpgmJD6mkJPsvcXg== To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH 2/2] android: camera_ops: Fix a documentation spelling typo X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Umang Jain Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham --- src/android/camera_ops.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/camera_ops.cpp b/src/android/camera_ops.cpp index 9dfc2e6..216ac28 100644 --- a/src/android/camera_ops.cpp +++ b/src/android/camera_ops.cpp @@ -14,7 +14,7 @@ using namespace libcamera; /* - * Translatation layer between the Android Camera HAL device operations and the + * Translation layer between the Android Camera HAL device operations and the * CameraDevice. */