From patchwork Sun Aug 2 22:50:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 9134 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9C8E3BD87A for ; Sun, 2 Aug 2020 22:50:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1BDE2609B2; Mon, 3 Aug 2020 00:50:47 +0200 (CEST) Received: from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net [195.74.38.229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9569060398 for ; Mon, 3 Aug 2020 00:50:45 +0200 (CEST) X-Halon-ID: 954c2805-d512-11ea-933e-005056917a89 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de [84.172.82.168]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA id 954c2805-d512-11ea-933e-005056917a89; Mon, 03 Aug 2020 00:50:42 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Mon, 3 Aug 2020 00:50:23 +0200 Message-Id: <20200802225023.346784-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev: Align class final declaration with sysfs subclass X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Instead of marking each individual overloaded function with final mark the whole class as final. This aligns the sysfs and udev based DeviceEnumerator implementations. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Reviewed-by: Umang Jain --- include/libcamera/internal/device_enumerator_udev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h index 2e7916a0b280f60d..6f45be0c1c423d02 100644 --- a/include/libcamera/internal/device_enumerator_udev.h +++ b/include/libcamera/internal/device_enumerator_udev.h @@ -26,14 +26,14 @@ class EventNotifier; class MediaDevice; class MediaEntity; -class DeviceEnumeratorUdev : public DeviceEnumerator +class DeviceEnumeratorUdev final : public DeviceEnumerator { public: DeviceEnumeratorUdev(); ~DeviceEnumeratorUdev(); - int init() final; - int enumerate() final; + int init(); + int enumerate(); private: using DependencyMap = std::map>;