From patchwork Wed Oct 7 09:22:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 9990 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5BFDDBEEDF for ; Wed, 7 Oct 2020 09:23:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BE56063CE5; Wed, 7 Oct 2020 11:23:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="J3fyom/a"; dkim-atps=neutral Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E2B9163CDC for ; Wed, 7 Oct 2020 11:23:25 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id 133so1270524ljj.0 for ; Wed, 07 Oct 2020 02:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6tdlQlbPp1GAElnJIvX3oIIAHk6QbyrOu0AkYBVPwpA=; b=J3fyom/abb6YotmXW/C1M5IKrQXjZynckhcREoql6UhOmUsBuUCsUDpPrT5iixiR/o 4jIQ+HgpNWCRPty8I84l9otF7Le0KsClx9LLVtSKilICAPSZyBuzuuQqAJmSNbMMVIGn y5M3dnxOp2IoWDqUb3wr7bM2VXkb5+magibL98XLdEjslq3rNt1ZJVZoLXmp+j7eahb2 R6cMY18AsuzA3+cBvsvduc652qej2ncuaHyLyqP46hJBL0+NMQ5gUGiOkdkU3ecAQnWA MZ9PrdtrMa2aq0JggfK9l+/LpBzd6atwnN2OsxY19jM2PAoEjFLZLEsQAyPg2Qafz7c+ IVeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=6tdlQlbPp1GAElnJIvX3oIIAHk6QbyrOu0AkYBVPwpA=; b=Hb5B/FmGaeVYINAw5s84p9SX1w6a5u7EMbVDlqK66c5Z7YSX+zXE2ONOsaaAVbuQO/ mpPsF0kNfnldoMX8rkNqqAfW3mr+5bVtJeO2gPrdqCaU5WwflGEzXTB9uQPgqitTxGWv wk6VJlLEh6VK2L21YCO/30GXXX0FIEJ+0BoazBP2JO9fgAgrXrFUQ3P2FVN257P0wfaw T5mjAzFgL6Q0tuveVcxBT7ASTWmOHSv6qBXTF4XoaNxrrj1DT1ew85HRVgWatUaMG8Hm tL9lZOr8wcyY6Jzj+mmgXVU6GEb1Sek0C5Ld9DPUTUG1Iv0kjwExAhZFwnzq7pvtEzP/ 9Orw== X-Gm-Message-State: AOAM532RiyMRUrL9RpqiGfVJdRE5aTo2iJ96n7AyKPBt1JqZV2mLXtjl +raUMeKbTyMEf9UN1Cs09fifb8zczAHboQ== X-Google-Smtp-Source: ABdhPJwCV4arsLR9cOXdDGI9i2UKV60JwDoGgPqljpgfDyHBpiK3KkOmTf62ZtsiagM+/9tySX935w== X-Received: by 2002:a2e:e1a:: with SMTP id 26mr776249ljo.377.1602062605254; Wed, 07 Oct 2020 02:23:25 -0700 (PDT) Received: from deskari.lan (91-152-83-50.elisa-laajakaista.fi. [91.152.83.50]) by smtp.gmail.com with ESMTPSA id n26sm258341ljg.133.2020.10.07.02.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 02:23:24 -0700 (PDT) From: Tomi Valkeinen To: libcamera-devel@lists.libcamera.org Date: Wed, 7 Oct 2020 12:22:39 +0300 Message-Id: <20201007092239.41704-4-tomi.valkeinen@iki.fi> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201007092239.41704-1-tomi.valkeinen@iki.fi> References: <20201007092239.41704-1-tomi.valkeinen@iki.fi> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/4] vimc: fix close(-1) X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" ~IPAVimc() checks if fd != 0, but it should check if fd != -1. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/ipa/vimc/vimc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index ef25776..372a15f 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -61,7 +61,7 @@ IPAVimc::IPAVimc() IPAVimc::~IPAVimc() { - if (fd_) + if (fd_ != -1) ::close(fd_); }