From patchwork Fri Oct 2 00:43:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 9896 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D7FF7C3B5C for ; Fri, 2 Oct 2020 00:44:32 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6CE7060BCD; Fri, 2 Oct 2020 02:44:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wCpDrZkf"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9042F60363 for ; Fri, 2 Oct 2020 02:44:30 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 201F9255 for ; Fri, 2 Oct 2020 02:44:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1601599470; bh=UsmdvHxi8u4xXoaAqhVF+vYWmbalzyIgOW4Lc/BCJWI=; h=From:To:Subject:Date:From; b=wCpDrZkfXazpyIUwrpZk1ZD4uIHTuusRJB0XiP8oJkuQL66MsKOujsIbwbAht8KU7 i8dnAN6nbpwB6WNa0yf6d+umj3gAQqh0s9RnZjVriecR2oPNBS5IqjB1NSPwNYzk+v hQbsHqwY5LpegtT/T8/R3oCWAHFfFUm3Ij5toBG0= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 2 Oct 2020 03:43:49 +0300 Message-Id: <20201002004349.13258-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] utils: hooks: pre-push: Accept Acked-by in addition to Reviewed-by X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Allow pushing commits that have no Reviewed-by tag but have at least one Acked-by tag. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Niklas Söderlund --- utils/hooks/pre-push | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push index 5dc8addabeb6..2417d379db4c 100755 --- a/utils/hooks/pre-push +++ b/utils/hooks/pre-push @@ -57,10 +57,10 @@ do errors=$((errors+1)) fi - # 3. A Reviewed-by is required. - if ! echo "$msg" | grep -q '^Reviewed-by: ' + # 3. A Reviewed-by or Acked-by is required. + if ! echo "$msg" | grep -q '^\(Reviewed\|Acked\)-by: ' then - echo >&2 "No Reviewed-by in commit $commit" + echo >&2 "No Reviewed-by or Acked-by in commit $commit" errors=$((errors+1)) fi done