From patchwork Mon Sep 28 08:28:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 9837 X-Patchwork-Delegate: jacopo@jmondi.org Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 83765C3B5C for ; Mon, 28 Sep 2020 08:25:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2CCB460364; Mon, 28 Sep 2020 10:25:13 +0200 (CEST) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C9776035F for ; Mon, 28 Sep 2020 10:25:11 +0200 (CEST) Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id BE8B4100010; Mon, 28 Sep 2020 08:25:10 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 28 Sep 2020 10:28:58 +0200 Message-Id: <20200928082858.2994-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: pipeline: Drop setStream() from configure() documentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" There is no requirement for Stream to be assigned to StreamConfiguration during PipelineHandler::configure(). It actually happens at validate() time in most implementations right now. Drop this requirement from PipelineHandler::configure() documentation. Signed-off-by: Jacopo Mondi Acked-by: Laurent Pinchart --- src/libcamera/pipeline_handler.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 918aea1e8328..713fe6d1d362 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -314,10 +314,6 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const * perform further validation and may rely on any custom field stored in its * custom CameraConfiguration derived class. * - * When configuring the camera the pipeline handler shall associate a Stream - * instance to each StreamConfiguration entry in the CameraConfiguration using - * the StreamConfiguration::setStream() method. - * * \context This function is called from the CameraManager thread. * * \return 0 on success or a negative error code otherwise