From patchwork Fri Sep 25 14:05:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 9828 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 21E6EC3B5C for ; Fri, 25 Sep 2020 14:06:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 95A0363021; Fri, 25 Sep 2020 16:06:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="uscEgmSd"; dkim-atps=neutral Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B17F62FD8 for ; Fri, 25 Sep 2020 16:06:23 +0200 (CEST) Received: by mail-lj1-x242.google.com with SMTP id y4so2578318ljk.8 for ; Fri, 25 Sep 2020 07:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YDoFpj5E4PD0gmKE341p+jnjq57+qnDQJjf5B/pjoXA=; b=uscEgmSd0Bp9gTJ2USypHAJLZUxCd7KWq3UMJABw11fby5LsdtDuTBA/vKKbkhXBhZ dlSrXEJlDfPZut23LRkJKlBZlZ40NA1+NZ++xj61nMjrvNCyL4DEsvmn+oQd6mA8bOMI PGo50aunSUVVrgHwrg5Ttp5GrSIeXK7seCZm/bMgAvTp3fXS08VnY6M23T5NnAsomDqp XAr4xkIs3+TbioO5MKUBq1Oxava+X1hcZog9MVYV0MXnCyIqsGmlN1c1boVYWBWeRJr5 uZ2ooQ0ZD4EiDIvo53DgA8PfF6dk6ONbhO57+1pq/ZUPuGrpPiACS6RUwJ+d+EcSIkQD hE1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=YDoFpj5E4PD0gmKE341p+jnjq57+qnDQJjf5B/pjoXA=; b=kP+rZh0Zal3CYMVwB8z06CGM0tQaQYU/XfS6JOQ+GcgEf6eLheqG60eoSQMAiNz3oK NVnI+iODLa7HajWeYimJsV1MoHJ7cxi6sKX3RoYUx8zvgBBSZyser4y0Pp81p7rECPNR epw9us7efp6wZR3OppVJep1FmnqF0yoCD6DQ/M/qqELlmz3YiDC1ypO280NtDAGialfQ blb5vZkkzc4Mvnu1RKOSQbDahkgt+ryKBckrdNjSAJv7obVljVqkABom+B+uSVZzbRj2 kNvySsry/D4GmY5ubNurv6h2Up4NHCtmTjbEbYJf33oPjnMkz2MDwKv9Z1ujvorp61Vs lxVw== X-Gm-Message-State: AOAM5300+gnUu0Xl1gW1/u2UIONFelaf+028ARbLEAlisV/ZoCvIMQZl lIIZDA+Q5wYlJjecQjklkaPeUnhdlknBbg== X-Google-Smtp-Source: ABdhPJzLJPWIEdnPyWCH43K/oAzWYEEFtud25h7YY+TsufMBhiGKPwQDo1HPKdtlqyzi2/aCZTcjHg== X-Received: by 2002:a05:651c:107b:: with SMTP id y27mr1314974ljm.338.1601042782384; Fri, 25 Sep 2020 07:06:22 -0700 (PDT) Received: from deskari.ti.com (91-152-83-50.elisa-laajakaista.fi. [91.152.83.50]) by smtp.gmail.com with ESMTPSA id u20sm2329672lfo.156.2020.09.25.07.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 07:06:21 -0700 (PDT) From: Tomi Valkeinen To: libcamera-devel@lists.libcamera.org Date: Fri, 25 Sep 2020 17:05:25 +0300 Message-Id: <20200925140525.91943-1-tomi.valkeinen@iki.fi> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] FrameBufferAllocator: fix non-copyability X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" FrameBufferAllocator is supposed to delete copy constructor and copy-assignment operator. It doesn't do that as it uses Camera as a parameter instead of FrameBufferAllocator. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- include/libcamera/framebuffer_allocator.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libcamera/framebuffer_allocator.h b/include/libcamera/framebuffer_allocator.h index 78f1353..a96aaea 100644 --- a/include/libcamera/framebuffer_allocator.h +++ b/include/libcamera/framebuffer_allocator.h @@ -21,8 +21,8 @@ class FrameBufferAllocator { public: FrameBufferAllocator(std::shared_ptr camera); - FrameBufferAllocator(const Camera &) = delete; - FrameBufferAllocator &operator=(const Camera &) = delete; + FrameBufferAllocator(const FrameBufferAllocator &) = delete; + FrameBufferAllocator &operator=(const FrameBufferAllocator &) = delete; ~FrameBufferAllocator();