From patchwork Fri Sep 18 09:42:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 9649 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 05ED1C3B5D for ; Fri, 18 Sep 2020 09:44:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BA4E562FC2; Fri, 18 Sep 2020 11:44:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="U0DSjait"; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F0DC62FAF for ; Fri, 18 Sep 2020 11:43:58 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id z9so4874666wmk.1 for ; Fri, 18 Sep 2020 02:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nE/emN/9YQ8F/OJCPwpwoa+soM6JSc3SLzfzjKB3NuU=; b=U0DSjaitaVqcUq8uu9G+GYfyAMP7BY3asPt5PGXll5LBR34UgA0MsS0zoFfchMhqIZ Routru0keEdD0g8239b8H34Ah17Rxopwg3xmG6uUgtwMihBYqaykaRvJHBBteTXk1dRN oaRoXyvXWj5jhXR1AsrBhjpuKe6duAii4JialE1Wrz5IBYGMS/eEJoi74EriBGZKgjro Yp82e5zT34QNFuTlZkfLAlXA4wAGKeGOWkYlT+Il5BPXaE+gpvz+UTuXgtHvyFdW8Exl dxXWN32eM0x/iQhZ4sf0hzlRYZd2k84aBAEouutRV9wXjbVp1hiGpBu3A6dpIFxNyIHv Q35A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nE/emN/9YQ8F/OJCPwpwoa+soM6JSc3SLzfzjKB3NuU=; b=UI66IZVDDERX6cihfXP0sqqXqNagZvlGtjMKvfIfmWsJ5LMNNUAJ96e2+SVp8eSv2L LJw5XuaAGFgmsL+rOlPA+NVj26EJLawLYVdFVfZUzn0Emb+9houlMCKqlFzFX1j3Vq10 z7pppOzIJkAKBtZVlWsnxntmbpXBXFNH9Tu68FzSj1hLqCmU2LrlVpTZdHsa4xsG5eS8 Z47CkgnocGCo/bqIj7wFmQqt94hHzNCVyMteki/kAdYxTYltlarwK4Vd1DwoOEKKYDzo H71oinfYCVXLQvtTNSMcy3podUuknyQBLrk8kQaqd0ZonlD1NrsmQg33w/acHnZcb3l3 JsfQ== X-Gm-Message-State: AOAM532sVc8/Jj9krCPzaPa/LfGqeU0TqKQTS5Bh2sxadsFW4lZIwylO XxPVKtplTfu0auiS49z+gL1KPRTfkfrIzQ== X-Google-Smtp-Source: ABdhPJzWLm9TsmDCMIMArNdCmNs3FVYZUhPKLn7fHRBdgIOA62fZ9O2uGOir19WQIy3zfwNXUpq8Zg== X-Received: by 2002:a1c:2ed0:: with SMTP id u199mr14222107wmu.125.1600422238133; Fri, 18 Sep 2020 02:43:58 -0700 (PDT) Received: from naushir-VirtualBox.pitowers.org ([2a00:1098:3142:14:a00:27ff:fe4d:f6a2]) by smtp.gmail.com with ESMTPSA id n2sm4792472wma.29.2020.09.18.02.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 02:43:57 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Sep 2020 10:42:25 +0100 Message-Id: <20200918094233.5273-5-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918094233.5273-1-naush@raspberrypi.com> References: <20200918094233.5273-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v8 04/12] libcamera: pipeline: raspberrypi: Increase the number of RAW buffers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Increase the number of expected RAW buffers in the stream configuration to 2. This will avoid dropping Unicam frames when exporting RAW streams. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Tested-by: David Plowman --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index f15345ea..ed83a2c6 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -378,7 +378,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera, sensorFormat = findBestMode(fmts, size); pixelFormat = sensorFormat.fourcc.toPixelFormat(); ASSERT(pixelFormat.isValid()); - bufferCount = 1; + bufferCount = 2; rawCount++; break;