From patchwork Fri Sep 18 09:42:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 9648 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9C8C6C3B5B for ; Fri, 18 Sep 2020 09:44:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 49B3B62FB6; Fri, 18 Sep 2020 11:44:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="jZXR4TXX"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B075162FAF for ; Fri, 18 Sep 2020 11:43:57 +0200 (CEST) Received: by mail-wm1-x343.google.com with SMTP id x23so4667622wmi.3 for ; Fri, 18 Sep 2020 02:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=; b=jZXR4TXXdKVf2OrxYWPsAFx2q2uSThoujCNFvYjGMRTiAwmQhZ5npsvATrs0AlCtIg fmBRzdqPpdPuFjXdTtxsr6yidC2bqHW9lsfcWMQRd2dZexvIHVhYvO22Ud71Oh/iCSKb wrz1tIVcazUL7DoaV6Viz/ErO383ZqIQANnC1PtmVLwWl8e0sghVtWziDyNrX8jwRNzy HMDaAXrfF7cdTC7saf6sdV12VJG38PAcW24sMUi4eh0PbBh+EYlEtemZKzGufjuQUPU9 Jj8QhXRJnwW4F5jc6Vd1oHmlHXTsx8Gibt47ygquV3UX20bhPQPOK582Scuviuocfh4G W5ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=; b=QwrETdBXdo1ESYgFLuxF9iru87roFXQXPr+65Cp4zKladYK27F+J6flnACQGsdO74w 9X7ULXzuYnNNBsKY57tXzQLjhtclxwJLUP7t9NCsiRkCvyERJkm1SxjfKac/rsMsWjbL N6gm+R7RpytV03DkXz1IDieXyF6LlV6eEzwFwIEdc1FtcIMo3foYU8kY8r45+gxGOZfl 38DQnySUn1D/LyxC0t4LCKUbmyG4HUrxgsDa0pDzxCY3Y5DIEkvmyrwcFCB5Z+psc909 yyFuibcDFoYSqpvuvS/IyGT7pxnTcWJ9fwwgAPXDAhqYFFDhL1hustmef3iTQ7oBr3F2 C8Tw== X-Gm-Message-State: AOAM532idK1+R/OaKtr/9LeBzFnrgbBQRuk0Eb1SCxta6LA8OuyT1GNE PP7BbMAvSSUvPGk09QMPCQo+8NWZbkyf6w== X-Google-Smtp-Source: ABdhPJzF66pZ9vlWw/d8U0e6CapAefqWpJLVoy7sTVvhrn3RV9EmSKCSOHlnrOynEB3fgkWVTP2mug== X-Received: by 2002:a05:600c:414e:: with SMTP id h14mr14296194wmm.2.1600422237108; Fri, 18 Sep 2020 02:43:57 -0700 (PDT) Received: from naushir-VirtualBox.pitowers.org ([2a00:1098:3142:14:a00:27ff:fe4d:f6a2]) by smtp.gmail.com with ESMTPSA id n2sm4792472wma.29.2020.09.18.02.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 02:43:56 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Sep 2020 10:42:24 +0100 Message-Id: <20200918094233.5273-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918094233.5273-1-naush@raspberrypi.com> References: <20200918094233.5273-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v8 03/12] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Tested-by: David Plowman --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 4c878003..f15345ea 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1162,6 +1162,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1464,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;