From patchwork Tue Apr 9 19:25:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 963 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 50FE660DBD for ; Tue, 9 Apr 2019 21:25:10 +0200 (CEST) Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id D6FF4200008; Tue, 9 Apr 2019 19:25:09 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Tue, 9 Apr 2019 21:25:44 +0200 Message-Id: <20190409192548.20325-9-jacopo@jmondi.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190409192548.20325-1-jacopo@jmondi.org> References: <20190409192548.20325-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 08/12] libcamera: camera: Refuse empty requests X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 19:25:12 -0000 Requests that do not contain any Stream should not be forwarded to the pipeline handlers. Return -EINVAL if the request does not contain any Stream to capture from. Signed-off-by: Jacopo Mondi --- src/libcamera/camera.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index cb392ca3b7e7..bd73ff69c3da 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -728,6 +728,7 @@ Request *Camera::createRequest() * \return 0 on success or a negative error code otherwise * \retval -ENODEV The camera has been disconnected from the system * \retval -EACCES The camera is not running so requests can't be queued + * \retval -EINVAL The request does not contain any stream to capture from */ int Camera::queueRequest(Request *request) { @@ -743,6 +744,9 @@ int Camera::queueRequest(Request *request) return ret; } + if (request->empty()) + return -EINVAL; + return pipe_->queueRequest(this, request); }