From patchwork Fri Sep 11 16:20:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 9575 X-Patchwork-Delegate: jacopo@jmondi.org Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A7173BDB1D for ; Fri, 11 Sep 2020 16:16:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8058162DF5; Fri, 11 Sep 2020 18:16:58 +0200 (CEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DF75460534 for ; Fri, 11 Sep 2020 18:16:56 +0200 (CEST) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 00FCA240006; Fri, 11 Sep 2020 16:16:55 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Fri, 11 Sep 2020 18:20:35 +0200 Message-Id: <20200911162039.61933-3-jacopo@jmondi.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911162039.61933-1-jacopo@jmondi.org> References: <20200911162039.61933-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC 2/6] libcamera: property_ids: Define draft properties X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hanlinchen@chromium.org Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Libcamera is in the process of defining its own set of properties, to advertise the camera capabilities. To temporary close the gap in the Android camera HAL and support all static metadata required in the LIMITED hw level, define a set of Draft properties whose values are taken from their Android definition, in order to allow pipeline handlers to support Android. Signed-off-by: Jacopo Mondi Reviewed-by: Niklas Söderlund --- src/libcamera/property_ids.yaml | 70 +++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 74ad0195d631..62bed9f3844d 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -640,4 +640,74 @@ controls: \todo Rename this property to ActiveAreas once we will have property categories (i.e. Properties::PixelArray::ActiveAreas) + - DraftAvailableNoiseReductionModes: + type: int32_t + size: [n] + description: | + Draft property to report the list of supported noise reduction modes. + Currently identical to + ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES. + enum: + - name: DRAFT_NOISE_REDUCTION_MODE_OFF + value: 0 + description: No noise reduction is applied + - name: DRAFT_NOISE_REDUCTION_MODE_FAST + value: 1 + description: | + Noise reduction is applied without reducing the frame rate. + - name: DRAFT_NOISE_REDUCTION_MODE_HIGH_QUALITY + value: 2 + description: | + High quality noise reduction at the expense of frame rate. + - name: DRAFT_NOISE_REDUCTION_MODE_MINIMAL + value: 3 + description: | + Minimal noise reduction is applied without reducing the frame rate. + - name: DRAFT_NOISE_REDUCTION_MODE_ZSL + value: 4 + description: | + Noise reduction is applied at different levels to different streams. + + - DraftAvailableColorCorrectionAberrationModes: + type: int32_t + size: [n] + description: | + Draft property to report the list of supported color correction + aberration modes. Currently identical to + ANDROID_COLOR_CORRECTION_AVAILABLE_ABERRATION_MODES. + enum: + - name: DRAFT_COLOR_CORRECTION_ABERRATION_OFF + value: 0 + description: No aberration correction is applied. + - name: DRAFT_COLOR_CORRECTION_ABERRATION_FAST + value: 1 + description: Aberration correction will not slow down the frame rate. + - name: DRAFT_COLOR_CORRECTION_ABERRATION_HIGH_QUALITY + value: 2 + description: | + High quality aberration correction which might reduce the frame + rate. + + - DraftAvailableLensShadingMapModes: + type: int32_t + size: [n] + description: | + Draft property to report the list of supported lens shading map modes. + Currently identical to + ANDROID_STATISTICS_INFO_AVAILABLE_LENS_SHADING_MAP_MODES. + enum: + - name: DRAFT_LENS_SHADING_MAP_MODE_OFF + value: 0 + description: No lens shading map mode is available. + - name: DRAFT_LENS_SHADING_MAP_MODE_ON + value: 1 + description: The lens shading map mode is available. + + - DraftPipelineMaxDepth: + type: int32_t + description: | + Draft control to report the maximum number of pipeline stages a frame + has to go through from when it is exposed to when it is available to + applications. Currently identical to ANDROID_REQUEST_PIPELINE_MAX_DEPTH. + ...