From patchwork Tue Sep 8 07:49:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 9519 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 773EABDB1C for ; Tue, 8 Sep 2020 07:49:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EEFA362C01; Tue, 8 Sep 2020 09:49:22 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="RPpVGnLH"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A1AC262931 for ; Tue, 8 Sep 2020 09:49:21 +0200 (CEST) Received: by mail-wm1-x343.google.com with SMTP id b79so16132342wmb.4 for ; Tue, 08 Sep 2020 00:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=; b=RPpVGnLHnwjNVgW5lQ8QI0Xj8zAdQdLY8BbrhJ2Fim4zZsIjIspx/DtCWRTSYqAWkJ iY1pUYt+XT3EVsiydR8qWxfj6mi+aHZfd6iYWrpupCvUTtPy8DQe+zCjHhLNReugqMlW 6gn/eESoeKRhqGZCkmX+7o+IFthJm6/Eb+d/JHvx69wQYOxC/BVP3gSEa4GE7X8hxo5N EiRUfdxhuNxwsxa+nMtwB7ADYV/UbzJ5Fr/WnRsltXa1HtjJ8V9DBzP/H73UtBiuGei4 uaSOq2P5idSfRGXyRJckyBawL2Wj6XieadBsYqCgUgsZpWGhFsj+0xTy2RpDFtrYU9yX 2WCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=; b=kKBxyV5jJQ9lcUjTV1K4LRHospTYilLLP66joq5aMEZrAC3rvl6uvwAlQtG5kzOJWo 08BH7ne8WYftIqncBXvUOJIB9GQIDylEpfks4ePzGtS7TbnoqZlHJNs+/85gTORPEp2E JvAL9huS413DWVUc0EbQ0ndwddLvE/JY/f3npOwIeelXubVBtd4QDR3/5zatSGw9Ciie DZHQFCLPxgtpe6pGq74kxoeniuhiTngpL07d6gu4hdZ8X0VDirJz0EvclnYRgNfINehf 2DvMIZTb9BLqYOEyaOqCK1fJFrIW8hk8Re6hdQ8mZoJqaXqpMqu5B/NVBXOT6KQIuYyF OlEg== X-Gm-Message-State: AOAM533EKb/H1W1VGm+AGPh50Sp8G8WvHXmxWjc0QtMF4REXcZOqoX/L OMGnzaBSkiK0QGBo2frcmImeGCPgZ9buLg== X-Google-Smtp-Source: ABdhPJxqg3KhnoF5g1Ljl+P7o6u2Chz+i3zBjtU21OA2TUuw5uA7N1sAtDkYYm3AjJAARWlC3LHjgQ== X-Received: by 2002:a7b:c210:: with SMTP id x16mr2890062wmi.76.1599551361089; Tue, 08 Sep 2020 00:49:21 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id q15sm32534502wrr.8.2020.09.08.00.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 00:49:20 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 8 Sep 2020 08:49:03 +0100 Message-Id: <20200908074913.109244-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200908074913.109244-1-naush@raspberrypi.com> References: <20200908074913.109244-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v7 03/12] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Tested-by: David Plowman --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 4c878003..f15345ea 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1162,6 +1162,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1464,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;