From patchwork Thu Aug 27 08:20:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 9405 X-Patchwork-Delegate: jacopo@jmondi.org Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7A575BDC71 for ; Thu, 27 Aug 2020 08:17:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 58BCE62901; Thu, 27 Aug 2020 10:17:02 +0200 (CEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F18E060379 for ; Thu, 27 Aug 2020 10:16:59 +0200 (CEST) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 41B6E24000A; Thu, 27 Aug 2020 08:16:59 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org, Dave Stevenson , Naushir Patuck Date: Thu, 27 Aug 2020 10:20:37 +0200 Message-Id: <20200827082038.40758-3-jacopo@jmondi.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200827082038.40758-1-jacopo@jmondi.org> References: <20200827082038.40758-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] libcamera: raspberrypi: dma_heaps: Be verbose on errors X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Be a tad more verbose on failures in opening the dma_heaps allocator devices. Signed-off-by: Jacopo Mondi --- src/libcamera/pipeline/raspberrypi/dma_heaps.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/dma_heaps.cpp b/src/libcamera/pipeline/raspberrypi/dma_heaps.cpp index 739f05d3d4d8..500f1eac2eb8 100644 --- a/src/libcamera/pipeline/raspberrypi/dma_heaps.cpp +++ b/src/libcamera/pipeline/raspberrypi/dma_heaps.cpp @@ -45,9 +45,14 @@ int DmaHeap::open() { dmaHeapHandle_ = ::open(DMA_HEAP_CMA_NAME, O_RDWR, 0); if (dmaHeapHandle_ == -1) { + LOG(RPI, Error) << "Could not open dmaHeap device " + << DMA_HEAP_CMA_NAME << ": " + << strerror(errno); dmaHeapHandle_ = ::open(DMA_HEAP_CMA_ALT_NAME, O_RDWR, 0); if (dmaHeapHandle_ == -1) { - LOG(RPI, Error) << "Could not open dmaHeap device"; + LOG(RPI, Error) << "Could not open dmaHeap device " + << DMA_HEAP_CMA_ALT_NAME << ": " + << strerror(errno); return dmaHeapHandle_; } }