From patchwork Sat Aug 22 16:05:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 9365 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 993D6BE173 for ; Sat, 22 Aug 2020 16:05:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 206EE62710; Sat, 22 Aug 2020 18:05:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="oskF9VeC"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F7E061EA0 for ; Sat, 22 Aug 2020 18:05:25 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F2E1B29E for ; Sat, 22 Aug 2020 18:05:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1598112325; bh=MoHyDFt04e/W1Yqce1hHZPqK2GuJz8uEi+ZrEZWajUo=; h=From:To:Subject:Date:From; b=oskF9VeCL6ikubHYrFLX6F8M4zl9Y0oicX9QCB+ElyOdtJB0zSyfyNjHKSmKZzYFo BWtM3+ufcfkRU1F/x+lNfF2OSh9SyGaWx81j+kIuSaULNRo+OOUckXNWSLa4NF5PqT pDiqa7c3tIIOdgtRwAy9kdFGUOLN7dheFifbnoIU= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sat, 22 Aug 2020 19:05:02 +0300 Message-Id: <20200822160502.11932-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: Remove void specifier for functions that take no arguments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In C++, unlike in C, a function that takes no argument doesn't need to specify void in the arguments list. Drop the unnecessary specifiers. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Niklas Söderlund --- include/libcamera/internal/ipa_module.h | 2 +- src/android/camera3_hal.cpp | 2 +- src/gstreamer/gstlibcameraallocator.cpp | 2 +- src/gstreamer/gstlibcamerapad.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h index 6355671fd861..c2df2476b2ff 100644 --- a/include/libcamera/internal/ipa_module.h +++ b/include/libcamera/internal/ipa_module.h @@ -52,7 +52,7 @@ private: bool loaded_; void *dlHandle_; - typedef struct ipa_context *(*IPAIntfFactory)(void); + typedef struct ipa_context *(*IPAIntfFactory)(); IPAIntfFactory ipaCreate_; }; diff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp index 716e36c72b83..decaf59e6915 100644 --- a/src/android/camera3_hal.cpp +++ b/src/android/camera3_hal.cpp @@ -22,7 +22,7 @@ static CameraHalManager cameraManager; * Android Camera HAL callbacks */ -static int hal_get_number_of_cameras(void) +static int hal_get_number_of_cameras() { return cameraManager.numCameras(); } diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp index 1d5959c076cb..78ded4022bda 100644 --- a/src/gstreamer/gstlibcameraallocator.cpp +++ b/src/gstreamer/gstlibcameraallocator.cpp @@ -70,7 +70,7 @@ FrameWrap::~FrameWrap() } } -GQuark FrameWrap::getQuark(void) +GQuark FrameWrap::getQuark() { static gsize frame_quark = 0; diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp index e184495aed5a..9f3e2be53b66 100644 --- a/src/gstreamer/gstlibcamerapad.cpp +++ b/src/gstreamer/gstlibcamerapad.cpp @@ -84,7 +84,7 @@ gst_libcamera_pad_init(GstLibcameraPad *self) } static GType -gst_libcamera_stream_role_get_type(void) +gst_libcamera_stream_role_get_type() { static GType type = 0; static const GEnumValue values[] = {