From patchwork Tue Aug 4 21:47:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 9203 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A04A1BD87A for ; Tue, 4 Aug 2020 21:47:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6E2E3605AB; Tue, 4 Aug 2020 23:47:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p3PyiuAC"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7415C6055E for ; Tue, 4 Aug 2020 23:47:20 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F2D6AD5F; Tue, 4 Aug 2020 23:47:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1596577640; bh=xSWyxn4rUgI7fXZbQWv7uKbOnOr9mMB61KLdspvcDKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p3PyiuACI98b3n7LD4lihjm+2kgNQjDx5z3kaLhXDzXBRfnCJo/3JOwOt3oOzqCGn N3wCA1LaDqa0c0KNj11TTJE5QdKW7Izpu+hOFpoB7/jZANxuRPEY2sl4Mgku05Ix7i za6J7mruq/udBxwdSxn6L3px1GLolc3M6Yb4D9rs= From: Kieran Bingham To: libcamera devel Date: Tue, 4 Aug 2020 22:47:08 +0100 Message-Id: <20200804214711.177645-11-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200804214711.177645-1-kieran.bingham@ideasonboard.com> References: <20200804214711.177645-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 10/13] android: camera_device: Report configuration changes from validate() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When we call validate on a configuration, if there are any adjustments on the configuration, we fail without showing why. Display the stream configuration after the validate stage to aid debugging stream startup failures. Reviewed-by: Jacopo Mondi Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/android/camera_device.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 5899154b3e78..4178db952846 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1047,7 +1047,11 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) case CameraConfiguration::Valid: break; case CameraConfiguration::Adjusted: - LOG(HAL, Info) << "Camera configuration adjusted"; + LOG(HAL, Info) << "Camera configuration adjusted:"; + + for (const StreamConfiguration &cfg : *config_) + LOG(HAL, Info) << " : " << cfg.toString(); + config_.reset(); return -EINVAL; case CameraConfiguration::Invalid: