From patchwork Tue Aug 4 09:58:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 9168 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5ED7DBD86F for ; Tue, 4 Aug 2020 09:59:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2A6F16053B; Tue, 4 Aug 2020 11:59:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="KCNgohgf"; dkim-atps=neutral Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BB286053B for ; Tue, 4 Aug 2020 11:58:59 +0200 (CEST) Received: by mail-wr1-x441.google.com with SMTP id f7so36827040wrw.1 for ; Tue, 04 Aug 2020 02:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RplsxPmRs6AHgDVous0OsVaIaGRrWTjjB/MXfVuAQ/A=; b=KCNgohgfiFXajlQatn2OnWepTG+5Ng7BRKa0fXsPi41FehzLFu7lL9La0lVYrFO8B4 PlDdaaoBfcvkpD9uvit4/EDdwCUkoq4Zo8QuDrV//pZectOus67afuZjqX+xXqWmoLaQ AvCEpFjPKu6mrgeUbAmUsQOs+/Lj2VmZC4M4QsLqgzHCZjYDr8VgvsWYM/J6cxzZSZOD hvaW260KtVgVkdQ9aEIyivajALJzwslNCkNob3euVIm5d/PEc3HfZc3biQz6drCVYwJ+ iS/bReHF6u+H0YdmKfdIXoBUP3C0n4c3Qcv1/mHRkh31WAQUu7ibMLGubosgfArUC8uc GLag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RplsxPmRs6AHgDVous0OsVaIaGRrWTjjB/MXfVuAQ/A=; b=ExOAFb0lpt9Mi6ZPEdxBoIqNsRZKIqkwcSADECm6f7eaox9VZzkjRh520+UNbXkgXU bO1d6KjN8/55OzzfxG9EOCmyokJj9uYKoNitMTwGsB2MElcRxu6oP6W09K5Qs1VdC8RX 0zVDOaW2SSYQLJEOwgia0tWp4zl7x6C3LtGcSDjrYFHnrr1iOOGiYGeHs+zT/Cag8gcY fE7vzOmdV3sksmnlGBEYTnjvKsSV2N0Css82IoOm+xSGo6aHf8KopsFwJPpDLrJBR+/G 0iFCJxKKsZUD/llS5n63XzTrOebejMfZ05xUu/bYgwiGYoGqWXm2Rvn0liVw0oRM4RsC tkUg== X-Gm-Message-State: AOAM5331ww+XLBQePa3cA+DVqZWlcHhX1wCu8wdLRhiHmMf4cLXnfDrL ALEFIL2FHnCBpIJv7FKyflpXD3mVMW4M2Q== X-Google-Smtp-Source: ABdhPJx6ezbjHnMhVOtHeGkJCws3VNp5BkrYDgabAvb1XURWc5ucXVgJxPix1tywMt5c9Bcs94O69Q== X-Received: by 2002:a5d:4ecf:: with SMTP id s15mr18883892wrv.202.1596535138773; Tue, 04 Aug 2020 02:58:58 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id 32sm34047234wrh.18.2020.08.04.02.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 02:58:58 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 4 Aug 2020 10:58:41 +0100 Message-Id: <20200804095850.275499-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200804095850.275499-1-naush@raspberrypi.com> References: <20200804095850.275499-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 03/12] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Tested-by: David Plowman --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 8fb9df72..61925033 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1159,6 +1159,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1461,7 +1466,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;