From patchwork Fri Jul 31 18:14:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 9120 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8BFE1BD86F for ; Fri, 31 Jul 2020 18:14:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5B67861F05; Fri, 31 Jul 2020 20:14:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="hCNPizlr"; dkim-atps=neutral Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0010C61EC4 for ; Fri, 31 Jul 2020 20:14:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type; s=s1; bh=NvQR2ANfhOQyi9uIxHO5g1eCTnq0d+ZTD9G6Z/jGmKw=; b=hCNPizlrJPese6Osax1/gxvqLNvVbn0o0n7rciWPwz4EHqTC9yMAbjKTBMKrcvmJ/R7a Y8rXyy3uQD3j1vqXZ00UfrRul3hOzO6p0slgzycfBg2YeotMlhmDjTn1qWlej5QNlRZCtg QRNgwZXIS2RfboJTpE48CKtbTXY6KCPPs= Received: by filterdrecv-p3mdw1-7ff865655c-m2ckz with SMTP id filterdrecv-p3mdw1-7ff865655c-m2ckz-20-5F245F77-47 2020-07-31 18:14:15.646199566 +0000 UTC m=+172684.635387381 Received: from mail.uajain.com (unknown) by ismtpd0005p1maa1.sendgrid.net (SG) with ESMTP id 5LQm0FZoQ56T9x1aD4Aydw Fri, 31 Jul 2020 18:14:15.239 +0000 (UTC) From: Umang Jain Date: Fri, 31 Jul 2020 18:14:15 +0000 (UTC) Message-Id: <20200731181410.99892-3-email@uajain.com> In-Reply-To: <20200731181410.99892-1-email@uajain.com> References: <20200731181410.99892-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcmGfnt8UlNcpPI7X/q8AWBi0v4Civ+FFQmNRO4Zj+oWM8hGsXYLVNiWbylcZ780/PZSeuusaZyomJpP7/PvNWCtjhswoxWfpLA1dMJt9DMjzql+u6oCVgF72I80PAY69WnwlawU/CxuOF1B3y5NLrE/sXc8UPCptud392e8wTQeuvgyZpYmE6aVFaMu7tSmYQdR7o0zB+CObjnfR+/6U2Vw== To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH v4 2/4] libcamera: object: Add deleteLater() support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This commit adds support to schedule the deletion of an Object to the thread it is bound to (similar to [1]). An Object getting destroyed by a different thread is considered as a violation as per the libcamera threading model. This will be useful for an Object where its ownership is shared via shared pointers in different threads. If the thread which drops the last reference of the Object is a different thread, the destructors get called in that particular thread, not the one Object is bound to. Hence, in order to resolve this kind of situation, the creation of shared pointer can be accompanied by a custom deleter which in turns use deleteLater() to ensure the Object is destroyed in its own thread. [1] https://doc.qt.io/qt-5/qobject.html#deleteLater Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart --- include/libcamera/internal/message.h | 1 + include/libcamera/object.h | 2 ++ src/libcamera/message.cpp | 2 ++ src/libcamera/object.cpp | 48 ++++++++++++++++++++++++++++ 4 files changed, 53 insertions(+) diff --git a/include/libcamera/internal/message.h b/include/libcamera/internal/message.h index 92ea64a..f1b133b 100644 --- a/include/libcamera/internal/message.h +++ b/include/libcamera/internal/message.h @@ -25,6 +25,7 @@ public: None = 0, InvokeMessage = 1, ThreadMoveMessage = 2, + DeferredDelete = 3, UserMessage = 1000, }; diff --git a/include/libcamera/object.h b/include/libcamera/object.h index 9a3dd07..a1882f0 100644 --- a/include/libcamera/object.h +++ b/include/libcamera/object.h @@ -27,6 +27,8 @@ public: Object(Object *parent = nullptr); virtual ~Object(); + void deleteLater(); + void postMessage(std::unique_ptr msg); templateparent_ = nullptr; } +/** + * \brief Schedule deletion of the instance in the thread it belongs to + * + * This function schedules deletion of the Object when control returns to the + * event loop that the object belongs to. This ensures the object is destroyed + * from the right context, as required by the libcamera threading model. + * + * If this function is called before the thread's event loop is started, the + * object will be deleted when the event loop starts. + * + * Deferred deletion can be used to control the destruction context with shared + * pointers. An object managed with shared pointers is deleted when the last + * reference is destroyed, which makes difficult to ensure through software + * design which context the deletion will take place in. With a custom deleter + * for the shared pointer using deleteLater(), the deletion can be guaranteed to + * happen in the thread the object is bound to. + * + * \code{.cpp} + * std::shared_ptr createObject() + * { + * struct Deleter : std::default_delete { + * void operator()(MyObject *obj) + * { + * delete obj; + * } + * }; + * + * MyObject *obj = new MyObject(); + * + * return std::shared_ptr(obj, Deleter()); + * } + * \endcode + * + * \context This function is \threadsafe. + */ +void Object::deleteLater() +{ + postMessage(std::make_unique(Message::DeferredDelete)); +} + /** * \brief Post a message to the object's thread * \param[in] msg The message @@ -144,6 +188,10 @@ void Object::message(Message *msg) break; } + case Message::DeferredDelete: + delete this; + break; + default: break; }