From patchwork Fri Jul 31 14:07:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 9092 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 18690BD86F for ; Fri, 31 Jul 2020 14:08:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D824A61ED2; Fri, 31 Jul 2020 16:08:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="ArUzHbxB"; dkim-atps=neutral Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A38C61EA4 for ; Fri, 31 Jul 2020 16:08:08 +0200 (CEST) Received: by mail-wr1-x442.google.com with SMTP id z18so24567021wrm.12 for ; Fri, 31 Jul 2020 07:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=; b=ArUzHbxB6oQpKl+h8z4DulkUc3SOFVXGCUIBG2bVMkXn7kaaFIB5jeJswU22YGgr9z fT0zcyl9U1DK/kah1wYn+LF6c8+xa8Sc+k854dYaAiXtQw04r/HZOUe7y/Y+ApQkiXYO gkvqFaBT0eH5PdoXYMN3KhRN72m7i1OlFZoL8uoTtZuczxy4rm12OmDrOk2Ymh+YhEzc tBMevtvljMlQ478IqH9r5tDYSIZHc4sK624mJU4RJiG6ahH1ZU2vh9Qf2h9solkO+wLg FDdK/lrpM/381A0sz7cTe6n8m0fQmsxvrl8o6xQV773JUNWtGSne115fOVUMeVi0pppa AzYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=; b=bkvOLtO8eUL50eMzDyuYF9nzbEUzDMZW/s9EONbcI/xUOrjlbd0EeMdSGtSl7EQnAl aSz5apMhuoGLENtT+QP3+5GCnbC3zgghI90CII551wa43OxSI6dSKJojqb8VHG4K0Lxc paUNEvE4gfFq8+ec6ptLynspFB7ZGSlqqDrRiqMbNpXH2cHfqWdKVDkAkd1jO/vicVPM Z5BzcBUC6NoFBgZCZ1qTIN2lu64pT8Vloov50vn4qYbvupzck1fiICTrGGKrSbfytjQr uRsBGjLMv8axgxt7G2F4KvzDJlcYslO5sHf2atzuP7tT9hWOYVnodzgSMEXP0lP7kaOH lTxw== X-Gm-Message-State: AOAM532hsqI9rttkebB+4kGD5zWZMpZcrjYXJe8FD2bGCDUBc/2OTLAL qDIZ193UausUmS6BWyXF+2bK7P2Si39s0A== X-Google-Smtp-Source: ABdhPJyu2ywM2sC4OSYY5uctd3pHWL0SI/1GRgaHVmJupifdzPTg319VOkc2U9v84mTGhpVQTAvdOw== X-Received: by 2002:a5d:4a41:: with SMTP id v1mr4032378wrs.371.1596204487646; Fri, 31 Jul 2020 07:08:07 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id g126sm12815084wme.16.2020.07.31.07.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 07:08:07 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 31 Jul 2020 15:07:58 +0100 Message-Id: <20200731140801.13253-2-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200731140801.13253-1-david.plowman@raspberrypi.com> References: <20200731140801.13253-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/4] libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be atomic X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In the libcamera framework, SwitchMode (which overwrites the camera_mode) cannot run concurrently with Prepare (which uses it). Signed-off-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp index 3806257..e895913 100644 --- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp +++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp @@ -59,7 +59,7 @@ private: // configuration is read-only, and available to both threads AlscConfig config_; bool first_time_; - std::atomic camera_mode_; + CameraMode camera_mode_; std::thread async_thread_; void asyncFunc(); // asynchronous thread function std::mutex mutex_;