From patchwork Thu Jul 30 11:11:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 9079 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6C1C8BD878 for ; Thu, 30 Jul 2020 11:11:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 365FC61DC3; Thu, 30 Jul 2020 13:11:44 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="corUk9et"; dkim-atps=neutral Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DA1B2605B2 for ; Thu, 30 Jul 2020 13:11:40 +0200 (CEST) Received: by mail-wr1-x443.google.com with SMTP id a14so24519753wra.5 for ; Thu, 30 Jul 2020 04:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/vU50YwdRbjN/X7IPem/bDcMy210W4lUqKwV06EiTB8=; b=corUk9et8Ftl991qFarTB8UCL8wd6vVoPy3DvxYzB30top7FUqpjYD2+S0/V8ErqZK 1w8Kf9GQKhAcxXyilqjOZ8evNIhWZYUy2327/aZDuuhX1YLuiUtwTRaHNS1vAguAYJoc s+KSMv0fIgRqKhvsDGs1smv1jzsrMEaoSgINdruAIp+PRtnqvqXOTZwVeDcSQkmyXTHL 0Y+Ahd0VF6UTAqTfktbJNzu2EqYTzr7TLNAyRW1dxCK9PwEyTlei4JM5+C/eZXi/VFeI mnnR4xHG3djM4/YbgqvHtJmnkvTUHzpZnpXbSV5Kw1VkVe3Tygqll97fOVGWYH3RPckC Fm9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/vU50YwdRbjN/X7IPem/bDcMy210W4lUqKwV06EiTB8=; b=BgFFsOT0J0pgDgFanpKrCIcGppnZW8VXf2IbRC1hLsjTbq0xCMoBeNLl/CRXl5tVe6 bJe65R9caKRZIr2L/vcB2KwM+E5IMMCzLbs3wjRsrR34urxqLtQhfyZY0QuzNM15hgWS 2+ZVTJypcOcgj/xPBopCdzQx9PKAdfnVwn/Isl8z4PbLEHKadj4MzL17o+lETXfQez4N d+QYGVesBiG5BPgttUU57etVYyTAkeAMbZwJEBIkdtax6W2hlCCSYU9TACCayIiaZDsY lX8NdGFfVXy9bUYCLHe6RHGwEBX001RW9Vj8eSkK/bh95/CO82Y0Hp73qmhx/Jpm6FN8 zD6w== X-Gm-Message-State: AOAM531JS6Kaj/E3BXk8skDCppYJKNrsNBGP9HW7joWFGfX3uy/D3hZt c8pm2gAkAoR3vxVRltj3vG3zO9bH2pX0vg== X-Google-Smtp-Source: ABdhPJx07B9bgznzQly7gpWk2iQZjQhHQezpqRSzL2FxVZvxRgdvMhP3eBTWpIj9D9J4v+v3BmwADw== X-Received: by 2002:adf:ee51:: with SMTP id w17mr35193322wro.239.1596107500350; Thu, 30 Jul 2020 04:11:40 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id l10sm9526651wru.3.2020.07.30.04.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 04:11:39 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 30 Jul 2020 12:11:32 +0100 Message-Id: <20200730111134.641-2-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200730111134.641-1-david.plowman@raspberrypi.com> References: <20200730111134.641-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be atomic X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In the libcamera framework, SwitchMode (which overwrites the camera_mode) cannot run concurrently with Prepare (which uses it). Signed-off-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp index 3806257..e895913 100644 --- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp +++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp @@ -59,7 +59,7 @@ private: // configuration is read-only, and available to both threads AlscConfig config_; bool first_time_; - std::atomic camera_mode_; + CameraMode camera_mode_; std::thread async_thread_; void asyncFunc(); // asynchronous thread function std::mutex mutex_;