From patchwork Mon Jul 27 18:57:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 9033 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 701D7BD86F for ; Mon, 27 Jul 2020 18:57:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F363D6118A; Mon, 27 Jul 2020 20:57:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hU7mQ5qf"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C7852605B2 for ; Mon, 27 Jul 2020 20:57:45 +0200 (CEST) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2325B556 for ; Mon, 27 Jul 2020 20:57:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1595876263; bh=pN9sdjXSCdkQ7vypmHaoV6lxfn0YKcNdLbBo6TinKcc=; h=From:To:Subject:Date:From; b=hU7mQ5qfCF9eB6vqLTXkbVO//qsVFmrAp6xDRLjz3lB5vut6o/L+11szkXCRdCBFI YU23X/3R5qi1iWROy1hz8ckI1KPEMfxS0pP8tKjB0kYWYBONcde7iqTy4oC8HwANQm Tqj6+sFBajSljJ/O215deSvhrGFxmVKeH+G78H1Q= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Mon, 27 Jul 2020 21:57:31 +0300 Message-Id: <20200727185731.21618-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] test: Remove list-cameras test X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The list-cameras test case is the very first test case that has been added to libcamera. It has served to start the development of the unit tests infrastructure. Since then, libcamera has grown several tests that cover the same API, and more. It's time for list-cameras to retire. Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Niklas Söderlund --- test/list-cameras.cpp | 54 ------------------------------------------- test/meson.build | 1 - 2 files changed, 55 deletions(-) delete mode 100644 test/list-cameras.cpp diff --git a/test/list-cameras.cpp b/test/list-cameras.cpp deleted file mode 100644 index e6a407aca7f8..000000000000 --- a/test/list-cameras.cpp +++ /dev/null @@ -1,54 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* - * Copyright (C) 2018, Google Inc. - * - * list.cpp - camera list tests - */ - -#include - -#include -#include - -#include "test.h" - -using namespace std; -using namespace libcamera; - -class ListTest : public Test -{ -protected: - int init() - { - cm_ = new CameraManager(); - if (cm_->start()) { - std::cout << "Failed to start camera" << std::endl; - return TestFail; - } - - return 0; - } - - int run() - { - unsigned int count = 0; - - for (const std::shared_ptr &camera : cm_->cameras()) { - cout << "- " << camera->name() << endl; - count++; - } - - return count ? 0 : -ENODEV; - } - - void cleanup() - { - cm_->stop(); - delete cm_; - } - -private: - CameraManager *cm_; -}; - -TEST_REGISTER(ListTest) diff --git a/test/meson.build b/test/meson.build index f41d6e740e6a..c0fb9bdfac17 100644 --- a/test/meson.build +++ b/test/meson.build @@ -18,7 +18,6 @@ subdir('v4l2_videodevice') public_tests = [ ['geometry', 'geometry.cpp'], - ['list-cameras', 'list-cameras.cpp'], ['signal', 'signal.cpp'], ['span', 'span.cpp'], ]