From patchwork Fri Jul 24 14:21:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 8971 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7A9A0BD879 for ; Fri, 24 Jul 2020 14:17:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 35DCA611B4; Fri, 24 Jul 2020 16:17:52 +0200 (CEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DAD760535 for ; Fri, 24 Jul 2020 16:17:50 +0200 (CEST) X-Originating-IP: 2.224.242.101 Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 6A35E60003; Fri, 24 Jul 2020 14:17:49 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Fri, 24 Jul 2020 16:21:17 +0200 Message-Id: <20200724142120.95538-4-jacopo@jmondi.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200724142120.95538-1-jacopo@jmondi.org> References: <20200724142120.95538-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/6] andrdid: camera_device: Store const templates X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The request capture templates stored in the CameraDevice::requestTemplates_ should not be modified once created. Store a const reference to the request templates in the class member map. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/android/camera_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/camera_device.h b/src/android/camera_device.h index 5b8b9c3e26e2..af1b58ab6b4e 100644 --- a/src/android/camera_device.h +++ b/src/android/camera_device.h @@ -95,7 +95,7 @@ private: std::unique_ptr config_; CameraMetadata *staticMetadata_; - std::map requestTemplates_; + std::map requestTemplates_; const camera3_callback_ops_t *callbacks_; std::vector streamConfigurations_;