From patchwork Mon Jul 20 22:48:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 8901 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C53D1BD792 for ; Mon, 20 Jul 2020 22:48:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 56FF360554; Tue, 21 Jul 2020 00:48:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KWfYJ1fa"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 249C860540 for ; Tue, 21 Jul 2020 00:48:37 +0200 (CEST) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8796E2A4; Tue, 21 Jul 2020 00:48:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1595285316; bh=pll7/XDG+WJpC6EQf4Ax0CVvPSk41P4waWPrDfks0uQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KWfYJ1faS3W9JSqJ4lclqpeJlsX0PgzYhsOkoQW2zIppWyhR9YU2SheqUxyFaRzZD K10NIHgrWgsSzCx1Ee7GJ8eS/vn8gGSBSk7uXhT7FD0TyiVh22TKL1mrLCYjImZ0qh XTU05EF2K+kVZrLO+ggc5Zc4Lpiq4ISQUnraceFs= From: Kieran Bingham To: libcamera devel Date: Mon, 20 Jul 2020 23:48:32 +0100 Message-Id: <20200720224832.154442-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200720224232.153717-7-kieran.bingham@ideasonboard.com> References: <20200720224232.153717-7-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH v2 6/8] android: camera_device: Only construct required planes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The camera3buffer describes the number of filedescriptors given. Don't try to construct more planes than that. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v2: - cleanly skip planes with no given file descriptor (set to -1) - Clean up the error handling and reporting if the FileDescriptor failes to dup. src/android/camera_device.cpp | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index e5c50084e590..610c54d45eb9 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1033,9 +1033,20 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer) { std::vector planes; - for (unsigned int i = 0; i < 3; i++) { + for (int i = 0; i < camera3buffer->numFds; i++) { + /* Skip unused planes. */ + if (camera3buffer->data[i] == -1) + continue; + FrameBuffer::Plane plane; plane.fd = FileDescriptor(camera3buffer->data[i]); + if (!plane.fd.isValid()) { + LOG(HAL, Error) << "Failed to obtain FileDescriptor (" + << camera3buffer->data[i] << ") " + << " on plane " << i; + continue; + } + /* * Setting length to zero here is OK as the length is only used * to map the memory of the plane. Libcamera do not need to poke