From patchwork Mon Jul 20 09:13:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 8865 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0C57FC2E67 for ; Mon, 20 Jul 2020 09:13:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4AFC860724; Mon, 20 Jul 2020 11:13:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="hMsxiGef"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BB8A60554 for ; Mon, 20 Jul 2020 11:13:30 +0200 (CEST) Received: by mail-wm1-x343.google.com with SMTP id j18so21509730wmi.3 for ; Mon, 20 Jul 2020 02:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h2usrW3kOg/PwxnrQi+Bi9R18693ZRttLpAYPr1ayMA=; b=hMsxiGefJL63ssdh0NoTVjQT6h80uttSozroJAHfsBNVzlO7TCsBP5qz/BXJ7I95TQ UPKqroXUOQe+pQxdhFg6D6zmpNr/SkBo3GTwBPuJcBym3JBM6gdntPZFnx6PWekzA2L5 c+wsIMh1WRAs5DcuswPhu+mIXirvVTd2iVcJxPFyst4BGPCDh7D1kCkTwLtuDeb6CokP nyGoJ98oquz8iWFDFvBo2HKq+nak2uFaUfjgpJsYC13KreRejNq5xt+YRhrAO3ZX1mpH 0VzEk+dFhauJ97reHSjcABeMzCG/R/WajPjPlhTj1tmCoNf6QrPNCcIWTsIppPoztxv7 Y+Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h2usrW3kOg/PwxnrQi+Bi9R18693ZRttLpAYPr1ayMA=; b=aqPV63x4RnLDyR9McmN9yBb7dH0vuEvKisGQrAoFSkqBAn7wBhvoLMAUwQBWzVcIFq YoPMxV4+1lddDusOdLo96D3Vz8BCGC7PQQ1U+tp8VhQIfrFuX+FZGkJYzglDjB3/imIE p2rNpuVTc4ZjFeSz7iekPF4tVx4LeTL0tByyuPg+BxuQQ+6KDwv2L85OxmrY3gR1g5Ta rDFh1VWU0Nf+C3RFub2233nrIL6jaKfea5o6/GVhAmWRpM6UxxyFJZwruFQs0obnvWhS TLHIQI0MvdzELn6rR/PaPC6/53lh4fQMunPqk9OwSGWNMumr0ZNzHFlUwUNV+X17ufqH 9fPg== X-Gm-Message-State: AOAM533RaRXQJhH9D0yK/FThHAuMuzeyGv+hJg6nPCH43mFVrl2pc1VA jkD66D64XMKPmy71XpPej7nJh6qecvgIIQ== X-Google-Smtp-Source: ABdhPJyctXnzSXmxW85EZyjXMqMxwnKbTYrV+vitzMgCsGQFBywK+tGm0D8hptqwIrEXqvabMk5Y4w== X-Received: by 2002:a1c:a181:: with SMTP id k123mr20861498wme.172.1595236409429; Mon, 20 Jul 2020 02:13:29 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id u1sm38137185wrb.78.2020.07.20.02.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 02:13:28 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 20 Jul 2020 10:13:05 +0100 Message-Id: <20200720091311.805092-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200720091311.805092-1-naush@raspberrypi.com> References: <20200720091311.805092-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 3/9] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index d3639ce1..35f14dda 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1160,6 +1160,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1324,6 +1329,8 @@ void RPiCameraData::checkRequestCompleted() pipe_->completeRequest(camera_, request); requestQueue_.pop_front(); requestCompleted = true; + + LOG(RPI, Debug) << "Request is complete"; } /* @@ -1462,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;