From patchwork Wed Jul 15 14:06:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 8826 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 65216BD790 for ; Wed, 15 Jul 2020 14:07:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1D42D609A0; Wed, 15 Jul 2020 16:07:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="HmfkcLQH"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E0F2609A0 for ; Wed, 15 Jul 2020 16:07:14 +0200 (CEST) Received: by mail-wm1-x343.google.com with SMTP id o8so5730065wmh.4 for ; Wed, 15 Jul 2020 07:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=; b=HmfkcLQHdEDwJiVrvqhalLLTj0rSMA0GuOCQ0ONagN2zXzv/2UqprJ7/l5lS21vAZE qod2cxDe+PFDPzlxx7cgFD4ehrF3m4bqcwIElOyq+cjAcSZzyK6fKqx6vyzB/YbW/N5z 41K4MnM7JztQL230QpFjkI4nfnyGtLxJ8Lv6Xithekp6KNaZAwSIVSo6JmlcS1nZ4bNM 5koI5JpBgGDITz/ZPNH1Z7DvYU8xMx49SkvDMp4OvgeBA5HARpZDf+9ELIHBysb6bRi4 6I+k/ZcivqYxigcgaFjJswif/S0k8JoKSwlqebwNrnKvbWRW12XHTmr1Z2ZoXKnVXxn6 ptBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=; b=YAz8Lhj6b9f1352C7rA5879es6TDAJLTa+7FJHblEc4LCE8x2YoRQLkJqtMSuROC7A Z+qV5/TBnOFMHzjU5ul/0LLNbbgPgAChtiEB9C/DhTzPw3HHWXlR/4hJbw2I4a/n0S+4 ie6HH95DwnN0jT/NCcmYZiEh0rwkB8rDwM3Hnmdfxewkffglt9UYQSGTqiDfiL9aQe3r 7ad3jcXopVAzOGc7JI4uP0EfAfIFRZyPaZdRBWSmXzQ1dSQ/kkwl3hvbhrY88m+SHGM/ ltmcy3IATLjXvSDfoy3dkPa9NS8Bq6VELLfsXFGXoZkL54g0gc++aDNSRDTPdBld/7tm l16w== X-Gm-Message-State: AOAM533XRhd/INvbNDIyYqU5/sfMTeXQ7bgO632jZGHtdseezba+TXOn 8fUUJKeTZVHWgit8yqxi6C6WfrdlwHo= X-Google-Smtp-Source: ABdhPJy56VfZhqA2qVi7nsQOsJb5D1SgplBgCGJcJB12homlac6G0PpCzhc20Q1zVd+P+8dQCTNUDA== X-Received: by 2002:a1c:790c:: with SMTP id l12mr8766811wme.50.1594822033627; Wed, 15 Jul 2020 07:07:13 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id l67sm4195339wml.13.2020.07.15.07.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 07:07:11 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 15 Jul 2020 15:06:56 +0100 Message-Id: <20200715140703.566298-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715140703.566298-1-naush@raspberrypi.com> References: <20200715140703.566298-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 03/10] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 8b6f578f..65c8557d 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1175,6 +1175,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1339,6 +1344,8 @@ void RPiCameraData::checkRequestCompleted() pipe_->completeRequest(camera_, request); requestQueue_.pop_front(); requestCompleted = true; + + LOG(RPI, Debug) << "Request is complete"; } /* @@ -1477,7 +1484,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;