From patchwork Mon Jul 13 08:47:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 8753 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 98F77BD790 for ; Mon, 13 Jul 2020 08:48:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1EC9B605C1; Mon, 13 Jul 2020 10:48:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="ZLaYTAem"; dkim-atps=neutral Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C53D605B9 for ; Mon, 13 Jul 2020 10:48:01 +0200 (CEST) Received: by mail-wr1-x443.google.com with SMTP id f2so14986035wrp.7 for ; Mon, 13 Jul 2020 01:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=; b=ZLaYTAemSo/xfKk3VgEJrWrPfsPaSiIVlnfVQrawlb7gr6vPlmBW1QBGG6YE20jTGh ytM/tzUIwxoHJo20kIZY3k0UbXuK1cTQ8fWUazd5mynGn6OsOm3rL/mbMMCYz8/teriW md9j5N72aF4Y5VZH+UyG9Y2uX7ooLGn/qw0ODfVoqXDV+gce9PKwKgjDSUGqER/w7ayS y7g2dXhiFwCjF54XxlCXYwH9e/XyaAefcOYb6ZAT4XK86Nud8517ayBT2n713gznuxs7 m7EfceM8HlNY/9/4N3R5iCwYJIDve4kGnCobBNm3vZa5Lsu4F97eWhCESIS6Tbi6xvK7 MuDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=; b=DV4k3vN3CRiK9GgvVNSTSPSHDX+tPwKe6eC7UET9DaFn+rdkDM/3B19BLoAS0lEO6y vS8+4NYFwrUVdMEq7m/baHkbJpZOSMDz/k9CvS+a4PN6yXPcskq2na0P7EqbC+esVnH6 ZVX3GrxJqg5+GYmG31UeLcecsJBNPJA62YTA30BFQd7TN2r8cY/5JIolvJ0PVVszPFSk csq2gUkXKofZ5K4XrWp8HdoJRR6wbHOcsIrmoXjGJuLk3+/nP4nG4h3VHp3AAyN8qW1z EWiKw7A7Jwxbbrm/pmHh7oL1fqUq3kQGCIZtwsngbA59CuqyTDaxBQpiMfTMMBuw2Kva 621A== X-Gm-Message-State: AOAM532cF0rHfcaH3k7ABO1KjnfPhYWnoeOHLnwbe0xId3awIT5tLQzl X9XZLXoxJfvDcjLfo0lWQExhZHF1/Ak= X-Google-Smtp-Source: ABdhPJwZy44QySL7ZtEhEmpYxkzqWpdcYpGdZMJWzp+gKsbKKQ0bEI6ifmAb93b9bmNjZyKXRLLOrg== X-Received: by 2002:a5d:5084:: with SMTP id a4mr81230998wrt.191.1594630080378; Mon, 13 Jul 2020 01:48:00 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id g14sm23203357wrm.93.2020.07.13.01.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 01:47:59 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 13 Jul 2020 09:47:22 +0100 Message-Id: <20200713084727.232422-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200713084727.232422-1-naush@raspberrypi.com> References: <20200713084727.232422-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/9] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 8b6f578f..65c8557d 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1175,6 +1175,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1339,6 +1344,8 @@ void RPiCameraData::checkRequestCompleted() pipe_->completeRequest(camera_, request); requestQueue_.pop_front(); requestCompleted = true; + + LOG(RPI, Debug) << "Request is complete"; } /* @@ -1477,7 +1484,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;