From patchwork Thu Jul 9 13:28:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 8734 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 03A71BD792 for ; Thu, 9 Jul 2020 13:29:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C48876124F; Thu, 9 Jul 2020 15:29:37 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eCOLanQJ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C96C8611BA for ; Thu, 9 Jul 2020 15:29:36 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 977099CC; Thu, 9 Jul 2020 15:29:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1594301376; bh=u9MOtYm3vp3VxRbxe4jjmWJ4cEoRr7b/itCNiX0RisU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eCOLanQJn5/KQpYZzwxA5IxPt6bhrfcQNE9gCQGY7TpIJjgiLyS6H6uAlMPUjRMk1 qMsWU8n89l/xT5aFTBsHlqj1zHWIEv0GCXwbxn2h8QDbgH1L/0hXYSzdRSkF/3Ngaf 5P2hBpqXEAl3xLUaO6JQYRqGwEszcuQJ2OJM5Y+k= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Thu, 9 Jul 2020 22:28:31 +0900 Message-Id: <20200709132835.112593-20-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200709132835.112593-1-paul.elder@ideasonboard.com> References: <20200709132835.112593-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 19/23] libcamera: StreamConfiguration: Update stride documentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that all the pipeline handlers fill in the stride information at validation time, update the documentation accordingly. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- No change in v5 No change in v4 New in v3 --- src/libcamera/stream.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp index 6d6e279..d5da834 100644 --- a/src/libcamera/stream.cpp +++ b/src/libcamera/stream.cpp @@ -309,11 +309,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats) * * The stride value reports the number of bytes between the beginning of * successive lines in an image buffer for this stream. The value is - * valid after successfully configuring the camera with this - * configuration with a call to Camera::Configure(). - * - * \todo Update this value when configuration is validated instead of when - * the camera is configured. + * valid after successfully validating the configuration with a call to + * CameraConfiguration::validate(). */ /**