From patchwork Thu Jul 2 21:36:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 8564 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DD510BE905 for ; Thu, 2 Jul 2020 21:37:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9E0F860C59; Thu, 2 Jul 2020 23:37:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PfmaNaLe"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EFB6460C64 for ; Thu, 2 Jul 2020 23:37:05 +0200 (CEST) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 876049CB; Thu, 2 Jul 2020 23:37:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593725825; bh=p3mmoYXL1A+kaLsOv4/KaDG50/FQkOc3w+uf8npORwA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PfmaNaLefmAZwCPvIS9kPCm7F4msXFTq7pxfyy4beiB3LP0NHO8fAUFw08S8W6IEC x+ZGK8rMVQ4OdrK57oPKB+KCToF+8aZJ2lyk7ZlLDeD+G0ezITqUPuzOTyRnFVScge wEN+xT6VmMF2k6T5RJSSUjPYtcBzJtw5S24YmP3o= From: Kieran Bingham To: libcamera devel Date: Thu, 2 Jul 2020 22:36:54 +0100 Message-Id: <20200702213654.2129054-10-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702213654.2129054-1-kieran.bingham@ideasonboard.com> References: <20200702213654.2129054-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 9/9] android: camera_device: Report an error in notifyError() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If an error is generated, try to be verbose about it in the libcamera logs. Signed-off-by: Kieran Bingham Reviewed-by: Niklas Söderlund --- src/android/camera_device.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 4681fd8af90b..5a3b4dfae6a0 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1192,6 +1192,9 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream) { camera3_notify_msg_t notify = {}; + LOG(HAL, Error) << "Error occured on frame " << frameNumber + << toPixelFormat(stream->format); + notify.type = CAMERA3_MSG_ERROR; notify.message.error.error_stream = stream; notify.message.error.frame_number = frameNumber;