From patchwork Sat Jun 27 03:00:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 8446 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2CFB5C2E67 for ; Sat, 27 Jun 2020 03:00:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C551760AFA; Sat, 27 Jun 2020 05:00:54 +0200 (CEST) Received: from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net [195.74.38.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E8FB9609C8 for ; Sat, 27 Jun 2020 05:00:52 +0200 (CEST) X-Halon-ID: 55b301e4-b822-11ea-86ee-0050569116f7 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de [79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA id 55b301e4-b822-11ea-86ee-0050569116f7; Sat, 27 Jun 2020 05:00:19 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Sat, 27 Jun 2020 05:00:34 +0200 Message-Id: <20200627030043.2088585-5-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200627030043.2088585-1-niklas.soderlund@ragnatech.se> References: <20200627030043.2088585-1-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 04/13] libcamera: ipu3: Remove usage of IPU3CameraData from ImgUDevice X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPU3CameraData argument to allocateBuffers() and freeBuffers() is no longer used and can be removed. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/ipu3/ipu3.cpp | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 5a473e18c082cee8..36413a824ebbf564 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -34,8 +34,6 @@ namespace libcamera { LOG_DEFINE_CATEGORY(IPU3) -class IPU3CameraData; - class ImgUDevice { public: @@ -75,8 +73,8 @@ public: const StreamConfiguration &cfg, V4L2DeviceFormat *outputFormat); - int allocateBuffers(IPU3CameraData *data, unsigned int bufferCount); - void freeBuffers(IPU3CameraData *data); + int allocateBuffers(unsigned int bufferCount); + void freeBuffers(); int start(); int stop(); @@ -665,7 +663,7 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera) data->rawStream_.configuration().bufferCount, }); - ret = imgu->allocateBuffers(data, bufferCount); + ret = imgu->allocateBuffers(bufferCount); if (ret < 0) return ret; @@ -676,7 +674,7 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera) { IPU3CameraData *data = cameraData(camera); - data->imgu_->freeBuffers(data); + data->imgu_->freeBuffers(); return 0; } @@ -1121,7 +1119,7 @@ int ImgUDevice::configureOutput(ImgUOutput *output, /** * \brief Allocate buffers for all the ImgU video devices */ -int ImgUDevice::allocateBuffers(IPU3CameraData *data, unsigned int bufferCount) +int ImgUDevice::allocateBuffers(unsigned int bufferCount) { /* Share buffers between CIO2 output and ImgU input. */ int ret = input_->importBuffers(bufferCount); @@ -1158,7 +1156,7 @@ int ImgUDevice::allocateBuffers(IPU3CameraData *data, unsigned int bufferCount) return 0; error: - freeBuffers(data); + freeBuffers(); return ret; } @@ -1166,7 +1164,7 @@ error: /** * \brief Release buffers for all the ImgU video devices */ -void ImgUDevice::freeBuffers(IPU3CameraData *data) +void ImgUDevice::freeBuffers() { int ret;