From patchwork Tue Apr 2 00:53:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 834 Return-Path: Received: from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net [195.74.38.228]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 276B8610BF for ; Tue, 2 Apr 2019 02:54:01 +0200 (CEST) X-Halon-ID: cda2301d-54e1-11e9-846a-005056917a89 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (unknown [89.233.230.99]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA id cda2301d-54e1-11e9-846a-005056917a89; Tue, 02 Apr 2019 02:54:00 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Tue, 2 Apr 2019 02:53:30 +0200 Message-Id: <20190402005332.25018-4-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190402005332.25018-1-niklas.soderlund@ragnatech.se> References: <20190402005332.25018-1-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC 3/5] test: camera: Remove test for bad Stream IDs X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 00:54:01 -0000 In preparation of reworking how a default configuration is retrieved from a camera remove test that stream IDs must be valid as the data type passed to Camera::streamConfiguration() will change. This change is in preparation for a invasive change. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- test/camera/configuration_default.cpp | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp index 53ee021d33ca39b1..856cd415f7a6aec1 100644 --- a/test/camera/configuration_default.cpp +++ b/test/camera/configuration_default.cpp @@ -49,19 +49,6 @@ protected: return TestFail; } - /* - * Test that asking for configuration for an array of bad streams - * returns an empty list of configurations. - */ - Stream *stream_bad = reinterpret_cast(0xdeadbeef); - std::set streams_bad = { stream_bad }; - conf = camera_->streamConfiguration(streams_bad); - if (!conf.empty()) { - cout << "Failed to retrieve configuration for bad streams" - << endl; - return TestFail; - } - return TestPass; } };