From patchwork Fri Mar 1 15:41:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 698 Return-Path: Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A29A6117D for ; Fri, 1 Mar 2019 16:40:44 +0100 (CET) X-Originating-IP: 2.224.242.101 Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 81121C0002; Fri, 1 Mar 2019 15:40:43 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Fri, 1 Mar 2019 16:41:01 +0100 Message-Id: <20190301154103.19588-4-jacopo@jmondi.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190301154103.19588-1-jacopo@jmondi.org> References: <20190301154103.19588-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v7 3/5] libcamera: v4l2_subdevice: Cosmetic update X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 15:40:44 -0000 Cosmetic updated of V4L2Subdevice class: re-sort methods and comments to reflect the declaration order in the class definition. Cosmetic update, no functional changes intended. Acked-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- src/libcamera/v4l2_subdevice.cpp | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp index 394ed0f061f3..5f58904bf9e6 100644 --- a/src/libcamera/v4l2_subdevice.cpp +++ b/src/libcamera/v4l2_subdevice.cpp @@ -54,6 +54,11 @@ LOG_DEFINE_CATEGORY(V4L2Subdev) * Section 4.15.3.1 of the above mentioned Linux kernel documentation section. */ +/** + * \var V4L2SubdeviceFormat::mbus_code + * \brief The image format bus code + */ + /** * \var V4L2SubdeviceFormat::width * \brief The image width in pixels @@ -64,11 +69,6 @@ LOG_DEFINE_CATEGORY(V4L2Subdev) * \brief The image height in pixels */ -/** - * \var V4L2SubdeviceFormat::mbus_code - * \brief The image format bus code - */ - /** * \class V4L2Subdevice * \brief A V4L2 subdevice as exposed by the Linux kernel @@ -154,11 +154,6 @@ void V4L2Subdevice::close() * \return The name of the media entity the subdevice is associated to */ -std::string V4L2Subdevice::logPrefix() const -{ - return "'" + deviceName() + "'"; -} - /** * \brief Set a crop rectangle on one of the V4L2 subdevice pads * \param[in] pad The 0-indexed pad number the rectangle is to be applied to @@ -301,6 +296,11 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format) return 0; } +std::string V4L2Subdevice::logPrefix() const +{ + return "'" + deviceName() + "'"; +} + int V4L2Subdevice::enumPadSizes(unsigned int pad,unsigned int code, std::vector *sizes) {