From patchwork Wed Feb 20 23:59:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 600 Return-Path: Received: from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net [195.74.38.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C067660100 for ; Thu, 21 Feb 2019 00:59:53 +0100 (CET) X-Halon-ID: 9b8396a3-356b-11e9-b530-005056917a89 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (unknown [89.233.230.99]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA id 9b8396a3-356b-11e9-b530-005056917a89; Thu, 21 Feb 2019 00:59:50 +0100 (CET) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Thu, 21 Feb 2019 00:59:36 +0100 Message-Id: <20190220235939.25147-2-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190220235939.25147-1-niklas.soderlund@ragnatech.se> References: <20190220235939.25147-1-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/4] libcamera: pipeline_handler: extend documentation for configureStreams() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 23:59:54 -0000 Extend the documentation to explicitly state that the pipeline handler implementations are responsible to validate the requested configuration can be exactly satisfied by the hardware. Signed-off-by: Niklas Söderlund --- src/libcamera/pipeline_handler.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 616838fed702fec7..991674b34286ab16 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -136,6 +136,15 @@ PipelineHandler::~PipelineHandler() * is the Camera class which will receive configuration to apply from the * application. * + * Each pipeline handler implementation is responsible to validate that the + * configuration requested in \a config is exactly the same that is actually + * programmed and accepted by the hardware itself. If the format programmed + * differers from the one requested the pipeline handler shall return the + * error -EINVAL. If one streams configuration can't be satisfied by the + * hardware the pipeline handler does not need to try and program any other + * streams in \a config and the whole operation shall be consider to have + * failed. + * * \return 0 on success or a negative error code on error. */