From patchwork Wed Feb 6 06:08:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 536 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9796D61022 for ; Wed, 6 Feb 2019 07:08:28 +0100 (CET) Received: from pendragon.ideasonboard.com (d51A4137F.access.telenet.be [81.164.19.127]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 42FA62D8 for ; Wed, 6 Feb 2019 07:08:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1549433308; bh=OxR2dVUYzTcPjktGWfvQKEVJbM1cGNhPqnsRzEdtwg8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=jj9MSK/vMVxzcRLn8on8at3AKH4PkheOlrbOoL1qBLCAkF74ULZc64Xzm45AwzHs+ elNWsgrlMqq6AZk+7uLd0ihJwQRqtJGpAFDyR9TAfM4W3C4Zab/b8DomqfDjw0v4ij PBSmXMSRIJqEDgHTLK/bXL14vOE1lmDi2T0AaFRk= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Wed, 6 Feb 2019 08:08:12 +0200 Message-Id: <20190206060818.13907-22-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190206060818.13907-1-laurent.pinchart@ideasonboard.com> References: <20190206060818.13907-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 21/27] libcamera: pipeline: vimc: Set a default format X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 06:08:30 -0000 From: Niklas Söderlund Pick a default format for the one stream in a vimc camera. This is just a starting point to define a good default format for the vimc camera, and is expected to evolve over time as the capabilities of the library grows. Signed-off-by: Niklas Söderlund Signed-off-by: Jacopo Mondi Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- src/libcamera/pipeline/vimc.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp index ea6f28c64cc0..9c0406bef9dc 100644 --- a/src/libcamera/pipeline/vimc.cpp +++ b/src/libcamera/pipeline/vimc.cpp @@ -67,7 +67,11 @@ PipeHandlerVimc::streamConfiguration(Camera *camera, StreamConfiguration config{}; - LOG(VIMC, Info) << "TODO: Return a good default format"; + LOG(VIMC, Debug) << "Retrieving default format"; + config.width = 640; + config.height = 480; + config.pixelFormat = V4L2_PIX_FMT_RGB24; + config.bufferCount = 4; configs[&stream_] = config;