From patchwork Tue Jun 2 20:36:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Krishnan X-Patchwork-Id: 3902 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E38B3603D0 for ; Tue, 2 Jun 2020 22:36:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="SnLKe7bw"; dkim-atps=neutral Received: by mail-wm1-x341.google.com with SMTP id r9so4200798wmh.2 for ; Tue, 02 Jun 2020 13:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=z3d5dgbgr1v7PagmuvSqgxbVdz0TtYwQAc1OqeSdRmY=; b=SnLKe7bweM2OOgqdOSZvqk/czPUXMm42kFtnr9KjognC/UFT0LGRUNZmeGHgxbsTzm /LHyiWr5D/kvvqymdgQVvY76PdFaeK+e5YJlLi+StlsLw1/XcSplfSt87bg4f5c+urnh 6hLIHmpPuloqz3GC/E9rQJ2JltxRqJTxosPJ5bzeLeEeU52WK6HeYD26FBbxbO7Cd/A6 kK2Acuh8aHfoqbCv4DBj5QmG5YCvZkQtFkcCtyA7xbtfsPgewJCkweQ4analGayw93bB SYQgFNw6By3e+CYH2Kel0iRMyCUPA7exSFayTFxYijEsTo3LXUSDuf5KiJ3BmdkCPiuO zLVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=z3d5dgbgr1v7PagmuvSqgxbVdz0TtYwQAc1OqeSdRmY=; b=WotIqlUwikMgezR4z6AL0rQVBWRxYzg5FbgNJGiEQ72VVT5oGiNvbZxfbXVeNcT+7O H+6cjfds322ikhqDKABdKEbH+WfXPnbDaH+62d1O+jnkN3WKiYx+zHXQvWR6GCFSSArT H2Xi4Ml6YBwDOMXj4WUA67c/Z6lLPz/UUyHNdYlTI1I1T5wvQNisHB4tx2GKU8zCun/A vN0ZFDS5NUQEXYKyraS7pLth6aOkfcCG6ZWQPY0ACxQJvjxrCZx1gPv1o4YwqlD5zvyf UCvKUx6qbjlYITShqqIUjs4VS0R3ccVDxHaiQbzZe/ZvLdh/QZ7bG6ZPREX+TucqVq10 o8Ow== X-Gm-Message-State: AOAM530ABGW9T+Nwrp5hLz1LunUFF8/EHSsnx7duACr56THAkUu7ptZv jYTFtzZXJD6vsQkGUuo4q1WQdzCplo8= X-Google-Smtp-Source: ABdhPJxbUaBkYjqFG0M+ijM+s7uAlUnPF8cubc9AMH9fi8fkSuJfcrqeIwV0/7hsGK1fyb1N+92KSg== X-Received: by 2002:a7b:cd04:: with SMTP id f4mr5891419wmj.118.1591130200132; Tue, 02 Jun 2020 13:36:40 -0700 (PDT) Received: from mmwg-hackbox.linaro.org.de ([2a01:4f8:10a:2685::2]) by smtp.gmail.com with ESMTPSA id o20sm203715wra.29.2020.06.02.13.36.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jun 2020 13:36:39 -0700 (PDT) From: Madhavan Krishnan To: libcamera-devel@lists.libcamera.org Cc: Madhavan Krishnan Date: Tue, 2 Jun 2020 22:36:34 +0200 Message-Id: <1591130194-5161-1-git-send-email-madhavan.krishnan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Subject: [libcamera-devel] [PATCH] libcamera: test: Fixed the compilation issue X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 20:36:41 -0000 The return value of write() function is ignored, causing the following compiler error|warning with gcc version 5.4 error: ignoring return value of 'ssize_t write(int, const void*, size_t)' Fix this by storing the return value of write() and return a test error in case of failure. Reported-by: Coverity CID=284605 Signed-off-by: Madhavan Krishnan Reviewed-by: Laurent Pinchart --- test/file.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/file.cpp b/test/file.cpp index 6262a6f..e328c01 100644 --- a/test/file.cpp +++ b/test/file.cpp @@ -27,13 +27,16 @@ protected: { fileName_ = "/tmp/libcamera.test.XXXXXX"; int fd = mkstemp(&fileName_.front()); + ssize_t ret; + if (fd == -1) return TestFail; - write(fd, "libcamera", 9); + ret = write(fd, "libcamera", 9); + close(fd); - return TestPass; + return ret == 9? TestPass : TestFail; } int run()