From patchwork Fri May 15 12:42:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 3797 Return-Path: Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E242660E0F for ; Fri, 15 May 2020 14:42:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="pPSl68t1"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type; s=s1; bh=CVlZQdEZ+lTx2UvlTlFz67zvM7i8+MT+A3eEp0ALdvk=; b=pPSl68t12Pl2UVTXpa5V3sd3CvRKl6x0AjldSh3ihHnzWSmujfXcXevjeWC1NE/rGszM 1b187QHO9+MVYWMU644Vkr7gf+gBuYENnHjlSBPVJn+ieih+ktNc085/dlFCk+fHSACYxP wcLjae2l2aOz5xF/HXoqwHmxHcVVKXyvk= Received: by filterdrecv-p3iad2-8ddf98858-rpdh9 with SMTP id filterdrecv-p3iad2-8ddf98858-rpdh9-19-5EBE8E4D-27 2020-05-15 12:42:53.614076869 +0000 UTC m=+4361719.364516320 Received: from mail.uajain.com (unknown) by ismtpd0001p1maa1.sendgrid.net (SG) with ESMTP id 18xcdec4Roe1WdGokaodIw for ; Fri, 15 May 2020 12:42:53.141 +0000 (UTC) From: Umang Jain Date: Fri, 15 May 2020 12:42:53 +0000 (UTC) Message-Id: <20200515124245.18040-4-email@uajain.com> In-Reply-To: <20200515124245.18040-1-email@uajain.com> References: <20200515124245.18040-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcumJKJCztqrDTQNOfbQrvHfzJz5+dA5iyzk1X2aMakKJMauHf+8y4XIeDLfzKNBlhddoPRNDlJ0oVmQujTCu53m4YZXT6mjH7M16lzr/OQK15oXrHX606tl2oKRXTDQvjsCB04mL8yfvEDI12ZRAxioaxqlDTyPQTIUQcmhmyB/Sb3z+kdFeGc35BQ+ViATXzvdiqI/o2FeMz94hQgrqICA== To: libcamera-devel Subject: [libcamera-devel] [PATCH v2 3/4] test: log: log_api: Close open fds on error paths X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 12:42:55 -0000 Pointed out by Coverity DefectId=279091 Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham --- test/log/log_api.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/log/log_api.cpp b/test/log/log_api.cpp index 33622f8..4d2c8db 100644 --- a/test/log/log_api.cpp +++ b/test/log/log_api.cpp @@ -86,6 +86,7 @@ protected: if (logSetFile(path) < 0) { cerr << "Failed to set log file" << endl; + close(fd); return TestFail; } @@ -96,6 +97,7 @@ protected: lseek(fd, 0, SEEK_SET); if (read(fd, buf, sizeof(buf)) < 0) { cerr << "Failed to read tmp log file" << endl; + close(fd); return TestFail; } close(fd);