From patchwork Wed Apr 29 21:44:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dafna Hirschfeld X-Patchwork-Id: 3613 Return-Path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E97B603F7 for ; Wed, 29 Apr 2020 23:44:57 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dafna) with ESMTPSA id BC92926D296 From: Dafna Hirschfeld To: libcamera-devel@lists.libcamera.org Cc: helen.koike@collabora.com, dafna.hirschfeld@collabora.com, ezequiel@collabora.com, dafna3@gmail.com Date: Wed, 29 Apr 2020 23:44:50 +0200 Message-Id: <20200429214450.27676-1-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: don't fail if sensorInfo fails X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 21:44:57 -0000 When starting the streaming, it might be that the call to sensorInfo fails. This does not mean that the camera can't stream so set 'ret' to 0 Signed-off-by: Dafna Hirschfeld Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 1a34ffe..6aa3178 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -828,6 +828,7 @@ int PipelineHandlerRkISP1::start(Camera *camera) /* \todo Turn this in an hard failure. */ LOG(RkISP1, Warning) << "Camera sensor information not available"; sensorInfo = {}; + ret = 0; } std::map streamConfig;