From patchwork Sat Apr 25 00:45:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 3537 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D12462E45 for ; Sat, 25 Apr 2020 02:45:53 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MgpH4N9b"; dkim-atps=neutral Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCE27DAD; Sat, 25 Apr 2020 02:45:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1587775553; bh=BX8EnDSYZidO11p66DGz/BVxNd8Tm7yk+F1W2wGxoZc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MgpH4N9bc0klcgYDdCCm/xRN/0GONeE5uZ0kN3IUKot18w5bVvetLofQf661SCVHG XbX9RUebpzCLZfM97m/Q8a1OBI6zaTVGFIQ3obqTjKF5hZnanM1f1bRuAA+//tbm4i pR3BVuObXn1DFZb4au/11pbzOVzuixOhDhu5Tl9E= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sat, 25 Apr 2020 03:45:29 +0300 Message-Id: <20200425004533.26907-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.25.3 In-Reply-To: <20200425004533.26907-1-laurent.pinchart@ideasonboard.com> References: <20200425004533.26907-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 3/7] libcamera: control_ids: Add comment to specify control direction X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Apr 2020 00:45:53 -0000 From: Naushir Patuck Document that controls are bi-directional by default. If a control is only returned in metadata, this must be specified in the control's description. Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- src/libcamera/control_ids.cpp.in | 3 +++ src/libcamera/control_ids.yaml | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in index 99c511d0e712..cba6258d68dd 100644 --- a/src/libcamera/control_ids.cpp.in +++ b/src/libcamera/control_ids.cpp.in @@ -33,6 +33,9 @@ ${controls_def} /** * \brief List of all supported libcamera controls + * + * Unless otherwise stated, all controls are bi-directional, i.e. they can be + * set through Request::controls() and returned out through Request::metadata(). */ extern const ControlIdMap controls { ${controls_map} diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 4befec746a59..bcbab195a374 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -4,6 +4,8 @@ # %YAML 1.2 --- +# Unless otherwise stated, all controls are bi-directional, i.e. they can be +# set through Request::controls() and returned out through Request::metadata(). controls: - AeEnable: type: bool