From patchwork Fri Apr 24 10:46:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3515 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0726A62E4D for ; Fri, 24 Apr 2020 12:47:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="KawmfeBS"; dkim-atps=neutral Received: by mail-wm1-x344.google.com with SMTP id h2so9922570wmb.4 for ; Fri, 24 Apr 2020 03:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=T1pRuMpSBIYfzjOqeocQU2uGXm5/J6+ZUKEx+rcA7Go=; b=KawmfeBSrzCmMpjUS6jzgSEaswBH5yA/Z5zT1WdHzsYPTxxhx5iNPpGdAV+67LEueA htTnt3e2e31RZYPGzcqoZRFBL197VDnc4jTaW8D46lZnQ4nMj2hRGnsJu4wXFaxTdCkv cUkLjkcZ3avDYhKcjs4q6FZBkMtcNg2Yf/gorpTJOwoBa3zuqR/xGIc2cMOOFVnhAOEE vPmJ49oKwsR2CWlBNeTXOAdwRh1tClifgrTJpoQz9Fj4sImFjCkNcup/xGd3MNj2iD0E xcAZABvq+UbFnWBfPd0S0BY+3oFUFDd3yvIIX/EgR0dGbv2NERWWu8kNK5K7NeNj6hg4 iczw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=T1pRuMpSBIYfzjOqeocQU2uGXm5/J6+ZUKEx+rcA7Go=; b=pTbwZCipkXjrfTwB618IhQnYvZhD5rP2A1SBCm/Sq3SFRtKQplrpa/sJIFI4JDm5L/ fDCGGe5lc6J7putguMnXfzfuE7J7r2ECdzNTu9aQccNFtNLIi+I5EdcIIZ1Z0jBLAhHK aW1Wq/i8rrA4v2wDKZMCut9T1NVel/pV3waNRb5MoW7GKWpHGVmLaY2R21KgnS+vRqRn olzbcDmbsoAqQNNR+n38tCKZjsvPl66VDMVY92pzcXd3kr/eLPEFQsaE877KMmDnhP/8 K2ZRCf9ddexlLprGZnwlVX5GH1aKj0oADAzZzQd+P3ob7O1LkJDZObf3BxrUhp8j5DzV MZtg== X-Gm-Message-State: AGi0PuaVVdE1dylJ+BFqq4AXB9LqpOQpugNPCY9n7dhVPr7OIvNE9r0R xFVlvUwLR5v5FSC2Q9haFdcUy73UTAwMdA== X-Google-Smtp-Source: APiQypI84gD54UfPxLC//1KKQMXye0vOpQi5waFhVt56x1v/4BLALKHSjEjkPdF1Q3pbo3UUm5GLPQ== X-Received: by 2002:a1c:148:: with SMTP id 69mr9743669wmb.181.1587725234560; Fri, 24 Apr 2020 03:47:14 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id j68sm7884997wrj.32.2020.04.24.03.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2020 03:47:14 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 24 Apr 2020 11:46:58 +0100 Message-Id: <20200424104700.26819-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200424104700.26819-1-naush@raspberrypi.com> References: <20200424104700.26819-1-naush@raspberrypi.com> Subject: [libcamera-devel] [PATCH v4 3/5] libcamera: controls: Reorder and update description of existing controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 10:47:15 -0000 Group AE, AWB, etc. controls together for accessibility. Update descriptions for Contrast, Brightness, and Saturation controls. Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart --- src/libcamera/control_ids.yaml | 41 ++++++++++++++++++++-------------- 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index d8bdb382..f7403081 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -25,23 +25,6 @@ controls: \sa AeEnable - - AwbEnable: - type: bool - description: | - Enable or disable the AWB. - - - Brightness: - type: int32_t - description: Specify a fixed brightness parameter - - - Contrast: - type: int32_t - description: Specify a fixed contrast parameter - - - Saturation: - type: int32_t - description: Specify a fixed saturation parameter - - ExposureTime: type: int32_t description: | @@ -58,4 +41,28 @@ controls: colour channels. This value cannot be lower than 1.0. \sa ExposureTime AeEnable + + - Brightness: + type: float + description: | + Specify a fixed brightness parameter. Positive values (up to 65535.0) + produce brighter images; negative values (up to -65536.0) produce darker + images and 0.0 leaves pixels unchanged. + + - Contrast: + type: float + description: | + Specify a fixed contrast parameter. Normal contrast is given by the + value 1.0; larger values produce images with more contrast. + + - AwbEnable: + type: bool + description: | + Enable or disable the AWB. + + - Saturation: + type: float + description: | + Specify a fixed saturation parameter. Normal saturation is given by + the value 1.0; larger values produce more saturated colours. ...