From patchwork Fri Apr 24 10:46:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3513 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A8DCC603FC for ; Fri, 24 Apr 2020 12:47:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="gUW1dhSN"; dkim-atps=neutral Received: by mail-wm1-x341.google.com with SMTP id r26so10191640wmh.0 for ; Fri, 24 Apr 2020 03:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7AEGnA5S/d2+iT60qv7PR5d/7S8hOxh1bBRKMqWNlLs=; b=gUW1dhSNbCTQkNf3utkg6KnA2qcggRuMvpaetCZSdYTpRWYqiWc/OELsD3VnmYroUx KXAPe2A9JsafPS57Ct7+GCnI9iC/vBl5DJU0sA392NfxIpoxsGWk3JuK98Ee4/jvGUb0 BOFHzfFX286WVEkAfUj/kY/B8cmYy7sYEpvnbsFZSZnn0w0tvfx5T94f0kkPkOcgSspQ 31krKcr2IhR1t2MGu97ZHtWlym695w1uOgQVH/W5U/5cTuUgXB11KkbVRGsEbjV2XuE3 oR09pe+JDlnGTxRa7sUQ0I+1SV2GbMyXaZuSLc1gx3NeFYnOHmQBeJ8vKZaUConagJ5H XsXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7AEGnA5S/d2+iT60qv7PR5d/7S8hOxh1bBRKMqWNlLs=; b=F3b6tBGc3vy/md+lMaf1KZC4SNznosjDpLrYqNUbW/Pjcm24wJYdSDZd1CCn66SQ/V 8t/DsALYZGGYP6N7QaHHoOPTpoHZatyYksavjn+yUss6myjYy+lsc2MxcW2jrkpmkw21 7Nl3BD6Q8BNZpT8GWZViXPf/MPOVHfjX5tYlrPI9xzJA0mJgZwaEXYZ24tD1N5PRPsrp dLsp1UWLwr6kfsIavBpmK+mYOY9umZGJy2DtWzzCWz/lzBu0s8fm/ZNA7gAIGp3PIqCC Eh48n6f5XzERibOgOysQgOjLVHWeKhopbtQPq3k4JpNz/bhqzGce7jCpC/v55XtegKgt JdPQ== X-Gm-Message-State: AGi0Pubm/nXe7MjyHgQu1XFF94r9tNlNa3MTrOtnBgFshq79d17j19aO 2VSXZaR11W0lzg8uPexRtN6DplK1X8DHvg== X-Google-Smtp-Source: APiQypLpqUgtqiUtV1oyhEXNX7mVeg+bWxVuMNST9zt3QuLtN7HOdsEAv2X2d9zciHoTGSOxfuQXcw== X-Received: by 2002:a1c:68d7:: with SMTP id d206mr8876317wmc.29.1587725232128; Fri, 24 Apr 2020 03:47:12 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id j68sm7884997wrj.32.2020.04.24.03.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2020 03:47:11 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 24 Apr 2020 11:46:56 +0100 Message-Id: <20200424104700.26819-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200424104700.26819-1-naush@raspberrypi.com> References: <20200424104700.26819-1-naush@raspberrypi.com> Subject: [libcamera-devel] [PATCH v4 1/5] libcamera: control_ids: Add comment to specify control direction X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 10:47:12 -0000 Document that controls are bi-directional by default. If a control is only returned in metadata, this must be specified in the control's description. Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart --- src/libcamera/control_ids.cpp.in | 3 +++ src/libcamera/control_ids.yaml | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in index 99c511d0..cba6258d 100644 --- a/src/libcamera/control_ids.cpp.in +++ b/src/libcamera/control_ids.cpp.in @@ -33,6 +33,9 @@ ${controls_def} /** * \brief List of all supported libcamera controls + * + * Unless otherwise stated, all controls are bi-directional, i.e. they can be + * set through Request::controls() and returned out through Request::metadata(). */ extern const ControlIdMap controls { ${controls_map} diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 4befec74..bcbab195 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -4,6 +4,8 @@ # %YAML 1.2 --- +# Unless otherwise stated, all controls are bi-directional, i.e. they can be +# set through Request::controls() and returned out through Request::metadata(). controls: - AeEnable: type: bool