From patchwork Tue Apr 14 07:06:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 3459 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A7E8362E41 for ; Tue, 14 Apr 2020 09:07:00 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="XN2YPgeS"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type; s=s1; bh=ciyi7nLIPvT9ePashq6eXudVkrTZwv2SOMfzMQAOSgs=; b=XN2YPgeSV88mDGOPTHoOnBW22wZ/w2IPDdD4VH+fylFG8d9NWVaDjeJL6klvWc2HLUeB JtsJ7RNsXFpAPXMKzbTnRBfYTr22gJiBzM8C5uR8N/EGmIWPeWuy2WmdG7hJL3mZstnYnE ID6wpY9J9bbv4wVq53TizoZZZvB+Tl+1o= Received: by filter0081p3las1.sendgrid.net with SMTP id filter0081p3las1-23682-5E956112-11D 2020-04-14 07:06:59.17861901 +0000 UTC m=+1071360.368382965 Received: from mail.uajain.com (unknown) by ismtpd0005p1maa1.sendgrid.net (SG) with ESMTP id ILp-WIe8Q3W3Y1zovR9l5w Tue, 14 Apr 2020 07:06:58.670 +0000 (UTC) From: Umang Jain Date: Tue, 14 Apr 2020 07:06:59 +0000 (UTC) Message-Id: <20200414070642.22366-4-email@uajain.com> In-Reply-To: <20200414070642.22366-1-email@uajain.com> References: <20200414070642.22366-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc8Y1sFjEEckHl5AFRmKDueuFuam3Ti9xR18CbViEtKZIG6JOaQQXh4HDflpOF0cviKfs19XJXwE5xmjAb0wuStb5hkUBFmPGJ8v2ACSrJ2ms1kDdGNHoQ0MXQn7npCNNJ4VTOLpRUl5FoaeCv0T2XX12+BiyJX8BH/EAgE6hKH0WeCnnQmHAKctlQSyqDr6/J To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH 3/3] test: v4l2_videodevice: buffer_cache: Fail the test if no buffer from cache is obtained X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 07:07:01 -0000 Failing the test guards against negative index (-ENOENT in this case) being passed to V4L2BufferCache::put(). Pointed out by Coverity DefectId=279090 Signed-off-by: Umang Jain --- test/v4l2_videodevice/buffer_cache.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp index d730e75..1870249 100644 --- a/test/v4l2_videodevice/buffer_cache.cpp +++ b/test/v4l2_videodevice/buffer_cache.cpp @@ -90,6 +90,11 @@ public: /* Pick a hot buffer at random and store its index. */ int hotBuffer = dist(generator_); int hotIndex = cache->get(*buffers[hotBuffer].get()); + if (hotIndex < 0) { + std::cout << "Failed lookup from cache" << std::endl; + return TestFail; + } + cache->put(hotIndex); /*