From patchwork Mon Apr 13 10:46:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 3433 Return-Path: Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E08362826 for ; Mon, 13 Apr 2020 12:46:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="BJsVZW+n"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type; s=s1; bh=lnej2EnrhGZdGHi+oYTyOl0lU5e/C29RGqqXEPQUKQ4=; b=BJsVZW+nAX00JqG/p0Soylu4bkZDCA1ImuQjge+hxsFMC7VF8ZIiCMMAc66qELoXKu1c /7X9FoKFjOLBxpBfdc7NghALpJxiDkMFj1IWfDSoStrqmsGgiWSjxj6v9HnLa+ENnqm/S4 o7WcXryy8v+8hTVHiarW1j767ILdhvge4= Received: by filterdrecv-p3iad2-8ddf98858-xm5rk with SMTP id filterdrecv-p3iad2-8ddf98858-xm5rk-18-5E94431F-1C 2020-04-13 10:46:55.560459526 +0000 UTC m=+1513404.540192897 Received: from mail.uajain.com (unknown) by ismtpd0002p1maa1.sendgrid.net (SG) with ESMTP id _MNMZXwcSO-p0tneNjxbog Mon, 13 Apr 2020 10:46:55.158 +0000 (UTC) From: Umang Jain Date: Mon, 13 Apr 2020 10:46:55 +0000 (UTC) Message-Id: <20200413104631.12276-5-email@uajain.com> In-Reply-To: <20200413104631.12276-1-email@uajain.com> References: <20200413104631.12276-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc9vLW9W8H4bP+KZ0PPVtun/auY9FtTkZgn/nQf0Y06iNRgTP5yjireSIn9mtcUeX2FiGxxLCfPxkM+JKJEEePO1hLNtYod9v4CjzeDnwqQHQOuZAaQxU7jS6Vv2SWz9OohMnAM4n6r1KPhUtje5DRCAJLjRgSDuje+0ToFImZ35QMxu2Nz6U4OxTLJfGR9hdLIvv1DH9hQ0cyBrCALM/BxQ== To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH 4/4] test: log: log_process: Close open fds on error paths X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2020 10:46:57 -0000 Pointed out by Coverity DefectId=279097 Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham --- test/log/log_process.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp index 2df4aa4..88baa27 100644 --- a/test/log/log_process.cpp +++ b/test/log/log_process.cpp @@ -106,6 +106,7 @@ protected: memset(buf, 0, sizeof(buf)); if (read(fd, buf, sizeof(buf)) < 0) { cerr << "Failed to read tmp log file" << endl; + close(fd); return TestFail; } close(fd);