From patchwork Fri Apr 3 14:53:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3373 Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BA0CA629C1 for ; Fri, 3 Apr 2020 16:53:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="ss2zo60c"; dkim-atps=neutral Received: by mail-wr1-x442.google.com with SMTP id 31so8869209wrs.3 for ; Fri, 03 Apr 2020 07:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RtEZvi9ceNL8KobZqDTHZ/xMxtvepHlaSzXqdiU5oQc=; b=ss2zo60cA9tEyDBhBkf9PgFXfOrBVkHZYQbMn0uhTze5GegX9gEmm341y6EX7s/2qV iaPVOsKEaSqcT0M41KZrvZw17XNoHpgUVZubsN5zLFj4CaqQq6eeDTZKGIpOLuUBFzg0 cV6V4K4mo1/sdfYGjY2z9lnMCLM9aIxvf2xkwtjLUUCfjEQVJXsOKhuKBAECfymJtUm0 sipz143pQOZn8cvEnF549AOIp64vrtnm2wVLcHzQPbot6HAIx7rQ3BZI7JDFcly1xdt1 Y11FuxtyjVC0iwckK1RE/ZpidH5307h2rycozF7B3dIMemdsEHmbTYD3TuXL/5I+/lB1 KQ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RtEZvi9ceNL8KobZqDTHZ/xMxtvepHlaSzXqdiU5oQc=; b=Se+n3lUM0FzBVpkkcY/iJH0IxpLxmKBfrvugyKfFPHmUqFfb0Jb/jk7p6iWROwybLN rQaFz71ko+rIlfi9uTw39IwE+DCiM9Ev4hzWTOAg23RdTvB5ElBCkkRg+HLQRheLAcVV uaQCfDTzCpMdYrTEKEWSkBn/3AFViv/XuEzCun+/6pnzskIahJj5asnlIFUHsv5CsJuj QkAPndah3Lt2xt3ue8vI7+XV6aCTflxIDe7Q6+NpwN+b8tRL3KUCgkINN7pPL2S3g0nt 9VL4Pmd/E/1c4/8lbY8IZ7LSswiTKOpw9dsm8iankCf13NpKXvEqtS3pzCQvhAPj19s8 0j5A== X-Gm-Message-State: AGi0PuZ8E9flk2w0JiQZb8Q9qlGV8GbGKMIOwFWxrJU5F7STj1zM8UcA NxecUbdusoz86zjho5DDPYaoz9T/Z0WDQQ== X-Google-Smtp-Source: APiQypIez94NfxKvZMHHNFhYLbZCcAZEHN0xeDz8L3sB5J6YfxBzj4p74i0Da7zQsYgAKJw4DQaM4w== X-Received: by 2002:a5d:68c4:: with SMTP id p4mr9645833wrw.308.1585925610342; Fri, 03 Apr 2020 07:53:30 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id u5sm13559469wrp.81.2020.04.03.07.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 07:53:29 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 3 Apr 2020 15:53:03 +0100 Message-Id: <20200403145305.10288-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200403145305.10288-1-naush@raspberrypi.com> References: <20200403145305.10288-1-naush@raspberrypi.com> Subject: [libcamera-devel] [PATCH v3 3/5] libcamera: controls: Reorder and update description of existing controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 14:53:31 -0000 Group AE, AWB, etc. controls together for accessibility. Update descriptions for Contrast, Brightness, and Saturation controls. Signed-off-by: Naushir Patuck --- src/libcamera/control_ids.yaml | 45 ++++++++++++++++++++-------------- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 839eea76..64e81520 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -23,25 +23,6 @@ controls: \sa AeEnable - - AwbEnable: - type: bool - description: | - Enable or disable the AWB. - - \sa ManualGain - - - Brightness: - type: int32_t - description: Specify a fixed brightness parameter - - - Contrast: - type: int32_t - description: Specify a fixed contrast parameter - - - Saturation: - type: int32_t - description: Specify a fixed saturation parameter - - ExposureTime: type: int32_t description: | @@ -58,4 +39,30 @@ controls: colour channels. This value cannot be lower than 1.0. \sa ExposureTime AeEnable + + - Brightness: + type: int32_t + description: | + Specify a fixed brightness parameter. Positive values (up to 65535) + produce brighter images; negative values (up to -65536) produce darker + images and 0 leaves pixels unchanged. + + - Contrast: + type: int32_t + description: | + Specify a fixed contrast parameter. Normal contrast is given by the + value 1.0; larger values produce images with more contrast. + + - AwbEnable: + type: bool + description: | + Enable or disable the AWB. + + \sa ManualGain + + - Saturation: + type: int32_t + description: | + Specify a fixed saturation parameter. Normal saturation is given by + the value 1.0; larger values produce more saturated colours. ...