From patchwork Fri Mar 20 21:04:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 3224 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 57F7960416 for ; Fri, 20 Mar 2020 22:04:45 +0100 (CET) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AF7BC504; Fri, 20 Mar 2020 22:04:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584738284; bh=1lBy6fvpAnsk0xcwQFO4HBmg/T4GaSqsVJcqf55oAcU=; h=From:To:Cc:Subject:Date:From; b=wIhzLgcPDU6HKQL3C6aNLWi0A6+Gn1+O9SVy+PWY33mSvSHXzDneVEVy4+KZ5hv/X Ixx+kTe2WxD0HQKfFxOPYcJtAZBIQdgUH3YF//fCuqCFVbJX2cgxfo1RJGhl9s8Ujj N6vYm3tmtbXtgWjpkgvYzfq+qkw+IUwlIGTxChnQ= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 20 Mar 2020 23:04:34 +0200 Message-Id: <20200320210435.8876-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] Revert "libcamera: controls: Don't over-optimize ControlValue layout" X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 21:04:45 -0000 This is a partial revert of commit 0028536d70c7, removing a change that was incorrectly squashed. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund Acked-by: Kieran Bingham --- src/libcamera/device_enumerator_udev.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp index f5a482e35b86..87638c59761c 100644 --- a/src/libcamera/device_enumerator_udev.cpp +++ b/src/libcamera/device_enumerator_udev.cpp @@ -90,8 +90,7 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev) return ret; } - if (!ret) - addDevice(media); + addDevice(media); return 0; }