From patchwork Mon Mar 9 12:33:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3063 Return-Path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1826C62923 for ; Mon, 9 Mar 2020 13:35:37 +0100 (CET) Received: by mail-wm1-x343.google.com with SMTP id g62so4869863wme.1 for ; Mon, 09 Mar 2020 05:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=32VL+kiTOWZatujbjBIETFjGTk9tbL9R8OZx5PH9JVg=; b=kcIFajR3TF8HXoaEm3DNqcOHPzE/R1wfjT1Zlmys/KOyAIBi/fM7BeePWf7H5NuVzO tiKFFNAlHv7LqlaB/kgz9COQgbXp7Z2h7Mlo+OP9UdMiyHywrdnj2/LRC8wT/UyP337T IciVav7o9ylU04P3AmgK3FYHgwob+opwg3Aeqrq5Vdv4MiZxbJmOdlxV1FRgH10m7UH3 48DFo7a8lJqCG+Tw4bsHw3FrPbXKSFj8cELIY9FrqOCRe+WfGoIJrzUboZUFoMxt07iB qWcGHJrXHmxabDwsu92+B6DKh+z/ehvOgy3kf/Rlc4X6ZrugHtIr1wbBrpZ2l6HZIpTL 1J8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=32VL+kiTOWZatujbjBIETFjGTk9tbL9R8OZx5PH9JVg=; b=Yz3fZ/t0brKXffWtQO2osWAiz0QWQc+2bPt+RWTon6sKNVHIpvQVjEMkmZ5H+W6j/b DTGN/XTC0M5T47JjmIijmFw9sZWJrPG7WClYbJgrZMSqQ1/hpOq/zSzXHs6fGYKYLWvp Y6JLhf8Xdy+fGGThaxsJrGUm+ArhuTXOSUQKbH3Hr1+IHAWDpKI6iiMBPVZHD9+nNfmA l47z3i3gqOSKMx2Q8HgdzO/d4HwHgOWs9f2v9Y+GOgEW2n5lJloV5qILSa44SucHSdDc ygyhxDvRrvXqZaPVJcc8psQDKvxPdJIPcdzQwyFdIMvX87BT+orrnxykxNzMPbf98xS9 GoDA== X-Gm-Message-State: ANhLgQ215KDjl4zJ04eu7G+tCvkVbB+c9WSbVWmMNPih4fN/RcFy4Yx0 2jdJwH2BNMTU9+iIs9xBHU1oE4UQ7v6w2w== X-Google-Smtp-Source: ADFU+vtcnoafL16a3fOLFX1NcBlJpLc19UckgXXvsjI2tsYUKhzf77NlOfkl8hVOSkYOmkrOoR8EsA== X-Received: by 2002:a7b:c189:: with SMTP id y9mr7486233wmi.47.1583757336658; Mon, 09 Mar 2020 05:35:36 -0700 (PDT) Received: from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net. [212.69.50.51]) by smtp.gmail.com with ESMTPSA id z135sm25693827wmc.20.2020.03.09.05.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 05:35:36 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 9 Mar 2020 12:33:18 +0000 Message-Id: <20200309123319.630-6-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200309123319.630-1-naush@raspberrypi.com> References: <20200309123319.630-1-naush@raspberrypi.com> Subject: [libcamera-devel] [PATCH v2 5/6] libcamera: controls: Update usage and description for existing controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2020 12:35:37 -0000 Switch to using floats for constrast and saturation control to be more in-line with end-user expectations. Expand on the descrption for the brightness, contrast and saturation controls. Signed-off-by: Naushir Patuck --- src/libcamera/control_ids.yaml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 9a33094a..3d1b058f 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -192,13 +192,20 @@ controls: - Brightness: type: int32_t - description: Specify a fixed brightness parameter + description: | + Specify a fixed brightness parameter. Positive values (up to 65535) + produce brighter images; negative values (up to -65536) produce darker + images and 0 leaves pixels unchanged. - Contrast: - type: int32_t - description: Specify a fixed contrast parameter + type: float + description: | + Specify a fixed contrast parameter. Normal contrast is given by the + value 1.0; larger values produce images with more contrast. - Saturation: - type: int32_t - description: Specify a fixed saturation parameter + type: float + description: | + Specify a fixed saturation parameter. Normal saturation is given by + the value 1.0; larger values produce more saturated colours. ...