From patchwork Sat Mar 7 19:16:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 3039 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D6BA628CC for ; Sat, 7 Mar 2020 20:16:42 +0100 (CET) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED3B69CC; Sat, 7 Mar 2020 20:16:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1583608602; bh=3p7fRZRhYG6ALaljRIcPJjhs6uzIqAmiyMDmPT0wGhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=drIbIdSKu0O/VfF4t4B79lJTPVDc7f43DaVqPCzfXbUb1wVAB3TbGsKcSlIdlOiAM LA/RGTh1LZWVrRpQvzbi8bSpqz3ihkPEsLPEUNHrNz46KJeLyk0+jQTl1n5P3VSAz8 0m30amuXsFqqQ/q5eDDddcVht5XucvhjzBgWyK2s= From: Laurent Pinchart To: Nicolas Dufresne Cc: libcamera-devel@lists.libcamera.org Date: Sat, 7 Mar 2020 21:16:34 +0200 Message-Id: <20200307191634.9320-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200307191634.9320-1-laurent.pinchart@ideasonboard.com> References: <20200307191634.9320-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 2/2] gst: Fix GLib detection X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2020 19:16:42 -0000 Commit 17cccc68a88f ("Add GStreamer plugin and element skeleton") has gained a last minute fix for a clang compilation error with GLib prior to v2.63.0. The fix wasn't properly tested, and failed to check the GLib dependency correctly. This resulted in compilation of the GStreamer element to always be disabled. Fix this by changing the GLib package name from 'glib' to 'glib-2.0'. Fixes: 17cccc68a88f ("Add GStreamer plugin and element skeleton") Signed-off-by: Laurent Pinchart Reviewed-by: Nicolas Dufresne --- src/gstreamer/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build index 8759a12205fa..e119e472cb58 100644 --- a/src/gstreamer/meson.build +++ b/src/gstreamer/meson.build @@ -13,7 +13,7 @@ libcamera_gst_cpp_args = [ '-DPACKAGE="@0@"'.format(meson.project_name()), ] -glib_dep = dependency('glib', required : get_option('gstreamer')) +glib_dep = dependency('glib-2.0', required : get_option('gstreamer')) gst_dep_version = '>=1.14.0' gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_dep_version,