From patchwork Fri Mar 6 15:59:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 2999 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C71D0628B1 for ; Fri, 6 Mar 2020 17:00:26 +0100 (CET) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E1F71265 for ; Fri, 6 Mar 2020 17:00:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1583510426; bh=oFiLAcNlTeOM8OlPjueQgF0oovjVB0y8QA5hKJv6BSA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=aiFPG34V04MgtezYw5+T3iBNa2bE32p8P2EsGIZhtyRx2+I5OiFG9Y0zGxsuoB07c 9i8R38Emu99wBwDC7Ix1ho8uqt5XsI/80weiXh2YPYjj39aUY+lAVE8ZUrEb3a5ear rSWI+9jIareN/e+lZSpshk+b9isAQ0nQrubH4I+I= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 6 Mar 2020 17:59:57 +0200 Message-Id: <20200306160002.30549-28-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200306160002.30549-1-laurent.pinchart@ideasonboard.com> References: <20200306160002.30549-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 27/32] libcamera: control_serializer: Simplify serialization of ControlValue X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2020 16:00:28 -0000 Use the ControlValue::data() function to access raw data stored in the control value and simplify serialization. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/libcamera/control_serializer.cpp | 35 +--------------------------- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp index edf3e5cab09f..997e87bec817 100644 --- a/src/libcamera/control_serializer.cpp +++ b/src/libcamera/control_serializer.cpp @@ -146,40 +146,7 @@ size_t ControlSerializer::binarySize(const ControlList &list) void ControlSerializer::store(const ControlValue &value, ByteStreamBuffer &buffer) { - switch (value.type()) { - case ControlTypeBool: { - bool data = value.get(); - buffer.write(&data); - break; - } - - case ControlTypeByte: { - uint8_t data = value.get(); - buffer.write(&data); - break; - } - - case ControlTypeInteger32: { - int32_t data = value.get(); - buffer.write(&data); - break; - } - - case ControlTypeInteger64: { - uint64_t data = value.get(); - buffer.write(&data); - break; - } - - case ControlTypeFloat: { - float data = value.get(); - buffer.write(&data); - break; - } - - default: - break; - } + buffer.write(value.data()); } void ControlSerializer::store(const ControlRange &range,