From patchwork Wed Nov 18 20:31:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Faizel K B X-Patchwork-Id: 29038 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2D674C3304 for ; Wed, 18 Nov 2026 20:33:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D79726A920; Wed, 18 Nov 2026 21:33:55 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="wShnzNkp"; dkim-atps=neutral Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E9BE6A90A for ; Wed, 18 Nov 2026 21:33:53 +0100 (CET) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-8b5e147f101so170132b3a.3 for ; Wed, 18 Nov 2026 12:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795034032; x=1795638832; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YixFM3AWmT7jYQ+cnCQNR8AFTxM/A/eG60HgEXpPHIc=; b=wShnzNkp4mg6CI3YHTPWcKGtD0JF+0iKtsvffsosE7XTQ2LdMOoviKfE6k67aJWIu/ J4CGKZUIku1v5WN8J42+d8ToD8HdiPR39qAuswQlmLm+FJ6KuT+5ej5mEElJU81JvqtW ajiuksXD6Ie6B0qu1HZc9uLAcbeMOCJfXDL+7II7iHYAAdRe2uYaCxMEzUG3ps0X34W8 PiZ/OjaEMCEXg3+rDK4X1ACIJQVeXThjiuljCSSmK6EYRaGXrTcRzj9XuTBZDW6EGzRT L16UFYLcfg6NswE9IGfVrvXSwFJLZITc8kE1eM0ZGq1t3xCYqvcu2tLecdAH6t5f0g+S DWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795034032; x=1795638832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YixFM3AWmT7jYQ+cnCQNR8AFTxM/A/eG60HgEXpPHIc=; b=zrbPGNTNuYFZZt67xXudrow/kZAM0JISlAiM8ewLwtdbWULpm8l/3AdTox6Uavgqa/ NBDWvKtbSyK+1/IS6Ro/2CH4ePnvDEIsNMtH3s5g2mDbQeh+l+SQwzxwVzPj4PpLp9w9 Kf1qHeuPv7ZYPeL4xZwC60azFw//d5+hSPPOGSIO2ffZDNyOFk6SwjWElrJsAZxoGqWV fW1FwW3W6UYV4UAtiwh5zU6rd3tPKDkgLvcY3oA/ROQjVyYg2IjavZ4vDr/xMK1324A9 dE6vGZEPFNBbNX09vpY39mwToUJ3kh+Sa9DinksXSVlfhfvkZbLgfWRd8T8Sjo9aVV1C 2PyA== X-Forwarded-Encrypted: i=1; AL+hErGNGvn3pSIvPGKhoo00f5lqJ9JH8aOKKCPILZt+dt+7opqiEcaXqSXTOhJsMYw5RZpmrigA1H/eEVFxCstzveQ=@lists.libcamera.org X-Gm-Message-State: APuU4Z//fqPv+DkAFyUNja1BZ3A6i+0LdMB6TBLhERkru3QUaBn/PO01 666sWlsQOAQ2PTZwvf6m+/4MullGZ6QzeW7BZ3ZdThuqQfRIho57IbeQ X-Gm-Gg: AZFdTZeD1MuEIpR1Pmqw6ZC9mMMQHCBCOaRT8UOov4WhSwHSwBQINGd2E/NE/VmAVRd 0cX98LzyyHf5nUJsOwdFRl8a15sXbkRpDWGu8X6Vw0hT8Vadrd1z1DJhLIMtnjovvNeAt3l6YGD OUDGFnHGXOFiE2VZqIFBhkdEhfxyfrzqYEFmQL+ro54AdZO7T37JQrpeSmjpI2YeSrIpDlGCcaL +omG692H8GoZjYzpYHVPeem67TlnXBX71EC1esWBqc08XHRa0B/JLXa1wNVOw2qxe0OzEA/aXE4 IfVC1OMeY5yfWrcXYjRGlR9qBIRrLMc0PRx0nLa5Vqo+zswfL0ubc9Fqc2xsibclDyr5lgeQbgx ELAZTwEYTSHMpjrEYtgs89IGG+z0mvKhKzARzf2gMcHaLk/RlYd/U4PDiJQJjPIhRzsV1nD+KGt PCc6XwclOPkTrW7Cv6SJBh+vb+8kqaVMXduPu6x2v6a8PvNzfuKXxrUx+rM6VduDjtYmQYb9D85 e9oJ5CslicpT5LENiy51vgL25vLam2UM5hrCrOzbf3zbxZRwIgpCsqt3T+LwpIpF8cAl7ii24Qq MWHt2mv4dR5g5015l30b+ELWBOG6yb7BqFvrAF1V0qu1WGk6wQW/39UoZBfoFw== X-Received: by 2002:a17:902:e888:b0:2ed:29a5:782d with SMTP id d9443c01a7336-2eff72e15f0mr59296815ad.2.1795034031819; Wed, 18 Nov 2026 12:33:51 -0800 (PST) Received: from FAIZEL-KB.. ([2001:569:52f5:4b00:cfaf:4885:b023:6316]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2eff6116331sm19166825ad.22.2026.11.18.12.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 12:33:51 -0800 (PST) From: Faizel K B To: Mehdi Djait , Michael Riesch Cc: Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, libcamera-devel@lists.libcamera.org, Robert Mader , Faizel K B Subject: [PATCH v2 1/2] media: rockchip: rkcif: Filter enumerated formats by media bus code Date: Wed, 18 Nov 2026 13:31:33 -0700 Message-ID: <20261118203134.315591-2-faizel.kb@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261118203134.315591-1-faizel.kb@gmail.com> References: <20261118203134.315591-1-faizel.kb@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" VIDIOC_ENUM_FMT ignores the mbus_code field and returns all formats, although the video devices set V4L2_CAP_IO_MC. Return only the formats that match the requested media bus code. The DVP output formats have no media bus code, so they are still all returned. Otherwise userspace can pick a pixel format that doesn't match the media bus format, and then interprets the captured data in the wrong format. Signed-off-by: Faizel K B --- .../platform/rockchip/rkcif/rkcif-stream.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c index 3130d420ad55..b117ba57bc75 100644 --- a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c +++ b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c @@ -395,13 +395,23 @@ static int rkcif_stream_enum_formats(struct file *file, void *priv, struct v4l2_fmtdesc *f) { struct rkcif_stream *stream = video_drvdata(file); + const struct rkcif_output_fmt *fmt; + unsigned int i, n = 0; - if (f->index >= stream->out_fmts_num) - return -EINVAL; + for (i = 0; i < stream->out_fmts_num; i++) { + fmt = &stream->out_fmts[i]; - f->pixelformat = stream->out_fmts[f->index].fourcc; + if (f->mbus_code && fmt->mbus_code && + fmt->mbus_code != f->mbus_code) + continue; - return 0; + if (n++ == f->index) { + f->pixelformat = fmt->fourcc; + return 0; + } + } + + return -EINVAL; } static int rkcif_stream_enum_framesizes(struct file *file, void *fh,